From ab2c8f1ce15cd88198e4071fa95bc48dd2202f72 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Wed, 11 Mar 2026 13:55:55 +0100 Subject: [PATCH 1/2] Remove ActiveIssue references for Apple Mobile in various tests and update project exclusions --- eng/testing/tests.targets | 1 - .../tests/BitArray/BitArray_CtorTests.cs | 1 - .../Decoding/CustomAttributeDecoderTests.cs | 60 ++++++++++++++----- .../Tests/CustomAttributes/DllImportTests.cs | 2 +- .../RefEmitLoadContextTest.cs | 1 - .../CalendarTests.cs | 1 - .../Reflection/InvokeWithRefLikeArgs.cs | 1 - src/libraries/tests.proj | 2 - 8 files changed, 45 insertions(+), 24 deletions(-) diff --git a/eng/testing/tests.targets b/eng/testing/tests.targets index 1dd5cdd9dfbdaa..7f8f1546b0d143 100644 --- a/eng/testing/tests.targets +++ b/eng/testing/tests.targets @@ -7,7 +7,6 @@ and '$(TargetOS)' != 'browser' and '$(TargetOS)' != 'wasi' and '$(TargetOS)' != 'android' - and '$(TargetsAppleMobile)' != 'true' and '$(RuntimeFlavor)' != 'Mono' and '$(UseRuntimeAsync)' != 'false'"> true diff --git a/src/libraries/System.Collections/tests/BitArray/BitArray_CtorTests.cs b/src/libraries/System.Collections/tests/BitArray/BitArray_CtorTests.cs index 1239e9c201c92f..199b44cd04aa86 100644 --- a/src/libraries/System.Collections/tests/BitArray/BitArray_CtorTests.cs +++ b/src/libraries/System.Collections/tests/BitArray/BitArray_CtorTests.cs @@ -271,7 +271,6 @@ public static void Ctor_Simple_Method_Tests() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public static void Clone_LongLength_Works() { BitArray bitArray = new BitArray(int.MaxValue - 30); diff --git a/src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs b/src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs index 0b7055dc65a04e..8cec5fe3fb0c31 100644 --- a/src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs +++ b/src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs @@ -12,6 +12,35 @@ namespace System.Reflection.Metadata.Decoding.Tests { public class CustomAttributeDecoderTests { + // After ILLink/trimming, type references may point to System.Private.CoreLib + // instead of System.Runtime. Read the actual assembly reference from metadata + // so that expected values match what the decoder produces. + private static readonly string s_systemTypeString = GetSystemTypeStringFromMetadata(); + + private static string GetSystemTypeStringFromMetadata() + { + string location = AssemblyPathHelper.GetAssemblyLocation(typeof(HasAttributes).Assembly); + if (string.IsNullOrEmpty(location) || !File.Exists(location)) + return $"[{MetadataReaderTestHelpers.RuntimeAssemblyName}]System.Type"; + + using FileStream stream = File.OpenRead(location); + using PEReader peReader = new PEReader(stream); + MetadataReader reader = peReader.GetMetadataReader(); + + foreach (TypeReferenceHandle trh in reader.TypeReferences) + { + TypeReference tr = reader.GetTypeReference(trh); + if (reader.GetString(tr.Name) == "Type" && reader.GetString(tr.Namespace) == "System" + && tr.ResolutionScope.Kind == HandleKind.AssemblyReference) + { + AssemblyReference asmRef = reader.GetAssemblyReference((AssemblyReferenceHandle)tr.ResolutionScope); + return $"[{reader.GetString(asmRef.Name)}]System.Type"; + } + } + + return $"[{MetadataReaderTestHelpers.RuntimeAssemblyName}]System.Type"; + } + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.HasAssemblyFiles), nameof(PlatformDetection.IsMonoRuntime))] [ActiveIssue("https://github.com/dotnet/runtime/issues/60579", TestPlatforms.iOS | TestPlatforms.tvOS)] public void TestCustomAttributeDecoder() @@ -86,7 +115,6 @@ public void TestCustomAttributeDecoder() [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.HasAssemblyFiles))] [ActiveIssue("https://github.com/dotnet/runtime/issues/73593", TestRuntimes.Mono)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public void TestCustomAttributeDecoderUsingReflection() { Type type = typeof(HasAttributes); @@ -595,7 +623,7 @@ public TestAttribute(UInt64Enum[] value) { } private string TypeToString(Type type) { if (type == typeof(Type)) - return $"[{MetadataReaderTestHelpers.RuntimeAssemblyName}]System.Type"; + return s_systemTypeString; if (type.IsArray) { @@ -674,13 +702,13 @@ private class CustomAttributeTypeProvider : DisassemblingTypeProvider, ICustomAt { public string GetSystemType() { - return $"[{MetadataReaderTestHelpers.RuntimeAssemblyName}]System.Type"; + return s_systemTypeString; } public bool IsSystemType(string type) { - return type == $"[{MetadataReaderTestHelpers.RuntimeAssemblyName}]System.Type" // encountered as typeref - || Type.GetType(type) == typeof(Type); // encountered as serialized to reflection notation + return type == s_systemTypeString // encountered as typeref + || Type.GetType(type) == typeof(Type); // encountered as serialized to reflection notation } public string GetTypeFromSerializedName(string name) @@ -690,36 +718,36 @@ public string GetTypeFromSerializedName(string name) public PrimitiveTypeCode GetUnderlyingEnumType(string type) { - Type runtimeType = Type.GetType(type.Replace('/', '+')); // '/' vs '+' is only difference between ilasm and reflection notation for fixed set below. + string normalizedType = type.Replace('/', '+'); - if (runtimeType == typeof(SByteEnum)) + if (normalizedType == typeof(SByteEnum).FullName) return PrimitiveTypeCode.SByte; - if (runtimeType == typeof(Int16Enum)) + if (normalizedType == typeof(Int16Enum).FullName) return PrimitiveTypeCode.Int16; - if (runtimeType == typeof(Int32Enum)) + if (normalizedType == typeof(Int32Enum).FullName) return PrimitiveTypeCode.Int32; - if (runtimeType == typeof(Int64Enum)) + if (normalizedType == typeof(Int64Enum).FullName) return PrimitiveTypeCode.Int64; - if (runtimeType == typeof(ByteEnum)) + if (normalizedType == typeof(ByteEnum).FullName) return PrimitiveTypeCode.Byte; - if (runtimeType == typeof(UInt16Enum)) + if (normalizedType == typeof(UInt16Enum).FullName) return PrimitiveTypeCode.UInt16; - if (runtimeType == typeof(UInt32Enum)) + if (normalizedType == typeof(UInt32Enum).FullName) return PrimitiveTypeCode.UInt32; - if (runtimeType == typeof(UInt64Enum)) + if (normalizedType == typeof(UInt64Enum).FullName) return PrimitiveTypeCode.UInt64; - if (runtimeType == typeof(MyEnum)) + if (normalizedType == typeof(MyEnum).FullName) return PrimitiveTypeCode.Byte; - throw new ArgumentOutOfRangeException(); + throw new ArgumentOutOfRangeException(nameof(type), $"Unexpected enum type: '{type}'"); } } } diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs index b157e3ac5f1552..4cfbd98531cef0 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs @@ -47,8 +47,8 @@ private static void AssertEqual(DllImportAttribute d1, DllImportAttribute d2) } [Theory] - [ActiveIssue("https://github.com/mono/mono/issues/15340", TestRuntimes.Mono)] [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] + [ActiveIssue("https://github.com/mono/mono/issues/15340", TestRuntimes.Mono)] [MemberData(nameof(MarshalAsTheoryData))] public static void TestMarshalAsPseudoCustomAttribute(string fieldName, MarshalAsAttribute expected) { diff --git a/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs b/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs index 3a728a22d33da9..3694e501adb48d 100644 --- a/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs +++ b/src/libraries/System.Runtime.Loader/tests/RefEmitLoadContext/RefEmitLoadContextTest.cs @@ -66,7 +66,6 @@ private static void DeleteDirectory() [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.HasAssemblyFiles))] [ActiveIssue("https://github.com/dotnet/runtime/issues/31804", TestRuntimes.Mono)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public static void LoadRefEmitAssembly() { Init(); diff --git a/src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/CalendarTestWithConfigSwitch/CalendarTests.cs b/src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/CalendarTestWithConfigSwitch/CalendarTests.cs index fea702fd503e85..804a3a55b270ae 100644 --- a/src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/CalendarTestWithConfigSwitch/CalendarTests.cs +++ b/src/libraries/System.Runtime/tests/System.Globalization.Calendars.Tests/CalendarTestWithConfigSwitch/CalendarTests.cs @@ -11,7 +11,6 @@ public static class CalendarTests { [Fact] [SkipOnPlatform(TestPlatforms.Android, "Doesn't throw on mobile")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public static void TestJapaneseCalendarDateParsing() { CultureInfo ciJapanese = new CultureInfo("ja-JP") { DateTimeFormat = { Calendar = new JapaneseCalendar() } }; diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.cs index bf8c1ba01f1be4..a23bb19eb68389 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/InvokeWithRefLikeArgs.cs @@ -37,7 +37,6 @@ public static void MethodTakesRefStructAsArgWithDefaultValue_ThrowsNSE() // Moq heavily utilizes RefEmit, which does not work on most aot workloads [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] [SkipOnMono("https://github.com/dotnet/runtime/issues/40738")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public static void MethodTakesRefToRefStructAsArg_ThrowsNSE() { // Use a Binder to trick the reflection stack into treating the returned null diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 419c4d011cb1af..677832f37b8264 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -638,9 +638,7 @@ - - From 52a8efe3a53a913a820ea2744c64cd530c0c8e68 Mon Sep 17 00:00:00 2001 From: Milos Kotlar Date: Mon, 16 Mar 2026 15:37:26 +0100 Subject: [PATCH 2/2] Remove ActiveIssue references for Apple Mobile from tests and update maccatalyst platform configurations --- .../runtime-extra-platforms-maccatalyst.yml | 6 ++-- eng/testing/tests.targets | 1 + .../tests/CompilationLibraryTests.cs | 1 - .../tests/CompositeResolverTests.cs | 3 -- .../tests/ErrObjectTests.cs | 1 - .../tests/StackFrameTests.cs | 1 - .../tests/TensorPrimitives.Generic.cs | 1 - .../CharCheckingReader/CharReaderTests.cs | 1 - .../tests/XmlSerializer/XmlSerializerTests.cs | 1 - .../Tests/CustomAttributes/DllImportTests.cs | 1 - .../System/DoubleTests.GenericMath.cs | 1 - .../System/ExceptionTests.cs | 2 -- .../System/Reflection/ReflectionCacheTests.cs | 1 - .../CompilerServices/RuntimeFeatureTests.cs | 2 -- .../System/SingleTests.GenericMath.cs | 1 - .../Encoding/TranscodingStreamTests.cs | 10 ------ src/libraries/tests.proj | 31 ------------------- 17 files changed, 3 insertions(+), 62 deletions(-) diff --git a/eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml b/eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml index 92cba45048e616..be9b7f4516468b 100644 --- a/eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml +++ b/eng/pipelines/extra-platforms/runtime-extra-platforms-maccatalyst.yml @@ -216,8 +216,7 @@ jobs: isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }} isiOSLikeOnlyBuild: ${{ parameters.isiOSLikeOnlyBuild }} platforms: - # Tracking issue: https://github.com/dotnet/runtime/issues/124344 - # - maccatalyst_x64 + - maccatalyst_x64 - maccatalyst_arm64 variables: - ${{ if and(eq(variables['System.TeamProject'], 'public'), eq(variables['Build.Reason'], 'PullRequest')) }}: @@ -260,8 +259,7 @@ jobs: isExtraPlatformsBuild: ${{ parameters.isExtraPlatformsBuild }} isMacCatalystOnlyBuild: ${{ parameters.isMacCatalystOnlyBuild }} platforms: - # Tracking issue: https://github.com/dotnet/runtime/issues/124344 - # - maccatalyst_x64 + - maccatalyst_x64 - maccatalyst_arm64 variables: # map dependencies variables to local variables diff --git a/eng/testing/tests.targets b/eng/testing/tests.targets index a9067690dc13bc..9336d5bdc24913 100644 --- a/eng/testing/tests.targets +++ b/eng/testing/tests.targets @@ -6,6 +6,7 @@ and '$(UseNativeAOTRuntime)' != 'true' and '$(TargetOS)' != 'wasi' and '$(TargetOS)' != 'android' + and '$(TargetsAppleMobile)' != 'true' and '$(RuntimeFlavor)' != 'Mono' and '$(UseRuntimeAsync)' != 'false'"> true diff --git a/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs b/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs index a5ee77da175fce..8ea5551b760f58 100644 --- a/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs +++ b/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompilationLibraryTests.cs @@ -15,7 +15,6 @@ public class CompilationLibraryTests { // Moq heavily utilizes RefEmit, which does not work on most aot workloads [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public void ResolveReferencePathsAcceptsCustomResolvers() { var fail = new Mock(); diff --git a/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompositeResolverTests.cs b/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompositeResolverTests.cs index 647d060468487e..b694513cc4d510 100644 --- a/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompositeResolverTests.cs +++ b/src/libraries/Microsoft.Extensions.DependencyModel/tests/CompositeResolverTests.cs @@ -16,7 +16,6 @@ public class CompositeResolverTests { // Moq heavily utilizes RefEmit, which does not work on most aot workloads [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public void ReturnsFirstSuccessfulResolve() { var fail = new Mock(); @@ -48,7 +47,6 @@ public void ReturnsFirstSuccessfulResolve() // Moq heavily utilizes RefEmit, which does not work on most aot workloads [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public void PassesLibraryToAllResolvers() { var fail = new Mock(); @@ -70,7 +68,6 @@ public void PassesLibraryToAllResolvers() // Moq heavily utilizes RefEmit, which does not work on most aot workloads [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public void PopulatedAssemblies() { var fail = new Mock(); diff --git a/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs b/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs index 1d11cfa92aedb2..61a1f8c4b66fbd 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs +++ b/src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs @@ -12,7 +12,6 @@ public class ErrObjectTests [Fact] [ActiveIssue("https://github.com/mono/mono/issues/14854", typeof(PlatformDetection), nameof(PlatformDetection.IsSingleFile))] [ActiveIssue("https://github.com/mono/mono/issues/14854", TestRuntimes.Mono)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public void Clear() { ProjectData.ClearProjectError(); diff --git a/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs b/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs index 02689dede3a119..c1476ae2cf60df 100644 --- a/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs +++ b/src/libraries/System.Diagnostics.StackTrace/tests/StackFrameTests.cs @@ -37,7 +37,6 @@ public void Ctor_FNeedFileInfo(bool fNeedFileInfo) [Theory] [ActiveIssue("https://github.com/mono/mono/issues/15187", TestRuntimes.Mono)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile))] [InlineData(StackFrame.OFFSET_UNKNOWN, true)] [InlineData(0, true)] [InlineData(1, true)] diff --git a/src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs b/src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs index 775ec9b7e920e0..94246efcdee482 100644 --- a/src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs +++ b/src/libraries/System.Numerics.Tensors/tests/TensorPrimitives.Generic.cs @@ -570,7 +570,6 @@ public void SpanDestinationFunctions_SpecialValues(SpanDestinationDelegate tenso } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [MemberData(nameof(SpanDestinationFunctionsToTest))] public void SpanDestinationFunctions_ValueRange(SpanDestinationDelegate tensorPrimitivesMethod, Func expectedMethod, T? tolerance = null) { diff --git a/src/libraries/System.Private.Xml/tests/Readers/CharCheckingReader/CharReaderTests.cs b/src/libraries/System.Private.Xml/tests/Readers/CharCheckingReader/CharReaderTests.cs index ae95f7c15d7569..479c514497be50 100644 --- a/src/libraries/System.Private.Xml/tests/Readers/CharCheckingReader/CharReaderTests.cs +++ b/src/libraries/System.Private.Xml/tests/Readers/CharCheckingReader/CharReaderTests.cs @@ -11,7 +11,6 @@ public partial class CharCheckingReaderTest : CGenericTestModule { [Theory] [XmlTests(nameof(Create))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public void RunTests(XunitTestCase testCase) { testCase.Run(); diff --git a/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs b/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs index a559c4fd5a8199..71237bd9a882dd 100644 --- a/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs +++ b/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs @@ -2569,7 +2569,6 @@ public static void Xml_TypeWithSpecialCharacterInStringMember() #endif [ActiveIssue("https://github.com/dotnet/runtime/issues/34072", TestRuntimes.Mono)] [ActiveIssue("https://github.com/dotnet/runtime/issues/95928", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public static void Xml_TypeInCollectibleALC() { ExecuteAndUnload("SerializableAssembly.dll", "SerializationTypes.SimpleType", out var weakRef); diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs index 4cfbd98531cef0..0c4a50248db28b 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/CustomAttributes/DllImportTests.cs @@ -47,7 +47,6 @@ private static void AssertEqual(DllImportAttribute d1, DllImportAttribute d2) } [Theory] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ActiveIssue("https://github.com/mono/mono/issues/15340", TestRuntimes.Mono)] [MemberData(nameof(MarshalAsTheoryData))] public static void TestMarshalAsPseudoCustomAttribute(string fieldName, MarshalAsAttribute expected) diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DoubleTests.GenericMath.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DoubleTests.GenericMath.cs index f09a6f6e0ad8d0..47eddc74a69203 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DoubleTests.GenericMath.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DoubleTests.GenericMath.cs @@ -398,7 +398,6 @@ public static void ConvertToIntegerTest() [Fact] [SkipOnMono("https://github.com/dotnet/runtime/issues/100368")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsX64Process), nameof(PlatformDetection.IsCoreCLR))] [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void ConvertToIntegerNativeTest() { diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ExceptionTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ExceptionTests.cs index 843813a14997a4..42024147d9df26 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ExceptionTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/ExceptionTests.cs @@ -109,7 +109,6 @@ public static void Exception_TargetSite_Rethrow() [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.HasAssemblyFiles))] [ActiveIssue("https://github.com/mono/mono/issues/15140", TestRuntimes.Mono)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public static void ThrowStatementDoesNotResetExceptionStackLineSameMethod() { (string, string, int) rethrownExceptionStackFrame = (null, null, 0); @@ -140,7 +139,6 @@ private static (string, string, int) ThrowAndRethrowSameMethod(out (string, stri [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotArm64Process), nameof(PlatformDetection.HasAssemblyFiles))] // [ActiveIssue(https://github.com/dotnet/runtime/issues/1871)] can't use ActiveIssue for archs [ActiveIssue("https://github.com/mono/mono/issues/15141", TestRuntimes.Mono)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsX64Process), nameof(PlatformDetection.IsCoreCLR))] public static void ThrowStatementDoesNotResetExceptionStackLineOtherMethod() { (string, string, int) rethrownExceptionStackFrame = (null, null, 0); diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/ReflectionCacheTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/ReflectionCacheTests.cs index d85e041d8a9036..a5922112c1d98e 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/ReflectionCacheTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/ReflectionCacheTests.cs @@ -77,7 +77,6 @@ void AssertSameEqualAndHashCodeEqual(object o1, object o2) [ActiveIssue("https://github.com/dotnet/runtime/issues/50978", TestRuntimes.Mono)] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMetadataUpdateSupported))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public void InvokeClearCache_NoExceptions() { Action clearCache = GetClearCacheMethod(); diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs index 3034ba12cf2f30..63f4eb15db5955 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs @@ -19,7 +19,6 @@ public static void PortablePdb() } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCode() { Assert.Equal(RuntimeFeature.IsDynamicCodeSupported, RuntimeFeature.IsSupported("IsDynamicCodeSupported")); @@ -34,7 +33,6 @@ public static void DynamicCode() [Fact] [SkipOnMono("IsDynamicCodeCompiled returns false in cases where mono doesn't support these features")] [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] public static void DynamicCode_Jit() { if (PlatformDetection.IsNativeAot) diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/SingleTests.GenericMath.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/SingleTests.GenericMath.cs index a072749010805f..a21b70c5217b37 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/SingleTests.GenericMath.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/SingleTests.GenericMath.cs @@ -398,7 +398,6 @@ public static void ConvertToIntegerTest() [Fact] [SkipOnMono("https://github.com/dotnet/runtime/issues/100368")] - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsX64Process), nameof(PlatformDetection.IsCoreCLR))] [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] public static void ConvertToIntegerNativeTest() { diff --git a/src/libraries/System.Runtime/tests/System.Text.Encoding.Tests/Encoding/TranscodingStreamTests.cs b/src/libraries/System.Runtime/tests/System.Text.Encoding.Tests/Encoding/TranscodingStreamTests.cs index ab57f6b0cc969c..6f1dbd29b0c088 100644 --- a/src/libraries/System.Runtime/tests/System.Text.Encoding.Tests/Encoding/TranscodingStreamTests.cs +++ b/src/libraries/System.Runtime/tests/System.Text.Encoding.Tests/Encoding/TranscodingStreamTests.cs @@ -40,7 +40,6 @@ public static IEnumerable ReadWriteTestBufferLengths } // Moq heavily utilizes RefEmit, which does not work on most aot workloads - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] public void AsyncMethods_ReturnCanceledTaskIfCancellationTokenTripped() { @@ -79,7 +78,6 @@ public void CreateTranscodingStream_InvalidArgs() Assert.Throws("outerStreamEncoding", () => Encoding.CreateTranscodingStream(Stream.Null, Encoding.UTF8, null)); } - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] [InlineData(true)] [InlineData(false)] @@ -103,7 +101,6 @@ public void CanRead_DelegatesToInnerStream(bool expectedCanRead) Assert.False(actualCanReadAfterDispose); } - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] [InlineData(true)] [InlineData(false)] @@ -203,7 +200,6 @@ public void Dispose_WithLeaveOpenTrue_DoesNotDisposeInnerStream() } // Moq heavily utilizes RefEmit, which does not work on most aot workloads - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] public void Flush_FlushesInnerStreamButNotDecodedState() { @@ -397,7 +393,6 @@ void RunOneTestIteration(int stringLength) } } - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] public Task ReadApm() { @@ -439,7 +434,6 @@ public Task ReadApm() suppressExpectedCancellationTokenAsserts: true); // APM pattern doesn't allow flowing CancellationToken } - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] [MemberData(nameof(ReadWriteTestBufferLengths))] public Task ReadAsync_ByteArray(int bufferLength) @@ -459,7 +453,6 @@ public Task ReadAsync_ByteArray(int bufferLength) }); } - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] [MemberData(nameof(ReadWriteTestBufferLengths))] public async Task ReadAsync_Memory(int bufferLength) @@ -775,7 +768,6 @@ public void Write_WithInvalidArgs_Throws() } // Moq heavily utilizes RefEmit, which does not work on most aot workloads - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] public async Task WriteAsync_WithFullData() { @@ -836,7 +828,6 @@ public async Task WriteAsync_WithFullData() } // Moq heavily utilizes RefEmit, which does not work on most aot workloads - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] public async Task WriteAsync_WithPartialData() { @@ -893,7 +884,6 @@ public void WriteAsync_WithInvalidArgs_Throws() } // Moq heavily utilizes RefEmit, which does not work on most aot workloads - [ActiveIssue("https://github.com/dotnet/runtime/issues/124344", typeof(PlatformDetection), nameof(PlatformDetection.IsAppleMobile), nameof(PlatformDetection.IsCoreCLR))] [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] public void WriteApm() { diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 677832f37b8264..d6cc3b2efa023b 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -634,37 +634,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -