From ba2ffef8d3fe9c557a39e52df6b1338ea8927be9 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 9 Apr 2026 08:05:02 +0000 Subject: [PATCH 1/2] Initial plan From 4e9134e13b072ab129c78a1f94d150a7cf6b9c27 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 9 Apr 2026 08:35:18 +0000 Subject: [PATCH 2/2] Fix test failures: add ConditionalFact/ConditionalTheory with RemoteExecutor.IsSupported guard Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/12002eac-0e34-4fea-8af7-ed738caa200e Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com> --- .../tests/ProcessHandlesTests.Windows.cs | 7 ++++--- .../tests/ProcessStartInfoTests.cs | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessHandlesTests.Windows.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessHandlesTests.Windows.cs index 0734dcb66b6593..a51382d272b559 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessHandlesTests.Windows.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessHandlesTests.Windows.cs @@ -8,6 +8,7 @@ using System.Runtime.InteropServices; using System.Threading.Tasks; using Microsoft.DotNet.RemoteExecutor; +using Microsoft.DotNet.XUnitExtensions; using Microsoft.Win32.SafeHandles; using Xunit; @@ -15,7 +16,7 @@ namespace System.Diagnostics.Tests { public partial class ProcessHandlesTests { - [Fact] + [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] public void ProcessStartedWithInvalidHandles_ConsoleReportsInvalidHandles() { using Process process = CreateProcess(() => @@ -30,7 +31,7 @@ public void ProcessStartedWithInvalidHandles_ConsoleReportsInvalidHandles() Assert.Equal(RemoteExecutor.SuccessExitCode, RunWithInvalidHandles(process.StartInfo)); } - [Theory] + [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] [InlineData(false)] [InlineData(true)] public void ProcessStartedWithInvalidHandles_CanStartChildProcessWithDerivedInvalidHandles(bool restrictHandles) @@ -64,7 +65,7 @@ public void ProcessStartedWithInvalidHandles_CanStartChildProcessWithDerivedInva Assert.Equal(RemoteExecutor.SuccessExitCode, RunWithInvalidHandles(process.StartInfo)); } - [Theory] + [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] [InlineData(false)] [InlineData(true)] public void ProcessStartedWithInvalidHandles_CanRedirectOutput(bool restrictHandles) diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs index ef27eacf7f1102..11c6225e13687b 100644 --- a/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs +++ b/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs @@ -1445,7 +1445,7 @@ public void StartInfo_LoadUserProfile_And_UseCredentialsForNetworkingOnly_AreInc }); } - [Fact] + [ConditionalFact(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))] public void UserNameCantBeCombinedWithInheritedHandles() { using Process longRunning = CreateProcessLong();