From 4a6263da69f52db923c814f958931c8440b1a27d Mon Sep 17 00:00:00 2001 From: Eduardo Velarde Date: Mon, 20 Apr 2026 18:17:03 -0700 Subject: [PATCH 1/2] Update test --- .../ArgumentValidationTests.cs | 24 ++++++------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs index 33f74f47df3c3f..df6d993ac8275e 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs @@ -402,25 +402,15 @@ public void SelectPoll_NegativeTimeSpan_Throws() [Fact] public void SelectPoll_InfiniteTimeSpan_Ok() { - using (Socket host = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp)) + using (Socket s = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp)) { - host.Bind(new IPEndPoint(IPAddress.Loopback, 0)); - host.Listen(1); - Task accept = host.AcceptAsync(); - - using (Socket s = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp)) - { - s.Connect(new IPEndPoint(IPAddress.Loopback, ((IPEndPoint)host.LocalEndPoint).Port)); - - var list = new List(); - list.Add(s); + var list = new List { s }; - // should be writable - Socket.Select(null, list, null, Timeout.InfiniteTimeSpan); - Socket.Select(null, list, null, -1); - s.Poll(Timeout.InfiniteTimeSpan, SelectMode.SelectWrite); - s.Poll(-1, SelectMode.SelectWrite); - } + // should be writable + Socket.Select(null, list, null, Timeout.InfiniteTimeSpan); + Socket.Select(null, list, null, -1); + s.Poll(Timeout.InfiniteTimeSpan, SelectMode.SelectWrite); + s.Poll(-1, SelectMode.SelectWrite); } } From 6842e9a7850233a161b8e1cb718d2d6d21120780 Mon Sep 17 00:00:00 2001 From: Eduardo Velarde Date: Mon, 20 Apr 2026 18:50:13 -0700 Subject: [PATCH 2/2] Copilot feedback --- .../tests/FunctionalTests/ArgumentValidationTests.cs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs b/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs index df6d993ac8275e..b32a105ccc9a19 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/ArgumentValidationTests.cs @@ -404,13 +404,16 @@ public void SelectPoll_InfiniteTimeSpan_Ok() { using (Socket s = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp)) { - var list = new List { s }; - // should be writable + var list = new List { s }; Socket.Select(null, list, null, Timeout.InfiniteTimeSpan); + Assert.Equal(new[] { s }, list); + Socket.Select(null, list, null, -1); - s.Poll(Timeout.InfiniteTimeSpan, SelectMode.SelectWrite); - s.Poll(-1, SelectMode.SelectWrite); + Assert.Equal(new[] { s }, list); + + Assert.True(s.Poll(Timeout.InfiniteTimeSpan, SelectMode.SelectWrite)); + Assert.True(s.Poll(-1, SelectMode.SelectWrite)); } }