From f1a67d44d234993edeb8231567743888a7142ecc Mon Sep 17 00:00:00 2001 From: Seth Jackson Date: Tue, 21 Apr 2026 03:29:14 -0400 Subject: [PATCH 1/3] Fix exception/seh.cpp on OpenBSD --- src/coreclr/pal/src/exception/seh.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/coreclr/pal/src/exception/seh.cpp b/src/coreclr/pal/src/exception/seh.cpp index 5aea2481bd4162..84e13a9b5dce9d 100644 --- a/src/coreclr/pal/src/exception/seh.cpp +++ b/src/coreclr/pal/src/exception/seh.cpp @@ -303,7 +303,7 @@ PAL_ERROR SEHEnable(CPalThread *pthrCurrent) { #if HAVE_MACH_EXCEPTIONS return pthrCurrent->EnableMachExceptions(); -#elif defined(__linux__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__sun) || defined(__HAIKU__) || defined(__APPLE__) || defined(__wasm__) +#elif defined(__linux__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__sun) || defined(__HAIKU__) || defined(__APPLE__) || defined(__wasm__) return NO_ERROR; #else // HAVE_MACH_EXCEPTIONS #error not yet implemented @@ -328,7 +328,7 @@ PAL_ERROR SEHDisable(CPalThread *pthrCurrent) { #if HAVE_MACH_EXCEPTIONS return pthrCurrent->DisableMachExceptions(); -#elif defined(__linux__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__sun) || defined(__HAIKU__) || defined(__APPLE__) || defined(__wasm__) +#elif defined(__linux__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__sun) || defined(__HAIKU__) || defined(__APPLE__) || defined(__wasm__) return NO_ERROR; #else // HAVE_MACH_EXCEPTIONS #error not yet implemented From 58c03de9039c31802b75b01f222d633065d6ec5f Mon Sep 17 00:00:00 2001 From: Jan Kotas Date: Tue, 21 Apr 2026 05:56:15 -0700 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Jan Kotas --- src/coreclr/pal/src/exception/seh.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/coreclr/pal/src/exception/seh.cpp b/src/coreclr/pal/src/exception/seh.cpp index 84e13a9b5dce9d..8aa929e75296e8 100644 --- a/src/coreclr/pal/src/exception/seh.cpp +++ b/src/coreclr/pal/src/exception/seh.cpp @@ -303,10 +303,8 @@ PAL_ERROR SEHEnable(CPalThread *pthrCurrent) { #if HAVE_MACH_EXCEPTIONS return pthrCurrent->EnableMachExceptions(); -#elif defined(__linux__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__sun) || defined(__HAIKU__) || defined(__APPLE__) || defined(__wasm__) +#else return NO_ERROR; -#else // HAVE_MACH_EXCEPTIONS -#error not yet implemented #endif // HAVE_MACH_EXCEPTIONS } @@ -328,10 +326,8 @@ PAL_ERROR SEHDisable(CPalThread *pthrCurrent) { #if HAVE_MACH_EXCEPTIONS return pthrCurrent->DisableMachExceptions(); -#elif defined(__linux__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__) || defined(__sun) || defined(__HAIKU__) || defined(__APPLE__) || defined(__wasm__) +#else return NO_ERROR; -#else // HAVE_MACH_EXCEPTIONS -#error not yet implemented #endif // HAVE_MACH_EXCEPTIONS } From 86cbed0ed67bb663314bc27fc0fefdd5d50c9eb1 Mon Sep 17 00:00:00 2001 From: Jan Kotas Date: Tue, 21 Apr 2026 05:57:08 -0700 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Jan Kotas --- src/coreclr/pal/src/exception/seh.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/coreclr/pal/src/exception/seh.cpp b/src/coreclr/pal/src/exception/seh.cpp index 8aa929e75296e8..dda145c6735fad 100644 --- a/src/coreclr/pal/src/exception/seh.cpp +++ b/src/coreclr/pal/src/exception/seh.cpp @@ -303,7 +303,7 @@ PAL_ERROR SEHEnable(CPalThread *pthrCurrent) { #if HAVE_MACH_EXCEPTIONS return pthrCurrent->EnableMachExceptions(); -#else +#else // HAVE_MACH_EXCEPTIONS return NO_ERROR; #endif // HAVE_MACH_EXCEPTIONS } @@ -326,7 +326,7 @@ PAL_ERROR SEHDisable(CPalThread *pthrCurrent) { #if HAVE_MACH_EXCEPTIONS return pthrCurrent->DisableMachExceptions(); -#else +#else // HAVE_MACH_EXCEPTIONS return NO_ERROR; #endif // HAVE_MACH_EXCEPTIONS }