From 93ad80eb64aabc2df2d93a136c2f86b73f590b87 Mon Sep 17 00:00:00 2001 From: EgorBo Date: Sat, 23 Nov 2019 01:06:34 +0300 Subject: [PATCH 1/3] Remove DynamicCode_Jit test --- .../System/Runtime/CompilerServices/RuntimeFeatureTests.cs | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs index 21771693240e0b..f7e99e0d049d29 100644 --- a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs +++ b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs @@ -27,12 +27,5 @@ public static void DynamicCode() Assert.True(RuntimeFeature.IsDynamicCodeSupported); } } - - [Fact] - public static void DynamicCode_Jit() - { - Assert.True(RuntimeFeature.IsDynamicCodeSupported); - Assert.True(RuntimeFeature.IsDynamicCodeCompiled); - } } } From e45b79d26fcee9770842c9681e6907430b08aebc Mon Sep 17 00:00:00 2001 From: EgorBo Date: Sun, 24 Nov 2019 02:57:50 +0300 Subject: [PATCH 2/3] Don't run the test on mono runtime --- .../Runtime/CompilerServices/RuntimeFeatureTests.cs | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs index f7e99e0d049d29..90e30c8a1c4f6e 100644 --- a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs +++ b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs @@ -27,5 +27,16 @@ public static void DynamicCode() Assert.True(RuntimeFeature.IsDynamicCodeSupported); } } + + [Fact] + public static void DynamicCode_Jit() + { + // some modes on Mono don't support these features + if (!PlatformDetection.IsMonoRuntime) + { + Assert.True(RuntimeFeature.IsDynamicCodeSupported); + Assert.True(RuntimeFeature.IsDynamicCodeCompiled); + } + } } } From 8a157a2928d08ca389cdcb1231f83608ade4d3ef Mon Sep 17 00:00:00 2001 From: EgorBo Date: Tue, 26 Nov 2019 22:45:43 +0300 Subject: [PATCH 3/3] use [SkipOnMono] --- .../Runtime/CompilerServices/RuntimeFeatureTests.cs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs index 90e30c8a1c4f6e..ba9934ed1c1fb7 100644 --- a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs +++ b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs @@ -5,6 +5,7 @@ using System; using System.Runtime.CompilerServices; using Xunit; +using Microsoft.DotNet.XUnitExtensions.Attributes; namespace System.Runtime.CompilerServices.Tests { @@ -29,14 +30,11 @@ public static void DynamicCode() } [Fact] + [SkipOnMono] public static void DynamicCode_Jit() { - // some modes on Mono don't support these features - if (!PlatformDetection.IsMonoRuntime) - { - Assert.True(RuntimeFeature.IsDynamicCodeSupported); - Assert.True(RuntimeFeature.IsDynamicCodeCompiled); - } + Assert.True(RuntimeFeature.IsDynamicCodeSupported); + Assert.True(RuntimeFeature.IsDynamicCodeCompiled); } } }