From 020eb139ef8588fe20ba9760aca807d11e405177 Mon Sep 17 00:00:00 2001 From: Santiago Fernandez Madero Date: Tue, 26 Nov 2019 17:28:17 -0800 Subject: [PATCH 1/2] Add skip reason to SkipOnMono attribute --- .../System/Runtime/CompilerServices/RuntimeFeatureTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs index ba9934ed1c1fb7..b09df2c88fc955 100644 --- a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs +++ b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs @@ -30,7 +30,7 @@ public static void DynamicCode() } [Fact] - [SkipOnMono] + [SkipOnMono("Crashes with IsDynamicCodeCompiled interpreter set to false")] public static void DynamicCode_Jit() { Assert.True(RuntimeFeature.IsDynamicCodeSupported); From 7a2d62888a8ade2cd6c2124cdcc6f4906d52503d Mon Sep 17 00:00:00 2001 From: Santiago Fernandez Madero Date: Tue, 26 Nov 2019 18:00:14 -0800 Subject: [PATCH 2/2] PR Feedback --- .../System/Runtime/CompilerServices/RuntimeFeatureTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs index b09df2c88fc955..775e8d4117c45c 100644 --- a/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs +++ b/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs @@ -30,7 +30,7 @@ public static void DynamicCode() } [Fact] - [SkipOnMono("Crashes with IsDynamicCodeCompiled interpreter set to false")] + [SkipOnMono("IsDynamicCodeCompiled returns false in cases where mono doesn't support these features")] public static void DynamicCode_Jit() { Assert.True(RuntimeFeature.IsDynamicCodeSupported);