From a023c6f02f22d32d30213f1912b3e138aaccc4da Mon Sep 17 00:00:00 2001 From: David Wrighton Date: Wed, 6 May 2020 13:26:53 -0700 Subject: [PATCH 01/16] parent b70309a5e8cfb89912001ec3d1deeec5f553411b author David Wrighton 1588796813 -0700 committer Nathan Ricci 1588797987 -0400 parent b70309a5e8cfb89912001ec3d1deeec5f553411b author David Wrighton 1588796813 -0700 committer Nathan Ricci 1588797985 -0400 parent b70309a5e8cfb89912001ec3d1deeec5f553411b author David Wrighton 1588796813 -0700 committer Nathan Ricci 1588797980 -0400 parent b70309a5e8cfb89912001ec3d1deeec5f553411b author David Wrighton 1588796813 -0700 committer Nathan Ricci 1588797960 -0400 Added ci lane for linux-arm64 on mono. More updates to issues.targets Removed whitespace changes, again. Remvoed trailing whitespace. More indentation fixes. Added more archs for runtime tests. undo unecessary changes. Changed list of architectures to prioritize most important ones. Added build for Linux_arm libraries. got rid of extra arm build. Added linux_arm, linux_arm64 debug library builds. remvoed extra arm64 libraries build. White space. Removed white space. Switched to release version of libraries. Always adding RuntimeFlavor to the libs builds Changed arm. Changed where arm is built. Changed where arm is built. Moved arm back to release build only. Added upper case version of liveLibraryBuildConfig. --- eng/pipelines/libraries/base-job.yml | 3 ++- .../mono/templates/xplat-pipeline-job.yml | 12 +++++++---- eng/pipelines/runtime.yml | 2 ++ .../ReadyToRun/DebugInfoTableNode.cs | 20 +++++++++---------- .../ReadyToRun/MethodWithGCInfo.cs | 16 +++++++++------ src/coreclr/tests/issues.targets | 11 ++++++++++ 6 files changed, 43 insertions(+), 21 deletions(-) diff --git a/eng/pipelines/libraries/base-job.yml b/eng/pipelines/libraries/base-job.yml index 2793183d99ae6a..4ffb57648718be 100644 --- a/eng/pipelines/libraries/base-job.yml +++ b/eng/pipelines/libraries/base-job.yml @@ -48,6 +48,7 @@ jobs: - _extraHelixArguments: '' - _crossBuildPropertyArg: '' - _testRunNamePrefixSuffix: '' + - _runtimeFlavor: /p:RuntimeFlavor=${{ parameters.runtimeFlavor }} - librariesBuildArtifactName: ${{ format('libraries_bin_{0}{1}_{2}_{3}', parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.buildConfig) }} @@ -103,7 +104,7 @@ jobs: - ${{ if ne(parameters.osGroup, 'Windows_NT') }}: - _buildScript: ./$(_buildScriptFileName)$(scriptExt) - - _buildArguments: $(_runtimeConfigurationArg) -configuration ${{ parameters.buildConfig }} -ci -arch ${{ parameters.archType }} $(_finalFrameworkArg) $(_testScopeArg) $(_runtimeOSArg) $(_msbuildCommonParameters) $(_runtimeArtifactsPathArg) $(_crossBuildPropertyArg) + - _buildArguments: $(_runtimeConfigurationArg) -configuration ${{ parameters.buildConfig }} -ci -arch ${{ parameters.archType }} $(_finalFrameworkArg) $(_testScopeArg) $(_runtimeOSArg) $(_runtimeFlavor) $(_msbuildCommonParameters) $(_runtimeArtifactsPathArg) $(_crossBuildPropertyArg) - ${{ parameters.variables }} dependsOn: diff --git a/eng/pipelines/mono/templates/xplat-pipeline-job.yml b/eng/pipelines/mono/templates/xplat-pipeline-job.yml index 052b0f59fcdaa6..f6f4d26ab73cb2 100644 --- a/eng/pipelines/mono/templates/xplat-pipeline-job.yml +++ b/eng/pipelines/mono/templates/xplat-pipeline-job.yml @@ -47,12 +47,11 @@ jobs: gatherAssetManifests: ${{ parameters.gatherAssetManifests }} variables: - - name: coreClrProductArtifactName value: 'CoreCLRProduct_$(osGroup)$(osSubgroup)_$(archType)_${{ parameters.liveRuntimeBuildConfig }}' - name: coreClrProductRootFolderPath - value: '$(Build.SourcesDirectory)/artifacts/bin/coreclr/$(osGroup).$(archType).${{ parameters.liveRuntimeBuildConfig }}' + value: '$(Build.SourcesDirectory)/artifacts/bin/coreclr/$(osGroup).$(archType).$(liveRuntimeBuildConfigUpper)' - name: buildProductArtifactName ${{ if ne(parameters.llvm, true) }}: @@ -87,8 +86,13 @@ jobs: - name: nativeTestArtifactRootFolderPath value: '$(binTestsPath)/obj/$(osGroup).$(archType).$(buildConfigUpper)' - - + - name: liveRuntimeBuildConfigUpper + ${{ if eq(parameters.liveRuntimeBuildConfig, 'release') }}: + value: 'Release' + ${{ if eq(parameters.liveRuntimeBuildConfig, 'checked') }}: + value: 'Checked' + ${{ if eq(parameters.liveRuntimeBuildConfig, 'debug') }}: + value: 'Debug' - librariesBuildArtifactName: '' - librariesOverrideArg: '' diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml index ab7e22e025a767..0b254a69dad352 100644 --- a/eng/pipelines/runtime.yml +++ b/eng/pipelines/runtime.yml @@ -691,6 +691,7 @@ jobs: runtimeFlavor: mono platforms: - OSX_x64 + - Linux_arm64 jobParameters: testGroup: innerloop liveLibrariesBuildConfig: ${{ variables.debugOnPrReleaseOnRolling }} @@ -897,3 +898,4 @@ jobs: eq(dependencies.checkout.outputs['SetPathVars_coreclr.containsChange'], true), eq(dependencies.checkout.outputs['SetPathVars_libraries.containsChange'], true), eq(variables['isFullMatrix'], true)) + diff --git a/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/DebugInfoTableNode.cs b/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/DebugInfoTableNode.cs index 68f04436441446..31fd6ba9570e18 100644 --- a/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/DebugInfoTableNode.cs +++ b/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/DebugInfoTableNode.cs @@ -85,8 +85,8 @@ public override ObjectData GetData(NodeFactory factory, bool relocsOnly = false) { MemoryStream methodDebugBlob = new MemoryStream(); - byte[] bounds = CreateBoundsBlobForMethod(method); - byte[] vars = CreateVarBlobForMethod(method); + byte[] bounds = method.DebugLocInfos; + byte[] vars = method.DebugVarInfos; NibbleWriter nibbleWriter = new NibbleWriter(); nibbleWriter.WriteUInt((uint)(bounds?.Length ?? 0)); @@ -122,16 +122,16 @@ public override ObjectData GetData(NodeFactory factory, bool relocsOnly = false) definedSymbols: new ISymbolDefinitionNode[] { this }); } - private byte[] CreateBoundsBlobForMethod(MethodWithGCInfo method) + public static byte[] CreateBoundsBlobForMethod(OffsetMapping[] offsetMapping) { - if (method.DebugLocInfos == null || method.DebugLocInfos.Length == 0) + if (offsetMapping == null || offsetMapping.Length == 0) return null; NibbleWriter writer = new NibbleWriter(); - writer.WriteUInt((uint)method.DebugLocInfos.Length); + writer.WriteUInt((uint)offsetMapping.Length); uint previousNativeOffset = 0; - foreach (var locInfo in method.DebugLocInfos) + foreach (var locInfo in offsetMapping) { writer.WriteUInt(locInfo.nativeOffset - previousNativeOffset); writer.WriteUInt(locInfo.ilOffset + 3); // Count of items in Internal.JitInterface.MappingTypes to adjust the IL offset by @@ -143,15 +143,15 @@ private byte[] CreateBoundsBlobForMethod(MethodWithGCInfo method) return writer.ToArray(); } - private byte[] CreateVarBlobForMethod(MethodWithGCInfo method) + public static byte[] CreateVarBlobForMethod(NativeVarInfo[] varInfos) { - if (method.DebugVarInfos == null || method.DebugVarInfos.Length == 0) + if (varInfos == null || varInfos.Length == 0) return null; NibbleWriter writer = new NibbleWriter(); - writer.WriteUInt((uint)method.DebugVarInfos.Length); + writer.WriteUInt((uint)varInfos.Length); - foreach (var nativeVarInfo in method.DebugVarInfos) + foreach (var nativeVarInfo in varInfos) { writer.WriteUInt(nativeVarInfo.startOffset); writer.WriteUInt(nativeVarInfo.endOffset - nativeVarInfo.startOffset); diff --git a/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs b/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs index ccf912f7146e77..7c7911a14cfbd6 100644 --- a/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs +++ b/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/MethodWithGCInfo.cs @@ -22,8 +22,8 @@ public class MethodWithGCInfo : ObjectNode, IMethodBodyNode, ISymbolDefinitionNo private FrameInfo[] _frameInfos; private byte[] _gcInfo; private ObjectData _ehInfo; - private OffsetMapping[] _debugLocInfos; - private NativeVarInfo[] _debugVarInfos; + private byte[] _debugLocInfos; + private byte[] _debugVarInfos; private DebugEHClauseInfo[] _debugEHClauseInfos; private List _fixups; private MethodDesc[] _inlinedMethods; @@ -268,20 +268,24 @@ public void InitializeEHInfo(ObjectData ehInfo) _ehInfo = ehInfo; } - public OffsetMapping[] DebugLocInfos => _debugLocInfos; - public NativeVarInfo[] DebugVarInfos => _debugVarInfos; + public byte[] DebugLocInfos => _debugLocInfos; + public byte[] DebugVarInfos => _debugVarInfos; public DebugEHClauseInfo[] DebugEHClauseInfos => _debugEHClauseInfos; public void InitializeDebugLocInfos(OffsetMapping[] debugLocInfos) { Debug.Assert(_debugLocInfos == null); - _debugLocInfos = debugLocInfos; + // Process the debug info from JIT format to R2R format immediately as it is large + // and not used in the rest of the process except to emit. + _debugLocInfos = DebugInfoTableNode.CreateBoundsBlobForMethod(debugLocInfos); } public void InitializeDebugVarInfos(NativeVarInfo[] debugVarInfos) { Debug.Assert(_debugVarInfos == null); - _debugVarInfos = debugVarInfos; + // Process the debug info from JIT format to R2R format immediately as it is large + // and not used in the rest of the process except to emit. + _debugVarInfos = DebugInfoTableNode.CreateVarBlobForMethod(debugVarInfos); } public void InitializeDebugEHClauseInfos(DebugEHClauseInfo[] debugEHClauseInfos) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index 34cbd7c21ef443..4f830c69c7f522 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1693,6 +1693,7 @@ needs triage +<<<<<<< HEAD needs triage @@ -1913,6 +1914,16 @@ needs triage +======= + + + needs triage + + + + needs triage + +>>>>>>> 85bc1ebaa57... Updates to issues.targets. From cd461b618863a5af103b0aad01cb30168a3bdd5a Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Wed, 6 May 2020 17:53:11 -0400 Subject: [PATCH 02/16] Removed changes that shouldn't be here. --- eng/pipelines/libraries/base-job.yml | 3 +-- src/coreclr/tests/issues.targets | 11 ----------- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/eng/pipelines/libraries/base-job.yml b/eng/pipelines/libraries/base-job.yml index 4ffb57648718be..2793183d99ae6a 100644 --- a/eng/pipelines/libraries/base-job.yml +++ b/eng/pipelines/libraries/base-job.yml @@ -48,7 +48,6 @@ jobs: - _extraHelixArguments: '' - _crossBuildPropertyArg: '' - _testRunNamePrefixSuffix: '' - - _runtimeFlavor: /p:RuntimeFlavor=${{ parameters.runtimeFlavor }} - librariesBuildArtifactName: ${{ format('libraries_bin_{0}{1}_{2}_{3}', parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.buildConfig) }} @@ -104,7 +103,7 @@ jobs: - ${{ if ne(parameters.osGroup, 'Windows_NT') }}: - _buildScript: ./$(_buildScriptFileName)$(scriptExt) - - _buildArguments: $(_runtimeConfigurationArg) -configuration ${{ parameters.buildConfig }} -ci -arch ${{ parameters.archType }} $(_finalFrameworkArg) $(_testScopeArg) $(_runtimeOSArg) $(_runtimeFlavor) $(_msbuildCommonParameters) $(_runtimeArtifactsPathArg) $(_crossBuildPropertyArg) + - _buildArguments: $(_runtimeConfigurationArg) -configuration ${{ parameters.buildConfig }} -ci -arch ${{ parameters.archType }} $(_finalFrameworkArg) $(_testScopeArg) $(_runtimeOSArg) $(_msbuildCommonParameters) $(_runtimeArtifactsPathArg) $(_crossBuildPropertyArg) - ${{ parameters.variables }} dependsOn: diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index 4f830c69c7f522..34cbd7c21ef443 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1693,7 +1693,6 @@ needs triage -<<<<<<< HEAD needs triage @@ -1914,16 +1913,6 @@ needs triage -======= - - - needs triage - - - - needs triage - ->>>>>>> 85bc1ebaa57... Updates to issues.targets. From d4306b034cdfd84cf5781aac1dc21eba7fcc2917 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Wed, 6 May 2020 18:35:16 -0400 Subject: [PATCH 03/16] Removed extra newline. --- eng/pipelines/runtime.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml index 0b254a69dad352..26c569b56d80c0 100644 --- a/eng/pipelines/runtime.yml +++ b/eng/pipelines/runtime.yml @@ -898,4 +898,3 @@ jobs: eq(dependencies.checkout.outputs['SetPathVars_coreclr.containsChange'], true), eq(dependencies.checkout.outputs['SetPathVars_libraries.containsChange'], true), eq(variables['isFullMatrix'], true)) - From bcab99033e097d1241249f649c40442453d06385 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Wed, 6 May 2020 18:38:08 -0400 Subject: [PATCH 04/16] Added linux_arm64 to test run. --- eng/pipelines/runtime.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml index 26c569b56d80c0..387f92e574574e 100644 --- a/eng/pipelines/runtime.yml +++ b/eng/pipelines/runtime.yml @@ -712,6 +712,7 @@ jobs: runtimeFlavor: mono platforms: - OSX_x64 + - Linux_arm64 helixQueueGroup: pr helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml jobParameters: From 9bc02180d3f26bc1fd89ce5e6eec173cdfd31f05 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Thu, 7 May 2020 11:15:00 -0400 Subject: [PATCH 05/16] Changed to build config upper. --- eng/pipelines/common/templates/runtimes/run-test-job.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/pipelines/common/templates/runtimes/run-test-job.yml b/eng/pipelines/common/templates/runtimes/run-test-job.yml index c3ce23209fd0e3..cdc2b96129429a 100644 --- a/eng/pipelines/common/templates/runtimes/run-test-job.yml +++ b/eng/pipelines/common/templates/runtimes/run-test-job.yml @@ -274,7 +274,7 @@ jobs: - script: $(_msbuildCommand) $(Build.SourcesDirectory)/src/mono/mono.proj /t:PatchCoreClrCoreRoot - /p:Configuration=$(buildConfig) + /p:Configuration=$(buildConfigUpper) /p:TargetArchitecture=$(archType) displayName: "Patch dotnet with mono" From 322f303eafbca72306886d7f1da727a7491e1d79 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Thu, 7 May 2020 15:49:35 -0400 Subject: [PATCH 06/16] Added arm64 excludes. --- src/coreclr/tests/issues.targets | 182 +++++++++++++++++++++++++++++++ 1 file changed, 182 insertions(+) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index 20777e6f2e4875..d771f13c708c13 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1921,4 +1921,186 @@ + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + + needs triage + + From fa8098ad19ec9bff25399978d94cbe9cbcb8473e Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Thu, 7 May 2020 17:29:37 -0400 Subject: [PATCH 07/16] Fixed issue with issues.targets --- src/coreclr/tests/issues.targets | 121 +++++++++++++++---------------- 1 file changed, 59 insertions(+), 62 deletions(-) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index d771f13c708c13..38268d63d449e8 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1922,184 +1922,181 @@ - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - - needs triage - - + needs triage From 14fa42d782a573d37658372faa5854ce8b063935 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Thu, 7 May 2020 21:03:45 -0400 Subject: [PATCH 08/16] Fixed indentation. --- src/coreclr/tests/issues.targets | 118 +++++++++++++++---------------- 1 file changed, 59 insertions(+), 59 deletions(-) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index 38268d63d449e8..ec91cb644cba17 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1923,181 +1923,181 @@ - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage - needs triage + needs triage From 8f9004a664aae7f953833db53fb278b6ec799b3d Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Fri, 8 May 2020 10:39:42 -0400 Subject: [PATCH 09/16] Added alt jit arch. --- src/coreclr/tests/issues.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index ec91cb644cba17..e563cff2e6a409 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1921,7 +1921,7 @@ - + needs triage From 49554000452efc428265d68b0d0ffec3e3a82e31 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Fri, 8 May 2020 11:59:41 -0400 Subject: [PATCH 10/16] White space. --- src/coreclr/tests/issues.targets | 1 + 1 file changed, 1 insertion(+) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index e563cff2e6a409..aacc21feb6d054 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -2101,3 +2101,4 @@ + From 0ef7c340931ae9061a61ae11cbdb7fd2110261e7 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Fri, 8 May 2020 11:59:58 -0400 Subject: [PATCH 11/16] Undid white space. --- src/coreclr/tests/issues.targets | 1 - 1 file changed, 1 deletion(-) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index aacc21feb6d054..e563cff2e6a409 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -2101,4 +2101,3 @@ - From f90ca895e741715df2bc2071d1379b7d12fea177 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Fri, 8 May 2020 14:44:58 -0400 Subject: [PATCH 12/16] Added missing part of path in issues.targets. --- src/coreclr/tests/issues.targets | 118 +++++++++++++++---------------- 1 file changed, 59 insertions(+), 59 deletions(-) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index e563cff2e6a409..36f50c00ba4cab 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1922,181 +1922,181 @@ - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage From 15ed40a8a7be60fe3d1555f7b16655ea020d33c4 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Fri, 8 May 2020 18:04:44 -0400 Subject: [PATCH 13/16] Got rid of extra x. --- src/coreclr/tests/issues.targets | 120 +++++++++++++++---------------- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index 36f50c00ba4cab..1858f731a58699 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1922,181 +1922,181 @@ - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - - needs triage + + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage - + needs triage From 518adcdb0a918b872cd944cb7768eb1705e76f02 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Fri, 8 May 2020 20:37:29 -0400 Subject: [PATCH 14/16] Excluded another missing test. --- src/coreclr/tests/issues.targets | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index 1858f731a58699..66a6e0946e791e 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -2024,6 +2024,9 @@ needs triage + + needs triage + needs triage From 663364268bc10733aecbc4c0acff861bbf6e75ef Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Sat, 9 May 2020 12:56:05 -0400 Subject: [PATCH 15/16] Added another test to issues.targets. --- src/coreclr/tests/issues.targets | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index 66a6e0946e791e..3ce723a3a2b8a5 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1922,6 +1922,9 @@ + + needs triage + needs triage From 4e9bf289b4be3b1e06f4728da8ad5c6d68c77352 Mon Sep 17 00:00:00 2001 From: Nathan Ricci Date: Sat, 9 May 2020 16:35:26 -0400 Subject: [PATCH 16/16] Added missing paren. --- src/coreclr/tests/issues.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index 3ce723a3a2b8a5..2e10412873f760 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -1922,7 +1922,7 @@ - + needs triage