From 11a4774af592bce4b07e830cac6fca25caa06a6b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Fri, 10 Jul 2020 23:06:47 +0200 Subject: [PATCH 1/2] WASM: Fix System.Formats.Asn1 tests Disable tests that rely on crypto APIs which don't work on WebAssembly right now which allows the test suite to pass: `Tests run: 3406, Errors: 0, Failures: 0, Skipped: 0. Time: 5.296689s` --- .../System.Formats.Asn1/tests/Reader/ReadNamedBitList.cs | 2 ++ .../System.Formats.Asn1/tests/Writer/WriteNamedBitList.cs | 2 ++ src/libraries/tests.proj | 5 ----- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/libraries/System.Formats.Asn1/tests/Reader/ReadNamedBitList.cs b/src/libraries/System.Formats.Asn1/tests/Reader/ReadNamedBitList.cs index a3678a77b954c8..fab9b17f28ab61 100644 --- a/src/libraries/System.Formats.Asn1/tests/Reader/ReadNamedBitList.cs +++ b/src/libraries/System.Formats.Asn1/tests/Reader/ReadNamedBitList.cs @@ -464,6 +464,7 @@ public static void ReadNamedBitList_BitArray_7993Bits(AsnEncodingRules ruleSet) } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)] [InlineData(AsnEncodingRules.BER)] [InlineData(AsnEncodingRules.CER)] [InlineData(AsnEncodingRules.DER)] @@ -495,6 +496,7 @@ public static void VerifyReadNamedBitList_KeyUsage_OneByte(AsnEncodingRules rule } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)] [InlineData(AsnEncodingRules.BER)] [InlineData(AsnEncodingRules.CER)] [InlineData(AsnEncodingRules.DER)] diff --git a/src/libraries/System.Formats.Asn1/tests/Writer/WriteNamedBitList.cs b/src/libraries/System.Formats.Asn1/tests/Writer/WriteNamedBitList.cs index b02e654e224058..5e0a9fbfb2b7c9 100644 --- a/src/libraries/System.Formats.Asn1/tests/Writer/WriteNamedBitList.cs +++ b/src/libraries/System.Formats.Asn1/tests/Writer/WriteNamedBitList.cs @@ -329,6 +329,7 @@ public static void VerifyWriteNamedBitList_BitArray_7993Bits(AsnEncodingRules ru } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)] [InlineData(AsnEncodingRules.BER)] [InlineData(AsnEncodingRules.CER)] [InlineData(AsnEncodingRules.DER)] @@ -360,6 +361,7 @@ public static void VerifyWriteNamedBitList_KeyUsage_OneByte(AsnEncodingRules rul } [Theory] + [ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)] [InlineData(AsnEncodingRules.BER)] [InlineData(AsnEncodingRules.CER)] [InlineData(AsnEncodingRules.DER)] diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 3a4cf8e1d7b5fc..29a5714bb80372 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -29,13 +29,10 @@ - - - @@ -45,14 +42,12 @@ - - From c1ddbe7923487ef6012982d7365a645102e90da1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Sat, 11 Jul 2020 00:31:45 +0200 Subject: [PATCH 2/2] Fix build issue --- .../System.IO.Pipes/tests/System.IO.Pipes.Tests.csproj | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.IO.Pipes/tests/System.IO.Pipes.Tests.csproj b/src/libraries/System.IO.Pipes/tests/System.IO.Pipes.Tests.csproj index bd2aabe486355f..d3759ed22d1c82 100644 --- a/src/libraries/System.IO.Pipes/tests/System.IO.Pipes.Tests.csproj +++ b/src/libraries/System.IO.Pipes/tests/System.IO.Pipes.Tests.csproj @@ -7,6 +7,8 @@ + + @@ -50,7 +52,7 @@ - +