From 423c002a397d88aa27c55915579a13d996fc6900 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Mon, 13 Jul 2020 12:04:08 +0200 Subject: [PATCH 1/2] Add space after "Other" in OperatingSystem.VersionString Follow-up to https://github.com/dotnet/runtime/pull/39130 --- .../System.Private.CoreLib/src/System/OperatingSystem.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs b/src/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs index 5a49935d8ed253..718f67cc9096f5 100644 --- a/src/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs +++ b/src/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs @@ -65,7 +65,7 @@ public string VersionString case PlatformID.Unix: os = "Unix "; break; case PlatformID.Xbox: os = "Xbox "; break; case PlatformID.MacOSX: os = "Mac OS X "; break; - case PlatformID.Other: os = "Other"; break; + case PlatformID.Other: os = "Other "; break; default: Debug.Fail($"Unknown platform {_platform}"); os = " "; break; From d5bed9de21e45b25eb947d651222be5eb9cf6f6e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Mon, 13 Jul 2020 17:09:39 +0200 Subject: [PATCH 2/2] PR feedback --- .../System.Runtime.Extensions/tests/System/EnvironmentTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs index 41e2dfdd946c49..3c7886134122ee 100644 --- a/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs +++ b/src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs @@ -142,7 +142,7 @@ public void OSVersion_ValidVersion() Assert.Contains(version.ToString(2), versionString); - string expectedOS = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "Windows" : RuntimeInformation.IsOSPlatform(OSPlatform.Browser) ? "Other" : "Unix"; + string expectedOS = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "Windows " : RuntimeInformation.IsOSPlatform(OSPlatform.Browser) ? "Other " : "Unix "; Assert.Contains(expectedOS, versionString); }