From 962d30d813d887298e2f52b0a3eea236ff916d76 Mon Sep 17 00:00:00 2001 From: Maryam Ariyan Date: Wed, 15 Jul 2020 20:19:56 -0700 Subject: [PATCH 1/2] ifdefing SuppressGCTransition out of Logging.Console Fixes #39404 --- .../src/Interop/Windows/Kernel32/Interop.GetStdHandle.cs | 2 ++ .../src/Microsoft.Extensions.Logging.Console.csproj | 6 +----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetStdHandle.cs b/src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetStdHandle.cs index 1bd75631ba1e48..b317b13e5499a4 100644 --- a/src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetStdHandle.cs +++ b/src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetStdHandle.cs @@ -9,7 +9,9 @@ internal static partial class Interop internal static partial class Kernel32 { [DllImport(Libraries.Kernel32)] +#if !NO_SUPPRESS_GC_TRANSITION [SuppressGCTransition] +#endif internal static extern IntPtr GetStdHandle(int nStdHandle); // param is NOT a handle, but it returns one! } } diff --git a/src/libraries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj b/src/libraries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj index 9e07f911a6639a..99c56471170e02 100644 --- a/src/libraries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj +++ b/src/libraries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj @@ -5,6 +5,7 @@ true true annotations + $(DefineConstants),NO_SUPRESS_GC_TRANSITION @@ -37,11 +38,6 @@ Link="Common\Interop\Windows\Interop.GetStdHandle.cs" /> - - - - From 80708b6b0ee9234e36ae57f7bb2622fe58940c56 Mon Sep 17 00:00:00 2001 From: Adam Sitnik Date: Thu, 16 Jul 2020 09:21:44 +0200 Subject: [PATCH 2/2] typo fix --- .../src/Microsoft.Extensions.Logging.Console.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj b/src/libraries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj index 99c56471170e02..3afd1b9ed232e9 100644 --- a/src/libraries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj +++ b/src/libraries/Microsoft.Extensions.Logging.Console/src/Microsoft.Extensions.Logging.Console.csproj @@ -5,7 +5,7 @@ true true annotations - $(DefineConstants),NO_SUPRESS_GC_TRANSITION + $(DefineConstants);NO_SUPPRESS_GC_TRANSITION