From 7dd9898883e11d232110c3ce3de06ad4d4433abe Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Fri, 17 Jul 2020 13:22:40 -0400 Subject: [PATCH 1/3] [wasm] Skip Regex tests with BinaryFormatterSupported --- .../tests/RegexMatchTimeoutExceptionTests.cs | 2 +- .../System.Text.RegularExpressions/tests/RegexParserTests.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.Text.RegularExpressions/tests/RegexMatchTimeoutExceptionTests.cs b/src/libraries/System.Text.RegularExpressions/tests/RegexMatchTimeoutExceptionTests.cs index 92c1b914fb849e..438c7659a46e83 100644 --- a/src/libraries/System.Text.RegularExpressions/tests/RegexMatchTimeoutExceptionTests.cs +++ b/src/libraries/System.Text.RegularExpressions/tests/RegexMatchTimeoutExceptionTests.cs @@ -43,7 +43,7 @@ public void Ctor() Assert.Equal(timeout, e.MatchTimeout); } - [Fact] + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))] public void SerializationRoundtrip() { const string Input = "abcdef"; diff --git a/src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs b/src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs index 7228d5d4b42dd5..849afb7f404f84 100644 --- a/src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs +++ b/src/libraries/System.Text.RegularExpressions/tests/RegexParserTests.cs @@ -813,7 +813,7 @@ public void Parse_NotNetFramework(string pattern, RegexOptions options, object e Parse(pattern, options, error); } - [Fact] + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))] [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] public void RegexParseException_Serializes() { From cce6f975f9b24d55c7e82b0eb576cd2c2edc619c Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Fri, 17 Jul 2020 13:42:41 -0400 Subject: [PATCH 2/3] [wasm] Skip Groups_CustomCulture_TestData_AzeriLatin on Browser --- .../tests/Regex.Groups.Tests.cs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.Text.RegularExpressions/tests/Regex.Groups.Tests.cs b/src/libraries/System.Text.RegularExpressions/tests/Regex.Groups.Tests.cs index 2a85402db34e55..4978a94bdc24cc 100644 --- a/src/libraries/System.Text.RegularExpressions/tests/Regex.Groups.Tests.cs +++ b/src/libraries/System.Text.RegularExpressions/tests/Regex.Groups.Tests.cs @@ -856,8 +856,11 @@ public static IEnumerable Groups_CustomCulture_TestData_Turkish() public static IEnumerable Groups_CustomCulture_TestData_AzeriLatin() { - yield return new object[] { "az-Latn-AZ", "\u0131", "\u0049", RegexOptions.IgnoreCase, new string[] { "\u0049" } }; - yield return new object[] { "az-Latn-AZ", "\u0130", "\u0069", RegexOptions.IgnoreCase, new string[] { "\u0069" } }; + if (PlatformDetection.IsNotBrowser) + { + yield return new object[] { "az-Latn-AZ", "\u0131", "\u0049", RegexOptions.IgnoreCase, new string[] { "\u0049" } }; + yield return new object[] { "az-Latn-AZ", "\u0130", "\u0069", RegexOptions.IgnoreCase, new string[] { "\u0069" } }; + } } [Theory] From 03a5e09f2f01b3a84b685e39e34fb4ccea75e592 Mon Sep 17 00:00:00 2001 From: Mitchell Hwang Date: Thu, 16 Jul 2020 16:29:19 -0400 Subject: [PATCH 3/3] [libraries] Remove System.Text.RegularExpressions.Tests project exclusion --- src/libraries/tests.proj | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index a84779ea525fb8..e3f91b2aceb345 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -49,7 +49,6 @@ -