diff --git a/src/coreclr/tests/issues.targets b/src/coreclr/tests/issues.targets index e19d521e42a47f..eb1f6be60e89f4 100644 --- a/src/coreclr/tests/issues.targets +++ b/src/coreclr/tests/issues.targets @@ -5,9 +5,6 @@ https://github.com/dotnet/runtime/issues/11204 - - https://github.com/dotnet/runtime/issues/39361 - timeout diff --git a/src/tests/tracing/eventpipe/gcdump/gcdump.cs b/src/tests/tracing/eventpipe/gcdump/gcdump.cs index 1ee96f83781c71..963544d9e308c9 100644 --- a/src/tests/tracing/eventpipe/gcdump/gcdump.cs +++ b/src/tests/tracing/eventpipe/gcdump/gcdump.cs @@ -82,17 +82,15 @@ public static int Main(string[] args) return () => { - // These values are ~80% (rounded to nice whole numbers) of the values - // I saw when writing the test. The idea is that I want to catch - // any real deviation in the number of types, but don't want to have - // to maintain this test as the number of types varies. (And they will vary due to - // framework code changes). If this test needs any sort of ongoing maintenance - // just change all these values to a low number like 10 and move on. - if (_bulkTypeCount > 125 - && _bulkNodeCount > 600 - && _bulkEdgeCount > 850 - && _bulkRootEdgeCount > 250 - && _bulkRootStaticVarCount > 70) + // Hopefully it is low enough to be resilient to changes in the runtime + // and high enough to catch issues. There should be between hundreds and thousands + // for each, but the number is variable and the point of the test is to verify + // that we get any events at all. + if (_bulkTypeCount > 50 + && _bulkNodeCount > 50 + && _bulkEdgeCount > 50 + && _bulkRootEdgeCount > 50 + && _bulkRootStaticVarCount > 50) { return 100; } @@ -108,4 +106,4 @@ public static int Main(string[] args) }; }; } -} \ No newline at end of file +}