From 559d06d72fad798c6ea1c378681795c67bcc0f5f Mon Sep 17 00:00:00 2001 From: Katelyn Gadd Date: Tue, 28 Jul 2020 09:19:51 -0700 Subject: [PATCH] Assert that we don't get the value we don't want instead of attempting to check for a specific error code. Fixes #39955 --- .../tests/Enumeration/ErrorHandlingTests.cs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.IO.FileSystem/tests/Enumeration/ErrorHandlingTests.cs b/src/libraries/System.IO.FileSystem/tests/Enumeration/ErrorHandlingTests.cs index e6858057bf4f60..2c330cb0b2e708 100644 --- a/src/libraries/System.IO.FileSystem/tests/Enumeration/ErrorHandlingTests.cs +++ b/src/libraries/System.IO.FileSystem/tests/Enumeration/ErrorHandlingTests.cs @@ -73,8 +73,11 @@ public void NotFoundErrorIsExpected() // Make sure we're returning the native error as expected (and not the PAL error on Unix) using (LastError le = new LastError(Path.GetRandomFileName())) { - // Conveniently ERROR_FILE_NOT_FOUND and ENOENT are both 0x2 - Assert.Equal(2, le.Error); + // while ERROR_FILE_NOT_FOUND/ENOENT have predictable values on Windows, Linux and Mac, + // we can't rely on ENOENT having the same value on other platforms. Instead, assert + // that we didn't get the PAL error because we know its value. + const int PAL_Error_ENOENT = 0x1002D; + Assert.NotEqual(PAL_Error_ENOENT, le.Error); } }