From 153a541e3f18363301deba4ab91ffe0e17805055 Mon Sep 17 00:00:00 2001 From: Joseph Shields Date: Fri, 7 Aug 2020 09:36:08 -0400 Subject: [PATCH 1/6] Re-enable testing on OSX 10.15, add 11.0 The 10.15 disable was due to OpenSSL, which we no longer run on Mac anyway --- eng/pipelines/libraries/helix-queues-setup.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/eng/pipelines/libraries/helix-queues-setup.yml b/eng/pipelines/libraries/helix-queues-setup.yml index 33d0ea5aa9dbdd..edcdd34cad6c99 100644 --- a/eng/pipelines/libraries/helix-queues-setup.yml +++ b/eng/pipelines/libraries/helix-queues-setup.yml @@ -78,9 +78,8 @@ jobs: - ${{ if eq(parameters.jobParameters.isFullMatrix, true) }}: - OSX.1013.Amd64.Open - OSX.1014.Amd64.Open - # The 10.15 machines aren't in the same configuration, see - # https://github.com/dotnet/runtime/issues/24736 - #- OSX.1015.Amd64.Open + - OSX.1015.Amd64.Open + - OSX.1100.Amd64.Open - ${{ if eq(parameters.jobParameters.isFullMatrix, false) }}: - OSX.1013.Amd64.Open - OSX.1014.Amd64.Open From 0a6ab297d1022d3963fe26dca2d173cb93204307 Mon Sep 17 00:00:00 2001 From: Joseph Shields Date: Mon, 10 Aug 2020 09:31:31 -0400 Subject: [PATCH 2/6] Actually, test on 2 latest in PR (all supported in fullmatrix) --- eng/pipelines/libraries/helix-queues-setup.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/pipelines/libraries/helix-queues-setup.yml b/eng/pipelines/libraries/helix-queues-setup.yml index edcdd34cad6c99..d6c65c95e17a70 100644 --- a/eng/pipelines/libraries/helix-queues-setup.yml +++ b/eng/pipelines/libraries/helix-queues-setup.yml @@ -81,8 +81,8 @@ jobs: - OSX.1015.Amd64.Open - OSX.1100.Amd64.Open - ${{ if eq(parameters.jobParameters.isFullMatrix, false) }}: - - OSX.1013.Amd64.Open - - OSX.1014.Amd64.Open + - OSX.1015.Amd64.Open + - OSX.1100.Amd64.Open # Windows_NT x64 - ${{ if eq(parameters.platform, 'Windows_NT_x64') }}: From 7dbb2bb92c165eb55a724c23cc3202a65a38220c Mon Sep 17 00:00:00 2001 From: Joseph Shields Date: Wed, 19 Aug 2020 15:10:34 -0400 Subject: [PATCH 3/6] ActiveIssue for failing font issue --- src/libraries/System.Drawing.Common/tests/FontFamilyTests.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libraries/System.Drawing.Common/tests/FontFamilyTests.cs b/src/libraries/System.Drawing.Common/tests/FontFamilyTests.cs index 5e801458355529..a87895ba21303f 100644 --- a/src/libraries/System.Drawing.Common/tests/FontFamilyTests.cs +++ b/src/libraries/System.Drawing.Common/tests/FontFamilyTests.cs @@ -100,6 +100,10 @@ public void Equals_Object_ReturnsExpected(FontFamily fontFamily, object other, b } } + // This will fail on any platform we use libgdiplus, with any + // installed system fonts whose name is longer than 31 chars. + // macOS 10.15+ ships out of the box with a problem font + [ActiveIssue("https://github.com/dotnet/runtime/issues/40937", TestPlatforms.AnyUnix)] [ConditionalFact(Helpers.IsDrawingSupported)] public void Families_Get_ReturnsExpected() { From 2087d143ac80a6e52968054f1b2f5c9753d7a8d7 Mon Sep 17 00:00:00 2001 From: Joseph Shields Date: Fri, 21 Aug 2020 13:14:32 -0400 Subject: [PATCH 4/6] ActiveIssue for Big Sur issue --- .../tests/FunctionalTests/IPGlobalPropertiesTest.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs b/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs index fd7cf08a881cd0..e4d3df548eff6c 100644 --- a/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs +++ b/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs @@ -25,7 +25,8 @@ public IPGlobalPropertiesTest(ITestOutputHelper output) _log = output; } - [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")] + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/40938"), TestPlatforms.OSX] public void IPGlobalProperties_AccessAllMethods_NoErrors() { IPGlobalProperties gp = IPGlobalProperties.GetIPGlobalProperties(); From 9e4243e988b5b94d80c480390e757442c6a21060 Mon Sep 17 00:00:00 2001 From: Joseph Shields Date: Fri, 21 Aug 2020 14:26:19 -0400 Subject: [PATCH 5/6] Fix tpyo --- .../tests/FunctionalTests/IPGlobalPropertiesTest.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs b/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs index e4d3df548eff6c..6823ead1c8ecbb 100644 --- a/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs +++ b/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs @@ -26,7 +26,7 @@ public IPGlobalPropertiesTest(ITestOutputHelper output) } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/40938"), TestPlatforms.OSX] + [ActiveIssue("https://github.com/dotnet/runtime/issues/40938", TestPlatforms.OSX)] public void IPGlobalProperties_AccessAllMethods_NoErrors() { IPGlobalProperties gp = IPGlobalProperties.GetIPGlobalProperties(); From c0c2432d26f5cfac97b61d20312047509e3c0400 Mon Sep 17 00:00:00 2001 From: Joseph Shields Date: Wed, 26 Aug 2020 08:38:41 -0400 Subject: [PATCH 6/6] Revert "ActiveIssue for Big Sur issue" This reverts commit 2087d143ac80a6e52968054f1b2f5c9753d7a8d7. --- .../tests/FunctionalTests/IPGlobalPropertiesTest.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs b/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs index 6823ead1c8ecbb..fd7cf08a881cd0 100644 --- a/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs +++ b/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/IPGlobalPropertiesTest.cs @@ -25,8 +25,7 @@ public IPGlobalPropertiesTest(ITestOutputHelper output) _log = output; } - [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] - [ActiveIssue("https://github.com/dotnet/runtime/issues/40938", TestPlatforms.OSX)] + [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsSubsystemForLinux))] // [ActiveIssue("https://github.com/dotnet/runtime/issues/18258")] public void IPGlobalProperties_AccessAllMethods_NoErrors() { IPGlobalProperties gp = IPGlobalProperties.GetIPGlobalProperties();