From f4ae831715eec698a752428ef83defb8bd6a52da Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Sun, 29 Nov 2020 15:47:45 -0500 Subject: [PATCH 1/2] Revert "Compile System.Private.CoreLib with Crossgen2 by default (#44618)" This reverts commit b79e4d3cd24f76dd1bcb722f589327c827e66632. --- src/coreclr/crossgen-corelib.proj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/crossgen-corelib.proj b/src/coreclr/crossgen-corelib.proj index a394fa781597ab..f4ff62f016f264 100644 --- a/src/coreclr/crossgen-corelib.proj +++ b/src/coreclr/crossgen-corelib.proj @@ -5,7 +5,7 @@ - true + false $(TargetOS).$(TargetArchitecture).$(Configuration) $(RepoRoot)\artifacts From f77187294f99afeea6395ab24e0be0eb7e0665b7 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Sun, 29 Nov 2020 15:51:12 -0500 Subject: [PATCH 2/2] Add a change to ensure libraries are built/tested --- .../src/System/Threading/Channels/AsyncOperation.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.cs b/src/libraries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.cs index 370535da7cc252..b13548cb4aae74 100644 --- a/src/libraries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.cs +++ b/src/libraries/System.Threading.Channels/src/System/Threading/Channels/AsyncOperation.cs @@ -16,7 +16,7 @@ internal abstract class AsyncOperation protected static readonly Action s_availableSentinel = AvailableSentinel; // named method to help with debugging private static void AvailableSentinel(object? s) => Debug.Fail($"{nameof(AsyncOperation)}.{nameof(AvailableSentinel)} invoked with {s}"); - /// Sentinel object used in a field to indicate the operation has completed. + /// Sentinel object used in a field to indicate the operation has completed protected static readonly Action s_completedSentinel = CompletedSentinel; // named method to help with debugging private static void CompletedSentinel(object? s) => Debug.Fail($"{nameof(AsyncOperation)}.{nameof(CompletedSentinel)} invoked with {s}");