From e8dd32b1a1ba2165554cc0f806f4089cf1a1e696 Mon Sep 17 00:00:00 2001
From: xtqqczze <xtqqczze@gmail.com>
Date: Thu, 3 Dec 2020 17:48:44 +0000
Subject: [PATCH 1/3] Upgrade StyleCopAnalyzers to v1.2.0-beta.261

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases/tag/1.2.0-beta.261
---
 eng/Versions.props | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eng/Versions.props b/eng/Versions.props
index db0bc6d18ab4ab..d2ca0f791943a7 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -73,7 +73,7 @@
     <!-- CoreClr dependencies -->
     <MicrosoftNETCoreILAsmVersion>5.0.0-preview.8.20359.4</MicrosoftNETCoreILAsmVersion>
     <!-- Libraries dependencies -->
-    <StyleCopAnalyzersVersion>1.2.0-beta.205</StyleCopAnalyzersVersion>
+    <StyleCopAnalyzersVersion>1.2.0-beta.261</StyleCopAnalyzersVersion>
     <SystemBuffersVersion>4.5.1</SystemBuffersVersion>
     <SystemCollectionsVersion>4.3.0</SystemCollectionsVersion>
     <SystemCollectionsConcurrentVersion>4.3.0</SystemCollectionsConcurrentVersion>

From fd262176ca51f542d8fcf9c4789620c6919fc425 Mon Sep 17 00:00:00 2001
From: xtqqczze <xtqqczze@gmail.com>
Date: Thu, 3 Dec 2020 20:22:14 +0000
Subject: [PATCH 2/3] Disable SA1142

---
 eng/CodeAnalysis.ruleset      | 1 +
 eng/CodeAnalysis.test.ruleset | 1 +
 2 files changed, 2 insertions(+)

diff --git a/eng/CodeAnalysis.ruleset b/eng/CodeAnalysis.ruleset
index 12e930144ed207..23cfb74f663ab3 100644
--- a/eng/CodeAnalysis.ruleset
+++ b/eng/CodeAnalysis.ruleset
@@ -316,6 +316,7 @@
     <Rule Id="SA1137" Action="None" />          <!-- Elements should have the same indentation -->
     <Rule Id="SA1139" Action="None" />          <!-- Use literal suffix notation instead of casting -->
     <Rule Id="SA1141" Action="Warning" />       <!-- Use tuple syntax -->
+    <Rule Id="SA1142" Action="None" />          <!-- Refer to tuple elements by name -->
     <Rule Id="SA1200" Action="None" />          <!-- Using directive should appear within a namespace declaration -->
     <Rule Id="SA1201" Action="None" />          <!-- Elements should appear in the correct order -->
     <Rule Id="SA1202" Action="None" />          <!-- Elements should be ordered by access -->
diff --git a/eng/CodeAnalysis.test.ruleset b/eng/CodeAnalysis.test.ruleset
index f46a2f8157a8c1..aed89c6c73e049 100644
--- a/eng/CodeAnalysis.test.ruleset
+++ b/eng/CodeAnalysis.test.ruleset
@@ -315,6 +315,7 @@
     <Rule Id="SA1137" Action="None" />          <!-- Elements should have the same indentation -->
     <Rule Id="SA1139" Action="None" />          <!-- Use literal suffix notation instead of casting -->
     <Rule Id="SA1141" Action="None" />          <!-- Use tuple syntax -->
+    <Rule Id="SA1142" Action="None" />          <!-- Refer to tuple elements by name -->
     <Rule Id="SA1200" Action="None" />          <!-- Using directive should appear within a namespace declaration -->
     <Rule Id="SA1201" Action="None" />          <!-- Elements should appear in the correct order -->
     <Rule Id="SA1202" Action="None" />          <!-- Elements should be ordered by access -->

From 3227ff67553a9414322afd9628be033866a71021 Mon Sep 17 00:00:00 2001
From: xtqqczze <xtqqczze@gmail.com>
Date: Thu, 3 Dec 2020 21:16:08 +0000
Subject: [PATCH 3/3] Enable SA1142 except in tests

---
 eng/CodeAnalysis.ruleset | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eng/CodeAnalysis.ruleset b/eng/CodeAnalysis.ruleset
index 23cfb74f663ab3..6a6b3132557605 100644
--- a/eng/CodeAnalysis.ruleset
+++ b/eng/CodeAnalysis.ruleset
@@ -316,7 +316,7 @@
     <Rule Id="SA1137" Action="None" />          <!-- Elements should have the same indentation -->
     <Rule Id="SA1139" Action="None" />          <!-- Use literal suffix notation instead of casting -->
     <Rule Id="SA1141" Action="Warning" />       <!-- Use tuple syntax -->
-    <Rule Id="SA1142" Action="None" />          <!-- Refer to tuple elements by name -->
+    <Rule Id="SA1142" Action="Warning" />       <!-- Refer to tuple elements by name -->
     <Rule Id="SA1200" Action="None" />          <!-- Using directive should appear within a namespace declaration -->
     <Rule Id="SA1201" Action="None" />          <!-- Elements should appear in the correct order -->
     <Rule Id="SA1202" Action="None" />          <!-- Elements should be ordered by access -->