From 1e105169aca2d11d615dcaa53c2d4ff90f225c6b Mon Sep 17 00:00:00 2001 From: Ivan Zlatanov Date: Tue, 11 May 2021 13:52:44 +0300 Subject: [PATCH] Reducing the number of times Random.Next is called to improve runtime performance of test on ARM. --- .../tests/WebSocketDeflateTests.cs | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs b/src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs index 50ec0eb10b66ab..f3b2548f1de1e3 100644 --- a/src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs +++ b/src/libraries/System.Net.WebSockets/tests/WebSocketDeflateTests.cs @@ -421,12 +421,6 @@ public async Task ReceiveInvalidCompressedData() [MemberData(nameof(SupportedWindowBits))] public async Task PayloadShouldHaveSimilarSizeWhenSplitIntoSegments(int windowBits) { - if (PlatformDetection.IsArmOrArm64Process && (windowBits == 14 || windowBits == 15)) - { - // https://github.com/dotnet/runtime/issues/52031 - return; - } - MemoryStream stream = new(); using WebSocket client = WebSocket.CreateFromStream(stream, new WebSocketCreationOptions { @@ -440,11 +434,11 @@ public async Task PayloadShouldHaveSimilarSizeWhenSplitIntoSegments(int windowBi int frameSize = 2 << windowBits; byte[] message = new byte[frameSize * 10]; - Random random = new(0); + new Random(0).NextBytes(message); for (int i = 0; i < message.Length; ++i) { - message[i] = (byte)random.Next(maxValue: 10); + message[i] %= 10; } await client.SendAsync(message, WebSocketMessageType.Binary, true, CancellationToken);