From a79dc9ded86277198bac50413485bdf80a1c8663 Mon Sep 17 00:00:00 2001 From: Jose Perez Rodriguez Date: Fri, 7 May 2021 16:14:47 -0700 Subject: [PATCH 1/3] Removing all shared framework linker noWarns --- .../CreateRuntimeRootILLinkDescriptorFile.targets | 3 ++- ...escriptors.xml => ILLink.Descriptors.Common.xml} | 4 ---- .../src/ILLink/ILLink.Descriptors.Windows.xml | 8 ++++++++ ...escriptors.xml => ILLink.Descriptors.Common.xml} | 5 ----- .../src/ILLink/ILLink.Descriptors.Windows.xml | 6 ++++++ .../Microsoft.CSharp/src/Microsoft.CSharp.csproj | 4 ++++ ...scriptors.xml => ILLink.Descriptors.Windows.xml} | 0 .../src/Microsoft.VisualBasic.Core.vbproj | 3 +++ src/libraries/illink-sharedframework.targets | 13 ------------- 9 files changed, 23 insertions(+), 23 deletions(-) rename src/coreclr/System.Private.CoreLib/src/ILLink/{ILLink.Descriptors.xml => ILLink.Descriptors.Common.xml} (85%) create mode 100644 src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Windows.xml rename src/libraries/Microsoft.CSharp/src/ILLink/{ILLink.Descriptors.xml => ILLink.Descriptors.Common.xml} (73%) create mode 100644 src/libraries/Microsoft.CSharp/src/ILLink/ILLink.Descriptors.Windows.xml rename src/libraries/Microsoft.VisualBasic.Core/src/ILLink/{ILLink.Descriptors.xml => ILLink.Descriptors.Windows.xml} (100%) diff --git a/src/coreclr/System.Private.CoreLib/CreateRuntimeRootILLinkDescriptorFile.targets b/src/coreclr/System.Private.CoreLib/CreateRuntimeRootILLinkDescriptorFile.targets index 845e8fccfd8d3c..2f644f01d40ff4 100644 --- a/src/coreclr/System.Private.CoreLib/CreateRuntimeRootILLinkDescriptorFile.targets +++ b/src/coreclr/System.Private.CoreLib/CreateRuntimeRootILLinkDescriptorFile.targets @@ -14,7 +14,8 @@ - <_ILLinkDescriptorsFilePaths Include="$(ILLinkDirectory)ILLink.Descriptors.xml" /> + <_ILLinkDescriptorsFilePaths Include="$(ILLinkDirectory)ILLink.Descriptors.Common.xml" /> + <_ILLinkDescriptorsFilePaths Condition="'$(TargetsWindows)' == 'true'" Include="$(ILLinkDirectory)ILLink.Descriptors.Windows.xml" /> <_ILLinkDescriptorsFilePaths Include="$(CoreLibSharedDir)ILLink\ILLink.Descriptors.Shared.xml" /> diff --git a/src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.xml b/src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Common.xml similarity index 85% rename from src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.xml rename to src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Common.xml index d65f03c0405bb0..e3682b253e3a7e 100644 --- a/src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.xml +++ b/src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Common.xml @@ -9,10 +9,6 @@ - - - - diff --git a/src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Windows.xml b/src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Windows.xml new file mode 100644 index 00000000000000..0648aed9763d13 --- /dev/null +++ b/src/coreclr/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Windows.xml @@ -0,0 +1,8 @@ + + + + + + + + diff --git a/src/libraries/Microsoft.CSharp/src/ILLink/ILLink.Descriptors.xml b/src/libraries/Microsoft.CSharp/src/ILLink/ILLink.Descriptors.Common.xml similarity index 73% rename from src/libraries/Microsoft.CSharp/src/ILLink/ILLink.Descriptors.xml rename to src/libraries/Microsoft.CSharp/src/ILLink/ILLink.Descriptors.Common.xml index 25a8429f396d3f..c572a3e06c4683 100644 --- a/src/libraries/Microsoft.CSharp/src/ILLink/ILLink.Descriptors.xml +++ b/src/libraries/Microsoft.CSharp/src/ILLink/ILLink.Descriptors.Common.xml @@ -1,9 +1,4 @@ - - - - - diff --git a/src/libraries/Microsoft.CSharp/src/ILLink/ILLink.Descriptors.Windows.xml b/src/libraries/Microsoft.CSharp/src/ILLink/ILLink.Descriptors.Windows.xml new file mode 100644 index 00000000000000..4bf5dd43f040f8 --- /dev/null +++ b/src/libraries/Microsoft.CSharp/src/ILLink/ILLink.Descriptors.Windows.xml @@ -0,0 +1,6 @@ + + + + + + diff --git a/src/libraries/Microsoft.CSharp/src/Microsoft.CSharp.csproj b/src/libraries/Microsoft.CSharp/src/Microsoft.CSharp.csproj index 1a5bbb93ca99f4..9e18677697f0dd 100644 --- a/src/libraries/Microsoft.CSharp/src/Microsoft.CSharp.csproj +++ b/src/libraries/Microsoft.CSharp/src/Microsoft.CSharp.csproj @@ -9,6 +9,10 @@ $(DefineConstants);ENABLECOMBINDER true + + + + diff --git a/src/libraries/Microsoft.VisualBasic.Core/src/ILLink/ILLink.Descriptors.xml b/src/libraries/Microsoft.VisualBasic.Core/src/ILLink/ILLink.Descriptors.Windows.xml similarity index 100% rename from src/libraries/Microsoft.VisualBasic.Core/src/ILLink/ILLink.Descriptors.xml rename to src/libraries/Microsoft.VisualBasic.Core/src/ILLink/ILLink.Descriptors.Windows.xml diff --git a/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft.VisualBasic.Core.vbproj b/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft.VisualBasic.Core.vbproj index 3724c9fb49baa9..d4362680482cb0 100644 --- a/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft.VisualBasic.Core.vbproj +++ b/src/libraries/Microsoft.VisualBasic.Core/src/Microsoft.VisualBasic.Core.vbproj @@ -18,6 +18,9 @@ $(NetCoreAppCurrent);$(NetCoreAppCurrent)-windows + + $(ILLinkDirectory)ILLink.Descriptors.Windows.xml + diff --git a/src/libraries/illink-sharedframework.targets b/src/libraries/illink-sharedframework.targets index 1a0df98022d721..ac28f2824bc228 100644 --- a/src/libraries/illink-sharedframework.targets +++ b/src/libraries/illink-sharedframework.targets @@ -14,19 +14,6 @@ $(ILLinkArgs) $(RuntimePackILLinkArgs) -b true - - IL2009;IL2025 - - $(LinkerNoWarn);IL2008 - $(LinkerNoWarn);IL2012 - $(RuntimePackILLinkArgs) --nowarn $(LinkerNoWarn) From 378193d7e2f7221db663b21a897aeee49a3f303e Mon Sep 17 00:00:00 2001 From: Jose Perez Rodriguez Date: Mon, 10 May 2021 11:51:28 -0700 Subject: [PATCH 2/3] Addressing feedback and fixing Browser and windows legs --- .../CreateRuntimeRootILLinkDescriptorFile.targets | 3 ++- ...escriptors.Common.xml => ILLink.Descriptors.Shared.xml} | 0 ...escriptors.Common.xml => ILLink.Descriptors.Shared.xml} | 0 src/libraries/Microsoft.CSharp/src/Microsoft.CSharp.csproj | 2 +- .../src/Microsoft.VisualBasic.Core.vbproj | 2 +- .../src/ILLink/ILLink.Descriptors.NonBrowser.xml | 7 +++++++ .../src/ILLink/ILLink.Descriptors.Shared.xml | 6 ------ .../System.Private.CoreLib/System.Private.CoreLib.csproj | 1 + 8 files changed, 12 insertions(+), 9 deletions(-) rename src/coreclr/System.Private.CoreLib/src/ILLink/{ILLink.Descriptors.Common.xml => ILLink.Descriptors.Shared.xml} (100%) rename src/libraries/Microsoft.CSharp/src/ILLink/{ILLink.Descriptors.Common.xml => ILLink.Descriptors.Shared.xml} (100%) create mode 100644 src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.NonBrowser.xml diff --git a/src/coreclr/System.Private.CoreLib/CreateRuntimeRootILLinkDescriptorFile.targets b/src/coreclr/System.Private.CoreLib/CreateRuntimeRootILLinkDescriptorFile.targets index 2f644f01d40ff4..7c58ddf21df3a2 100644 --- a/src/coreclr/System.Private.CoreLib/CreateRuntimeRootILLinkDescriptorFile.targets +++ b/src/coreclr/System.Private.CoreLib/CreateRuntimeRootILLinkDescriptorFile.targets @@ -14,9 +14,10 @@ - <_ILLinkDescriptorsFilePaths Include="$(ILLinkDirectory)ILLink.Descriptors.Common.xml" /> + <_ILLinkDescriptorsFilePaths Include="$(ILLinkDirectory)ILLink.Descriptors.Shared.xml" /> <_ILLinkDescriptorsFilePaths Condition="'$(TargetsWindows)' == 'true'" Include="$(ILLinkDirectory)ILLink.Descriptors.Windows.xml" /> <_ILLinkDescriptorsFilePaths Include="$(CoreLibSharedDir)ILLink\ILLink.Descriptors.Shared.xml" /> + <_ILLinkDescriptorsFilePaths Include="$(CoreLibSharedDir)ILLink\ILLink.Descriptors.NonBrowser.xml" />