From d5294692f108adeef2a91db49794d8a9bf2bd50c Mon Sep 17 00:00:00 2001 From: wfurt Date: Tue, 27 Jul 2021 11:24:04 -0700 Subject: [PATCH] disable test parallelization for http3 --- .../FunctionalTests/SocketsHttpHandlerTest.cs | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs b/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs index a95168ec63eace..845721855baf07 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs @@ -3143,6 +3143,7 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2(ITestOutputH } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandlerTest_Http3_MsQuic : HttpClientHandlerTest_Http3 { public SocketsHttpHandlerTest_Http3_MsQuic(ITestOutputHelper output) : base(output) { } @@ -3150,6 +3151,7 @@ public SocketsHttpHandlerTest_Http3_MsQuic(ITestOutputHelper output) : base(outp } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandlerTest_Http3_Mock : HttpClientHandlerTest_Http3 { public SocketsHttpHandlerTest_Http3_Mock(ITestOutputHelper output) : base(output) { } @@ -3157,6 +3159,7 @@ public SocketsHttpHandlerTest_Http3_Mock(ITestOutputHelper output) : base(output } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_MsQuic : HttpClientHandlerTest { public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_MsQuic(ITestOutputHelper output) : base(output) { } @@ -3165,6 +3168,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_MsQuic(ITestOutputHelp } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_Mock : HttpClientHandlerTest { public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_Mock(ITestOutputHelper output) : base(output) { } @@ -3174,6 +3178,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Http3_Mock(ITestOutputHelper [ActiveIssue("https://github.com/dotnet/runtime/issues/53093")] [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandlerTest_Cookies_Http3_MsQuic : HttpClientHandlerTest_Cookies { public SocketsHttpHandlerTest_Cookies_Http3_MsQuic(ITestOutputHelper output) : base(output) { } @@ -3183,6 +3188,7 @@ public SocketsHttpHandlerTest_Cookies_Http3_MsQuic(ITestOutputHelper output) : b [ActiveIssue("https://github.com/dotnet/runtime/issues/53093")] [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandlerTest_Cookies_Http3_Mock : HttpClientHandlerTest_Cookies { public SocketsHttpHandlerTest_Cookies_Http3_Mock(ITestOutputHelper output) : base(output) { } @@ -3191,6 +3197,7 @@ public SocketsHttpHandlerTest_Cookies_Http3_Mock(ITestOutputHelper output) : bas } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic : HttpClientHandlerTest_Headers { public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic(ITestOutputHelper output) : base(output) { } @@ -3199,6 +3206,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_MsQuic(ITestOu } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_Mock : HttpClientHandlerTest_Headers { public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_Mock(ITestOutputHelper output) : base(output) { } @@ -3207,6 +3215,7 @@ public SocketsHttpHandlerTest_HttpClientHandlerTest_Headers_Http3_Mock(ITestOutp } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_MsQuic : SocketsHttpHandler_Cancellation_Test { public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_MsQuic(ITestOutputHelper output) : base(output) { } @@ -3215,6 +3224,7 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_MsQuic(ITest } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_Mock : SocketsHttpHandler_Cancellation_Test { public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_Mock(ITestOutputHelper output) : base(output) { } @@ -3223,6 +3233,7 @@ public SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http3_Mock(ITestOu } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_MsQuic : HttpClientHandler_AltSvc_Test { public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_MsQuic(ITestOutputHelper output) : base(output) { } @@ -3231,6 +3242,7 @@ public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_MsQuic(ITestOutput } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_Mock : HttpClientHandler_AltSvc_Test { public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_Mock(ITestOutputHelper output) : base(output) { } @@ -3239,6 +3251,7 @@ public SocketsHttpHandler_HttpClientHandler_AltSvc_Test_Http3_Mock(ITestOutputHe } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic : HttpClientHandler_Finalization_Test { public SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic(ITestOutputHelper output) : base(output) { } @@ -3247,6 +3260,7 @@ public SocketsHttpHandler_HttpClientHandler_Finalization_Http3_MsQuic(ITestOutpu } [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMockQuicSupported))] + [Collection("NoParallelTests")] public sealed class SocketsHttpHandler_HttpClientHandler_Finalization_Http3_Mock : HttpClientHandler_Finalization_Test { public SocketsHttpHandler_HttpClientHandler_Finalization_Http3_Mock(ITestOutputHelper output) : base(output) { } @@ -3254,6 +3268,10 @@ public SocketsHttpHandler_HttpClientHandler_Finalization_Http3_Mock(ITestOutputH protected override QuicImplementationProvider UseQuicImplementationProvider => QuicImplementationProviders.Mock; } + // Define test collection for tests to avoid all other tests. + [CollectionDefinition("NoParallelTests", DisableParallelization = true)] + public partial class NoParallelTests { } + [ConditionalClass(typeof(PlatformDetection), nameof(PlatformDetection.IsNotBrowser))] public abstract class SocketsHttpHandler_RequestValidationTest {