From 1ebc905283e8b09b9e20a90da806946ba0bae60b Mon Sep 17 00:00:00 2001 From: David Mason Date: Thu, 21 Oct 2021 12:59:07 -0700 Subject: [PATCH 1/3] fix warnings --- src/tests/profiler/native/eltprofiler/slowpatheltprofiler.cpp | 4 ++-- src/tests/profiler/native/inlining/inlining.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/tests/profiler/native/eltprofiler/slowpatheltprofiler.cpp b/src/tests/profiler/native/eltprofiler/slowpatheltprofiler.cpp index 032dd3a82fa9ca..b62ab2ac669a6a 100644 --- a/src/tests/profiler/native/eltprofiler/slowpatheltprofiler.cpp +++ b/src/tests/profiler/native/eltprofiler/slowpatheltprofiler.cpp @@ -19,12 +19,12 @@ using std::atomic; shared_ptr SlowPathELTProfiler::s_profiler; +#define PROFILER_STUB static void STDMETHODCALLTYPE + #ifndef WIN32 #define UINT_PTR_FORMAT "lx" -#define PROFILER_STUB __attribute__((visibility("hidden"))) static void STDMETHODCALLTYPE #else // WIN32 #define UINT_PTR_FORMAT "llx" -#define PROFILER_STUB static void STDMETHODCALLTYPE #endif // WIN32 PROFILER_STUB EnterStub(FunctionIDOrClientID functionId, COR_PRF_ELT_INFO eltInfo) diff --git a/src/tests/profiler/native/inlining/inlining.cpp b/src/tests/profiler/native/inlining/inlining.cpp index 0cd436833efd05..f6a1a7b54ba02e 100644 --- a/src/tests/profiler/native/inlining/inlining.cpp +++ b/src/tests/profiler/native/inlining/inlining.cpp @@ -13,12 +13,12 @@ using std::atomic; shared_ptr InliningProfiler::s_profiler; +#define PROFILER_STUB static void STDMETHODCALLTYPE + #ifndef WIN32 #define UINT_PTR_FORMAT "lx" -#define PROFILER_STUB __attribute__((visibility("hidden"))) static void STDMETHODCALLTYPE #else // WIN32 #define UINT_PTR_FORMAT "llx" -#define PROFILER_STUB static void STDMETHODCALLTYPE #endif // WIN32 PROFILER_STUB EnterStub(FunctionIDOrClientID functionId, COR_PRF_ELT_INFO eltInfo) From 98824e4f8b861125a44b64aaff8e978f2c0dacd4 Mon Sep 17 00:00:00 2001 From: Adeel Mujahid <3840695+am11@users.noreply.github.com> Date: Thu, 21 Oct 2021 20:34:26 +0000 Subject: [PATCH 2/3] Trigger GCC leg when src/tests is modified --- eng/pipelines/runtime.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/eng/pipelines/runtime.yml b/eng/pipelines/runtime.yml index 07b4cbc2122d66..86e91c22087fbf 100644 --- a/eng/pipelines/runtime.yml +++ b/eng/pipelines/runtime.yml @@ -109,6 +109,7 @@ jobs: condition: >- or( eq(dependencies.evaluate_paths.outputs['SetPathVars_coreclr.containsChange'], true), + eq(dependencies.evaluate_paths.outputs['SetPathVars_runtimetests.containsChange'], true), eq(variables['isFullMatrix'], true)) # From 1ceb34dfb23465db2b61fca24f204df2561c7398 Mon Sep 17 00:00:00 2001 From: Adeel <3840695+am11@users.noreply.github.com> Date: Thu, 21 Oct 2021 23:55:01 +0300 Subject: [PATCH 3/3] Add src/native in default paths --- eng/pipelines/common/evaluate-default-paths.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/eng/pipelines/common/evaluate-default-paths.yml b/eng/pipelines/common/evaluate-default-paths.yml index 8cbcbdd3f96f20..9a29f4d10ae981 100644 --- a/eng/pipelines/common/evaluate-default-paths.yml +++ b/eng/pipelines/common/evaluate-default-paths.yml @@ -11,6 +11,7 @@ jobs: - src/libraries/System.Private.CoreLib/* - src/libraries/Native/Unix/System.Globalization.Native/* - src/libraries/Native/Unix/Common/* + - src/native/* exclude: - eng/Version.Details.xml - '*.md' @@ -31,6 +32,7 @@ jobs: - src/libraries/Native/Unix/System.Globalization.Native/* - src/libraries/Native/Unix/Common/* - src/tests/BuildWasmApps/* + - src/native/* exclude: - eng/Version.Details.xml - '*.md'