From c0306fe69588d7332378a7635a0a0c509084d48b Mon Sep 17 00:00:00 2001 From: Andrii Kurdiumov Date: Sat, 20 Nov 2021 21:23:43 +0600 Subject: [PATCH 1/3] Baseline System.Speech for trimming erorrs This PR is just ask to start producing list of ILLink warnings for System.Speech. I would like to eventually make ComWrappers for this library, but for now, I think there other low-hanging fruit which can be reached here. --- src/libraries/System.Speech/src/System.Speech.csproj | 1 - src/libraries/illink-oob.targets | 1 - 2 files changed, 2 deletions(-) diff --git a/src/libraries/System.Speech/src/System.Speech.csproj b/src/libraries/System.Speech/src/System.Speech.csproj index 783e89d8b0e4bd..65fdc149b9fe22 100644 --- a/src/libraries/System.Speech/src/System.Speech.csproj +++ b/src/libraries/System.Speech/src/System.Speech.csproj @@ -6,7 +6,6 @@ $(NoWarn);CS0649;SA1129;CA1847 annotations - false true true true diff --git a/src/libraries/illink-oob.targets b/src/libraries/illink-oob.targets index 72cecaf3b8beec..963dee93502f46 100644 --- a/src/libraries/illink-oob.targets +++ b/src/libraries/illink-oob.targets @@ -22,7 +22,6 @@ <_OOBsToIgnore Include="System.Composition.Runtime" /> <_OOBsToIgnore Include="System.Composition.TypedParts" /> <_OOBsToIgnore Include="System.Configuration.ConfigurationManager" /> - <_OOBsToIgnore Include="System.Speech" /> <_NetCoreAppRuntimeAssemblies Include="$(NetCoreAppCurrentRuntimePath)*.dll" Exclude="$(NetCoreAppCurrentRuntimePath)*.Generator.dll;$(NetCoreAppCurrentRuntimePath)*.Native.dll;$(NetCoreAppCurrentRuntimePath)*msquic.dll" /> <_RuntimePackTrimmedAssemblies Include="$(MicrosoftNetCoreAppRuntimePackRidLibTfmDir)*.dll" /> From f6c0d9ef8b8483b0091150259a899668443ea73a Mon Sep 17 00:00:00 2001 From: Andrii Kurdiumov Date: Sun, 21 Nov 2021 16:04:21 +0600 Subject: [PATCH 2/3] Add basic supression file for System.Speech --- .../System.Speech/src/ILLink/ILLink.Suppressions.xml | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 src/libraries/System.Speech/src/ILLink/ILLink.Suppressions.xml diff --git a/src/libraries/System.Speech/src/ILLink/ILLink.Suppressions.xml b/src/libraries/System.Speech/src/ILLink/ILLink.Suppressions.xml new file mode 100644 index 00000000000000..c303ec7e935317 --- /dev/null +++ b/src/libraries/System.Speech/src/ILLink/ILLink.Suppressions.xml @@ -0,0 +1,11 @@ + + + + + ILLink + IL2026 + member + M:System.Speech.Internal.SrgsCompiler.AppDomainGrammarProxy.GetTypeForRule(Assembly,String) + + + From fe93e61b7962bc3ac2cbca5cef2399ef7623cce1 Mon Sep 17 00:00:00 2001 From: Andrii Kurdiumov Date: Sun, 21 Nov 2021 20:16:54 +0600 Subject: [PATCH 3/3] Attempt to fix signature --- src/libraries/System.Speech/src/ILLink/ILLink.Suppressions.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Speech/src/ILLink/ILLink.Suppressions.xml b/src/libraries/System.Speech/src/ILLink/ILLink.Suppressions.xml index c303ec7e935317..bc147488fe9137 100644 --- a/src/libraries/System.Speech/src/ILLink/ILLink.Suppressions.xml +++ b/src/libraries/System.Speech/src/ILLink/ILLink.Suppressions.xml @@ -5,7 +5,7 @@ ILLink IL2026 member - M:System.Speech.Internal.SrgsCompiler.AppDomainGrammarProxy.GetTypeForRule(Assembly,String) + M:System.Speech.Internal.SrgsCompiler.AppDomainGrammarProxy.GetTypeForRule(System.Reflection.Assembly,System.String)