From f2ed95bc43904323cd9cf7ad85ca4ed5b420ca65 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 14 Dec 2021 11:15:03 +0300 Subject: [PATCH 01/22] Disable some suspicious test classes which might lead to OOM crashes on Android emulators and arm64 devices --- .../AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs | 1 + .../AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs | 1 + .../AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs | 1 + 3 files changed, 3 insertions(+) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs index af64f2fc031eb1..088271d0cb706c 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs @@ -7,6 +7,7 @@ namespace System.Security.Cryptography.EcDiffieHellman.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] + [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] public class ECDhKeyFileTests : ECKeyFileTests { protected override ECDiffieHellman CreateKey() => ECDiffieHellmanFactory.Create(); diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs index 35bed6e7247855..2f8b1e0fbb12e7 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs @@ -7,6 +7,7 @@ namespace System.Security.Cryptography.EcDsa.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] + [ActiveIssue("TODO - create GH issue, x64", TestPlatforms.Android)] public class ECDsaKeyFileTests : ECKeyFileTests { protected override ECDsa CreateKey() => ECDsaFactory.Create(); diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs index e2040d47888d3d..81ca61332d763e 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs @@ -7,6 +7,7 @@ namespace System.Security.Cryptography.EcDsa.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] + [ActiveIssue("TODO - create GH issue, arm64", TestPlatforms.Android)] public sealed class ECDsaTests_Span : ECDsaTests { protected override bool VerifyData(ECDsa ecdsa, byte[] data, int offset, int count, byte[] signature, HashAlgorithmName hashAlgorithm) => From 36632c13e21f38486e379e2ef6eeb48db1731719 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 14 Dec 2021 13:16:29 +0300 Subject: [PATCH 02/22] Disable more tests --- .../Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs | 1 + .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 + 2 files changed, 2 insertions(+) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs index 5f3a0f5b82a6da..10a0ab59b24777 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs @@ -9,6 +9,7 @@ namespace System.Security.Cryptography.Dsa.Tests { [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "Not supported on Browser/iOS/tvOS/MacCatalyst")] + [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] public static class DSAKeyFileTests { public static bool SupportsFips186_3 => DSAFactory.SupportsFips186_3; diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index f3f9b1b85e8c04..5619b205569654 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -9,6 +9,7 @@ namespace System.Security.Cryptography.Rsa.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] + [ActiveIssue("TODO - create GH issue, x64", TestPlatforms.Android)] public static class RSAKeyFileTests { public static bool Supports384BitPrivateKeyAndRC2 { get; } = RSAFactory.Supports384PrivateKey && RC2Factory.IsSupported; From 4b1bd1b05578dfe4279fda14f4ce07306b2ef68d Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 14 Dec 2021 13:19:16 +0300 Subject: [PATCH 03/22] Run the crypto tests by the default --- src/libraries/tests.proj | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index cc334885232b74..0c856ca1f39dc6 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -360,6 +360,11 @@ + + + + + Date: Tue, 14 Dec 2021 15:52:23 +0300 Subject: [PATCH 04/22] Disable individual tests --- .../AlgorithmImplementations/DSA/DSAKeyFileTests.cs | 3 ++- .../Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs | 1 + .../ECDiffieHellman/ECDhKeyFileTests.cs | 2 +- .../AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs | 2 +- .../AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 3 ++- 5 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs index 10a0ab59b24777..2483e6b944fef7 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs @@ -9,7 +9,7 @@ namespace System.Security.Cryptography.Dsa.Tests { [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "Not supported on Browser/iOS/tvOS/MacCatalyst")] - [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] + // [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] public static class DSAKeyFileTests { public static bool SupportsFips186_3 => DSAFactory.SupportsFips186_3; @@ -566,6 +566,7 @@ public static void DecryptPkcs12WithBytes() } [Fact] + [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] public static void DecryptPkcs12PbeTooManyIterations() { // pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs index dcfe4e81af9694..4bd4c913eb5c61 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs @@ -959,6 +959,7 @@ public void DecryptPkcs12WithBytes() } [Fact] + [ActiveIssue("TODO - create GH issue", TestPlatforms.Android)] public void DecryptPkcs12PbeTooManyIterations() { // pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs index 088271d0cb706c..8751fed72a4d60 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs @@ -7,7 +7,7 @@ namespace System.Security.Cryptography.EcDiffieHellman.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] - [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] + // [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] public class ECDhKeyFileTests : ECKeyFileTests { protected override ECDiffieHellman CreateKey() => ECDiffieHellmanFactory.Create(); diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs index 2f8b1e0fbb12e7..bc2f248c376f6a 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs @@ -7,7 +7,7 @@ namespace System.Security.Cryptography.EcDsa.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] - [ActiveIssue("TODO - create GH issue, x64", TestPlatforms.Android)] + // [ActiveIssue("TODO - create GH issue, x64", TestPlatforms.Android)] public class ECDsaKeyFileTests : ECKeyFileTests { protected override ECDsa CreateKey() => ECDsaFactory.Create(); diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 5619b205569654..08e967f660d7a9 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -9,7 +9,7 @@ namespace System.Security.Cryptography.Rsa.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] - [ActiveIssue("TODO - create GH issue, x64", TestPlatforms.Android)] + //[ActiveIssue("TODO - create GH issue, x64", TestPlatforms.Android)] public static class RSAKeyFileTests { public static bool Supports384BitPrivateKeyAndRC2 { get; } = RSAFactory.Supports384PrivateKey && RC2Factory.IsSupported; @@ -1255,6 +1255,7 @@ public static void DecryptPkcs12WithBytes() } [Fact] + [ActiveIssue("TODO - create GH issue", TestPlatforms.Android)] public static void DecryptPkcs12PbeTooManyIterations() { // pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations From 84e391baf13377a8e5ed3e32b59d5bec6b0ccbd6 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 14 Dec 2021 16:54:44 +0300 Subject: [PATCH 05/22] Disable more tests --- .../Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs | 1 + .../Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs | 1 + .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 + 3 files changed, 3 insertions(+) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs index 2483e6b944fef7..f79182a5d6a717 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs @@ -587,6 +587,7 @@ public static void DecryptPkcs12PbeTooManyIterations() } [Fact] + [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] public static void ReadWriteDsa1024EncryptedPkcs8_Pbes2HighIterations() { // pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs index 4bd4c913eb5c61..9a84e562ba8c02 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs @@ -977,6 +977,7 @@ public void DecryptPkcs12PbeTooManyIterations() } [Fact] + [ActiveIssue("TODO - create GH issue", TestPlatforms.Android)] public void ReadWriteEc256EncryptedPkcs8_Pbes2HighIterations() { // pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 08e967f660d7a9..c652e3c892deb8 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -1292,6 +1292,7 @@ public static void DecryptPkcs12PbeTooManyIterations() } [Fact] + [ActiveIssue("TODO - create GH issue", TestPlatforms.Android)] public static void ReadWriteRsa2048EncryptedPkcs8_Pbes2HighIterations() { // pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations From 1a1afdc4db54097e77bd4e345fb866bc6314e03d Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Tue, 14 Dec 2021 18:19:06 +0300 Subject: [PATCH 06/22] Disable more tests --- .../AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index c652e3c892deb8..706b7b8a6e9e7e 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -75,6 +75,7 @@ public static void UseAfterDispose(bool importKey) } [ConditionalFact(nameof(SupportsLargeExponent))] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadWriteBigExponentPrivatePkcs1() { ReadWriteBase64PrivatePkcs1( @@ -108,6 +109,7 @@ public static void ReadWriteBigExponentPrivatePkcs1() } [Fact] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadWriteDiminishedDPPrivatePkcs1() { ReadWriteBase64PrivatePkcs1( @@ -174,6 +176,7 @@ public static void ReadWritePublicPkcs1() } [ConditionalFact(nameof(SupportsLargeExponent))] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadWriteSubjectPublicKeyInfo() { ReadWriteBase64SubjectPublicKeyInfo( @@ -189,6 +192,7 @@ public static void ReadWriteSubjectPublicKeyInfo() } [Fact] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadWriteSubjectPublicKeyInfo_DiminishedDPKey() { ReadWriteBase64SubjectPublicKeyInfo( @@ -199,6 +203,7 @@ public static void ReadWriteSubjectPublicKeyInfo_DiminishedDPKey() } [ConditionalFact(typeof(ImportExport), nameof(ImportExport.Supports16384))] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadWriteRsa16384SubjectPublicKeyInfo() { ReadWriteBase64SubjectPublicKeyInfo( @@ -469,6 +474,7 @@ public static void ReadWriteDiminishedDPPkcs8() } [Fact] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadEncryptedDiminishedDP() { // PBES1: PbeWithMD5AndDESCBC @@ -494,6 +500,7 @@ public static void ReadEncryptedDiminishedDP() } [Fact] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadEncryptedRsa1032() { // PBES2: PBKDF2 + aes192 @@ -790,6 +797,7 @@ public static void ReadPbes2Rc2EncryptedDiminishedDP_PasswordBytes() } [Fact] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadEncryptedDiminishedDP_EmptyPassword() { // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Suppression approved. Unit test key.")] @@ -863,6 +871,7 @@ public static void ReadPbes1Rc2EncryptedRsa384() } [Fact] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void NoFuzzyRSAPublicKey() { using (RSA key = RSAFactory.Create()) @@ -992,6 +1001,7 @@ public static void NoFuzzyRSAPrivateKey() } [Fact] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void NoFuzzyPkcs8() { using (RSA key = RSAFactory.Create()) @@ -1036,6 +1046,7 @@ public static void NoFuzzyPkcs8() } [Fact] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void NoFuzzyEncryptedPkcs8() { using (RSA key = RSAFactory.Create()) @@ -1073,6 +1084,7 @@ public static void NoFuzzyEncryptedPkcs8() } [Fact] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void NoPrivKeyFromPublicOnly() { using (RSA key = RSAFactory.Create()) @@ -1113,6 +1125,7 @@ public static void NoPrivKeyFromPublicOnly() } [Fact] + [ActiveIssue("TEMP", TestPlatforms.Android)] public static void BadPbeParameters() { using (RSA key = RSAFactory.Create()) From be86e39e0131197bdba634f186c4a0ae3446e536 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 15 Dec 2021 13:42:48 +0300 Subject: [PATCH 07/22] Clean up --- .../Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs | 1 - .../AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs | 1 - .../AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs | 1 - .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 4 files changed, 4 deletions(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs index f79182a5d6a717..739eaabb1a1aa1 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs @@ -9,7 +9,6 @@ namespace System.Security.Cryptography.Dsa.Tests { [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "Not supported on Browser/iOS/tvOS/MacCatalyst")] - // [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] public static class DSAKeyFileTests { public static bool SupportsFips186_3 => DSAFactory.SupportsFips186_3; diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs index 8751fed72a4d60..af64f2fc031eb1 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDiffieHellman/ECDhKeyFileTests.cs @@ -7,7 +7,6 @@ namespace System.Security.Cryptography.EcDiffieHellman.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] - // [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] public class ECDhKeyFileTests : ECKeyFileTests { protected override ECDiffieHellman CreateKey() => ECDiffieHellmanFactory.Create(); diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs index bc2f248c376f6a..35bed6e7247855 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaKeyFileTests.cs @@ -7,7 +7,6 @@ namespace System.Security.Cryptography.EcDsa.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] - // [ActiveIssue("TODO - create GH issue, x64", TestPlatforms.Android)] public class ECDsaKeyFileTests : ECKeyFileTests { protected override ECDsa CreateKey() => ECDsaFactory.Create(); diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 706b7b8a6e9e7e..377549d5f0f626 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -9,7 +9,6 @@ namespace System.Security.Cryptography.Rsa.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] - //[ActiveIssue("TODO - create GH issue, x64", TestPlatforms.Android)] public static class RSAKeyFileTests { public static bool Supports384BitPrivateKeyAndRC2 { get; } = RSAFactory.Supports384PrivateKey && RC2Factory.IsSupported; From fb10abcdcd9e37515f8f4e31f24aa173d8dfdd4a Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 15 Dec 2021 13:44:42 +0300 Subject: [PATCH 08/22] Enable RSAKeyFileTests.BadPbeParameters() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 377549d5f0f626..c90b775f278879 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -1124,7 +1124,6 @@ public static void NoPrivKeyFromPublicOnly() } [Fact] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void BadPbeParameters() { using (RSA key = RSAFactory.Create()) From f0d6208c1ac0586d044679e2818fab5fcf784478 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 15 Dec 2021 14:33:57 +0300 Subject: [PATCH 09/22] Enable RSAKeyFileTests.NoPrivKeyFromPublicOnly() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index c90b775f278879..21edb2b9cf0971 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -1083,7 +1083,6 @@ public static void NoFuzzyEncryptedPkcs8() } [Fact] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void NoPrivKeyFromPublicOnly() { using (RSA key = RSAFactory.Create()) From 5b841f481c67c7a22f7d11fac90e13dcaf10df69 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 15 Dec 2021 15:18:37 +0300 Subject: [PATCH 10/22] Enable RSAKeyFileTests.NoFuzzyEncryptedPkcs8() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 21edb2b9cf0971..059f77e6770d83 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -1045,7 +1045,6 @@ public static void NoFuzzyPkcs8() } [Fact] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void NoFuzzyEncryptedPkcs8() { using (RSA key = RSAFactory.Create()) From 1be17b5619f3fddbb519a0eace75997c21d552d6 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 15 Dec 2021 15:58:48 +0300 Subject: [PATCH 11/22] Enable RSAKeyFileTests.NoFuzzyPkcs8() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 059f77e6770d83..a4636a1bda4149 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -1000,7 +1000,6 @@ public static void NoFuzzyRSAPrivateKey() } [Fact] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void NoFuzzyPkcs8() { using (RSA key = RSAFactory.Create()) From f1695f930f9bdf3ec43955c26fa1547ecad02882 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 15 Dec 2021 17:03:59 +0300 Subject: [PATCH 12/22] Enable RSAKeyFileTests.ReadWriteBigExponentPrivatePkcs1() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index a4636a1bda4149..576d78cc436f44 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -74,7 +74,6 @@ public static void UseAfterDispose(bool importKey) } [ConditionalFact(nameof(SupportsLargeExponent))] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadWriteBigExponentPrivatePkcs1() { ReadWriteBase64PrivatePkcs1( From 2755d0b06b335d070ff1bc6d6f74dd76b8547936 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 15 Dec 2021 17:45:41 +0300 Subject: [PATCH 13/22] Enable RSAKeyFileTests.ReadWriteDiminishedDPPrivatePkcs1() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 576d78cc436f44..41f607a45ec0b0 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -107,7 +107,6 @@ public static void ReadWriteBigExponentPrivatePkcs1() } [Fact] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadWriteDiminishedDPPrivatePkcs1() { ReadWriteBase64PrivatePkcs1( From bf2f1c2d3d6319585bdb94863f99784bd1cb6139 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 15 Dec 2021 19:02:16 +0300 Subject: [PATCH 14/22] Disable ReadWriteDiminishedDPPrivatePkcs1() due to crash; enable ReadWriteSubjectPublicKeyInfo() --- .../AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 41f607a45ec0b0..504aa00b8dd5fe 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -107,6 +107,7 @@ public static void ReadWriteBigExponentPrivatePkcs1() } [Fact] + [ActiveIssue("TODO - create GH issue", TestPlatforms.Android)] public static void ReadWriteDiminishedDPPrivatePkcs1() { ReadWriteBase64PrivatePkcs1( @@ -173,7 +174,6 @@ public static void ReadWritePublicPkcs1() } [ConditionalFact(nameof(SupportsLargeExponent))] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadWriteSubjectPublicKeyInfo() { ReadWriteBase64SubjectPublicKeyInfo( From efa449056f420e4cb43b451ed13b6f4ee74772ed Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 15 Dec 2021 20:37:18 +0300 Subject: [PATCH 15/22] Enable RSAKeyFileTests.ReadWriteSubjectPublicKeyInfo_DiminishedDPKey() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 504aa00b8dd5fe..2b88ecd686180a 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -189,7 +189,6 @@ public static void ReadWriteSubjectPublicKeyInfo() } [Fact] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadWriteSubjectPublicKeyInfo_DiminishedDPKey() { ReadWriteBase64SubjectPublicKeyInfo( From a9c539a768dd5ad3c8f45d9e2a25f58079f8efe2 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Wed, 15 Dec 2021 21:33:14 +0300 Subject: [PATCH 16/22] Enable RSAKeyFileTests.ReadWriteRsa16384SubjectPublicKeyInfo() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 2b88ecd686180a..812c333386a434 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -199,7 +199,6 @@ public static void ReadWriteSubjectPublicKeyInfo_DiminishedDPKey() } [ConditionalFact(typeof(ImportExport), nameof(ImportExport.Supports16384))] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadWriteRsa16384SubjectPublicKeyInfo() { ReadWriteBase64SubjectPublicKeyInfo( From d15576c1d859c93f571b02f516d796631d0d30a6 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 16 Dec 2021 09:57:00 +0300 Subject: [PATCH 17/22] Enable RSAKeyFileTests.ReadEncryptedDiminishedDP --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 812c333386a434..12d665a51a4c45 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -469,7 +469,6 @@ public static void ReadWriteDiminishedDPPkcs8() } [Fact] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadEncryptedDiminishedDP() { // PBES1: PbeWithMD5AndDESCBC From 32fd34b41f21f063d6387a5d351db54593d43dc1 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 16 Dec 2021 11:00:53 +0300 Subject: [PATCH 18/22] Enable RSAKeyFileTests.ReadEncryptedRsa1032() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 12d665a51a4c45..4b8da853efa914 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -494,7 +494,6 @@ public static void ReadEncryptedDiminishedDP() } [Fact] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadEncryptedRsa1032() { // PBES2: PBKDF2 + aes192 From 407bb81706657280adc1bda1e94a608f912f7699 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 16 Dec 2021 11:53:23 +0300 Subject: [PATCH 19/22] Enable RSAKeyFileTests.NoFuzzyRSAPublicKey() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 4b8da853efa914..d43060dee9b1ed 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -864,7 +864,6 @@ public static void ReadPbes1Rc2EncryptedRsa384() } [Fact] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void NoFuzzyRSAPublicKey() { using (RSA key = RSAFactory.Create()) From 320a3246f45bee368f6b3ffa05bc8aeb649e4168 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 16 Dec 2021 14:04:00 +0300 Subject: [PATCH 20/22] Enable RSAKeyFileTests.ReadEncryptedDiminishedDP_EmptyPassword() --- .../Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index d43060dee9b1ed..99ac55fac97377 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -790,7 +790,6 @@ public static void ReadPbes2Rc2EncryptedDiminishedDP_PasswordBytes() } [Fact] - [ActiveIssue("TEMP", TestPlatforms.Android)] public static void ReadEncryptedDiminishedDP_EmptyPassword() { // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Suppression approved. Unit test key.")] From e621b6352ff47a2ca9d1e6a353c6af8d44ec15ea Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Thu, 16 Dec 2021 16:13:23 +0300 Subject: [PATCH 21/22] Add GH issue --- .../AlgorithmImplementations/DSA/DSAKeyFileTests.cs | 4 ++-- .../AlgorithmImplementations/EC/ECKeyFileTests.cs | 4 ++-- .../ECDsa/ECDsaTests.netcoreapp.cs | 2 +- .../AlgorithmImplementations/RSA/RSAKeyFileTests.cs | 7 ++++--- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs index 739eaabb1a1aa1..6564a97b17fd27 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAKeyFileTests.cs @@ -565,7 +565,7 @@ public static void DecryptPkcs12WithBytes() } [Fact] - [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)] public static void DecryptPkcs12PbeTooManyIterations() { // pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations @@ -586,7 +586,7 @@ public static void DecryptPkcs12PbeTooManyIterations() } [Fact] - [ActiveIssue("TODO - create GH issue, x86", TestPlatforms.Android)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)] public static void ReadWriteDsa1024EncryptedPkcs8_Pbes2HighIterations() { // pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs index 9a84e562ba8c02..689e1391cb3eed 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/EC/ECKeyFileTests.cs @@ -959,7 +959,7 @@ public void DecryptPkcs12WithBytes() } [Fact] - [ActiveIssue("TODO - create GH issue", TestPlatforms.Android)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)] public void DecryptPkcs12PbeTooManyIterations() { // pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations @@ -977,7 +977,7 @@ public void DecryptPkcs12PbeTooManyIterations() } [Fact] - [ActiveIssue("TODO - create GH issue", TestPlatforms.Android)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)] public void ReadWriteEc256EncryptedPkcs8_Pbes2HighIterations() { // pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs index 81ca61332d763e..eb12b87acba738 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/ECDsa/ECDsaTests.netcoreapp.cs @@ -7,7 +7,7 @@ namespace System.Security.Cryptography.EcDsa.Tests { [SkipOnPlatform(TestPlatforms.Browser, "Not supported on Browser")] - [ActiveIssue("TODO - create GH issue, arm64", TestPlatforms.Android)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)] public sealed class ECDsaTests_Span : ECDsaTests { protected override bool VerifyData(ECDsa ecdsa, byte[] data, int offset, int count, byte[] signature, HashAlgorithmName hashAlgorithm) => diff --git a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs index 99ac55fac97377..d79be4e69f2f0a 100644 --- a/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs +++ b/src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/RSA/RSAKeyFileTests.cs @@ -107,7 +107,7 @@ public static void ReadWriteBigExponentPrivatePkcs1() } [Fact] - [ActiveIssue("TODO - create GH issue", TestPlatforms.Android)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)] public static void ReadWriteDiminishedDPPrivatePkcs1() { ReadWriteBase64PrivatePkcs1( @@ -790,6 +790,7 @@ public static void ReadPbes2Rc2EncryptedDiminishedDP_PasswordBytes() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)] public static void ReadEncryptedDiminishedDP_EmptyPassword() { // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Suppression approved. Unit test key.")] @@ -1255,7 +1256,7 @@ public static void DecryptPkcs12WithBytes() } [Fact] - [ActiveIssue("TODO - create GH issue", TestPlatforms.Android)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)] public static void DecryptPkcs12PbeTooManyIterations() { // pbeWithSHAAnd3-KeyTripleDES-CBC with 600,001 iterations @@ -1292,7 +1293,7 @@ public static void DecryptPkcs12PbeTooManyIterations() } [Fact] - [ActiveIssue("TODO - create GH issue", TestPlatforms.Android)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/62547", TestPlatforms.Android)] public static void ReadWriteRsa2048EncryptedPkcs8_Pbes2HighIterations() { // pkcs5PBES2 hmacWithSHA256 aes128-CBC with 600,001 iterations From 7215b0bb09d766bf3ebd70186e748e4324930249 Mon Sep 17 00:00:00 2001 From: Maxim Lipnin Date: Fri, 17 Dec 2021 12:42:02 +0300 Subject: [PATCH 22/22] Remove temp smoke test section --- src/libraries/tests.proj | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index c0bb30f1031508..aaf45da17b0032 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -360,11 +360,6 @@ - - - - -