From 51cc11d48e68ce55b96fa72042d3304988edb276 Mon Sep 17 00:00:00 2001 From: Kunal Pathak Date: Wed, 20 Apr 2022 08:14:20 -0700 Subject: [PATCH 1/2] fix the srcBufferLength check --- src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp b/src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp index bb2ead51272c62..c777dc21bd1034 100644 --- a/src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp +++ b/src/coreclr/tools/superpmi/superpmi-shared/methodcontext.cpp @@ -4820,7 +4820,7 @@ int MethodContext::repGetStringLiteral(CORINFO_MODULE_HANDLE module, unsigned me DD value = GetStringLiteral->Get(key); DEBUG_REP(dmpGetStringLiteral(key, value)); int srcBufferLength = (int)value.A; - if (buffer != nullptr && srcBufferLength != -1) + if (buffer != nullptr && srcBufferLength > 0) { char16_t* srcBuffer = (char16_t*)GetStringLiteral->GetBuffer(value.B); Assert(srcBuffer != nullptr); From e30dbdea96fcf5e6328ecb57cf125aca31c0e5ef Mon Sep 17 00:00:00 2001 From: Kunal Pathak Date: Wed, 20 Apr 2022 10:01:38 -0700 Subject: [PATCH 2/2] trigger superpmi replay job when changes to superpmi tool --- eng/pipelines/coreclr/superpmi-replay.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/eng/pipelines/coreclr/superpmi-replay.yml b/eng/pipelines/coreclr/superpmi-replay.yml index b1f178d73f315b..1fc2bc7d0c1e12 100644 --- a/eng/pipelines/coreclr/superpmi-replay.yml +++ b/eng/pipelines/coreclr/superpmi-replay.yml @@ -11,6 +11,7 @@ pr: paths: include: - src/coreclr/jit/* + - src/coreclr/tools/superpmi/* exclude: - src/coreclr/inc/jiteeversionguid.h