From a29cd1ba5324e2266702af162864e8265d748f0e Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Wed, 1 Jun 2022 10:45:09 -0400 Subject: [PATCH 1/4] Update Roslyn to pick up recent features --- eng/Versions.props | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/Versions.props b/eng/Versions.props index 1eea1923b3117f..f9efc38c468ab3 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -47,9 +47,9 @@ 7.0.0-preview1.22252.2 4.3.0-1.22206.2 - 4.3.0-2.22270.4 + 4.3.0-3.22281.14 2.0.0-preview.4.22252.4 From 8ef622e029f15e4998726a4c05bbf351f5d21ecd Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Tue, 31 May 2022 09:40:58 -0400 Subject: [PATCH 2/4] Replace a straggling !! --- .../wasm/debugger/BrowserDebugProxy/JObjectValueCreator.cs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mono/wasm/debugger/BrowserDebugProxy/JObjectValueCreator.cs b/src/mono/wasm/debugger/BrowserDebugProxy/JObjectValueCreator.cs index 5346b982238be9..523204d6ea858a 100644 --- a/src/mono/wasm/debugger/BrowserDebugProxy/JObjectValueCreator.cs +++ b/src/mono/wasm/debugger/BrowserDebugProxy/JObjectValueCreator.cs @@ -75,12 +75,15 @@ long or ulong _ => null }; - public static JObject CreateNull(string className!!) - => Create(value: null, + public static JObject CreateNull(string className) + { + ArgumentNullException.ThrowIfNull(className); + return Create(value: null, type: "object", description: className, className: className, subtype: "null"); + } public async Task ReadAsVariableValue( MonoBinaryReader retDebuggerCmdReader, From ecfe27c97dd23f4b0f071b2b5eb93d5098e7f3fe Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Wed, 1 Jun 2022 11:30:51 -0400 Subject: [PATCH 3/4] Fix now erroneous use of u8 --- .../tests/UnitTests/NTAuthenticationTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Net.Security/tests/UnitTests/NTAuthenticationTests.cs b/src/libraries/System.Net.Security/tests/UnitTests/NTAuthenticationTests.cs index 5a9009db3f3c0f..6380764deb6d93 100644 --- a/src/libraries/System.Net.Security/tests/UnitTests/NTAuthenticationTests.cs +++ b/src/libraries/System.Net.Security/tests/UnitTests/NTAuthenticationTests.cs @@ -18,7 +18,7 @@ public class NTAuthenticationTests private static NetworkCredential s_testCredentialRight = new NetworkCredential("rightusername", "rightpassword"); private static NetworkCredential s_testCredentialWrong = new NetworkCredential("rightusername", "wrongpassword"); - private static byte[] s_Hello => "Hello"u8; + private static readonly byte[] s_Hello = "Hello"u8.ToArray(); [Fact] public void NtlmProtocolExampleTest() From d37553d00ad7b72528f779ed176d7ce98e99122e Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Wed, 1 Jun 2022 17:11:48 -0400 Subject: [PATCH 4/4] Disable several generic math tests --- .../System/Runtime/InteropServices/NFloatTests.GenericMath.cs | 3 +++ .../System.Runtime.Numerics/tests/ComplexTests.GenericMath.cs | 3 +++ .../System.Runtime/tests/System/DoubleTests.GenericMath.cs | 3 +++ .../System.Runtime/tests/System/SingleTests.GenericMath.cs | 3 +++ 4 files changed, 12 insertions(+) diff --git a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/NFloatTests.GenericMath.cs b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/NFloatTests.GenericMath.cs index 00e3c9601aed76..63c445df80887f 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/NFloatTests.GenericMath.cs +++ b/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/NFloatTests.GenericMath.cs @@ -1855,6 +1855,7 @@ public static void CreateCheckedFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateCheckedFromUIntPtrTest() { if (Environment.Is64BitProcess) @@ -2221,6 +2222,7 @@ public static void CreateSaturatingFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateSaturatingFromUIntPtrTest() { if (Environment.Is64BitProcess) @@ -2587,6 +2589,7 @@ public static void CreateTruncatingFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateTruncatingFromUIntPtrTest() { if (Environment.Is64BitProcess) diff --git a/src/libraries/System.Runtime.Numerics/tests/ComplexTests.GenericMath.cs b/src/libraries/System.Runtime.Numerics/tests/ComplexTests.GenericMath.cs index 06ceb1fc7a54b2..9b6c1c74a63d0c 100644 --- a/src/libraries/System.Runtime.Numerics/tests/ComplexTests.GenericMath.cs +++ b/src/libraries/System.Runtime.Numerics/tests/ComplexTests.GenericMath.cs @@ -511,6 +511,7 @@ public static void CreateCheckedFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateCheckedFromUIntPtrTest() { if (Environment.Is64BitProcess) @@ -756,6 +757,7 @@ public static void CreateSaturatingFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateSaturatingFromUIntPtrTest() { if (Environment.Is64BitProcess) @@ -1001,6 +1003,7 @@ public static void CreateTruncatingFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateTruncatingFromUIntPtrTest() { if (Environment.Is64BitProcess) diff --git a/src/libraries/System.Runtime/tests/System/DoubleTests.GenericMath.cs b/src/libraries/System.Runtime/tests/System/DoubleTests.GenericMath.cs index a1bae12e9275fd..e19a7e4f72adf7 100644 --- a/src/libraries/System.Runtime/tests/System/DoubleTests.GenericMath.cs +++ b/src/libraries/System.Runtime/tests/System/DoubleTests.GenericMath.cs @@ -1284,6 +1284,7 @@ public static void CreateCheckedFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateCheckedFromUIntPtrTest() { if (Environment.Is64BitProcess) @@ -1572,6 +1573,7 @@ public static void CreateSaturatingFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateSaturatingFromUIntPtrTest() { if (Environment.Is64BitProcess) @@ -1860,6 +1862,7 @@ public static void CreateTruncatingFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateTruncatingFromUIntPtrTest() { if (Environment.Is64BitProcess) diff --git a/src/libraries/System.Runtime/tests/System/SingleTests.GenericMath.cs b/src/libraries/System.Runtime/tests/System/SingleTests.GenericMath.cs index 709bd3d04926e3..2d3d0204cd6065 100644 --- a/src/libraries/System.Runtime/tests/System/SingleTests.GenericMath.cs +++ b/src/libraries/System.Runtime/tests/System/SingleTests.GenericMath.cs @@ -1286,6 +1286,7 @@ public static void CreateCheckedFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateCheckedFromUIntPtrTest() { if (Environment.Is64BitProcess) @@ -1576,6 +1577,7 @@ public static void CreateSaturatingFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateSaturatingFromUIntPtrTest() { if (Environment.Is64BitProcess) @@ -1866,6 +1868,7 @@ public static void CreateTruncatingFromUInt128Test() } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/69795", TestRuntimes.Mono)] public static void CreateTruncatingFromUIntPtrTest() { if (Environment.Is64BitProcess)