From 2a6a4c44462c7202e19129973a067141e86db2db Mon Sep 17 00:00:00 2001 From: Steve Pfister Date: Thu, 19 Jan 2023 16:18:05 -0500 Subject: [PATCH 1/2] [iOS][Android] ActiveIssue tests that are failing on CI https://github.com/dotnet/runtime/issues/80876 https://github.com/dotnet/runtime/issues/80875 https://github.com/dotnet/runtime/issues/80863 --- src/libraries/System.Memory/tests/Span/IndexOfAnyValues.cs | 1 + src/libraries/System.Numerics.Vectors/tests/Matrix4x4Tests.cs | 1 + .../tests/Metadata/MetadataReaderTests.cs | 1 + 3 files changed, 3 insertions(+) diff --git a/src/libraries/System.Memory/tests/Span/IndexOfAnyValues.cs b/src/libraries/System.Memory/tests/Span/IndexOfAnyValues.cs index 843619a4274155..4ca29be532888d 100644 --- a/src/libraries/System.Memory/tests/Span/IndexOfAnyValues.cs +++ b/src/libraries/System.Memory/tests/Span/IndexOfAnyValues.cs @@ -198,6 +198,7 @@ static void Test(ReadOnlySpan needle, IndexOfAnyValues values) where T [Theory] [MemberData(nameof(Values_MemberData))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/80875", TestPlatforms.iOS | TestPlatforms.tvOS)] public static void IndexOfAnyValues_GetValues(string needle, byte[] byteNeedle) { char[] charValuesActual = s_getValuesCharMethod(IndexOfAnyValues.Create(needle)); diff --git a/src/libraries/System.Numerics.Vectors/tests/Matrix4x4Tests.cs b/src/libraries/System.Numerics.Vectors/tests/Matrix4x4Tests.cs index 0aacc92730f1f4..be828eacfc9383 100644 --- a/src/libraries/System.Numerics.Vectors/tests/Matrix4x4Tests.cs +++ b/src/libraries/System.Numerics.Vectors/tests/Matrix4x4Tests.cs @@ -76,6 +76,7 @@ public void Matrix4x4IndexerGetTest(float m11, float m12, float m13, float m14, [InlineData(1.0f, 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 1.0f, 0.0f)] [InlineData(3.1434343f, 1.1234123f, 0.1234123f, -0.1234123f, 3.1434343f, 1.1234123f, 3.1434343f, 1.1234123f, 0.1234123f, -0.1234123f, 3.1434343f, 1.1234123f, 3.1434343f, 1.1234123f, 0.1234123f, -0.1234123f)] [InlineData(1.0000001f, 0.0000001f, 2.0000001f, 0.0000002f, 1.0000001f, 0.0000001f, 1.0000001f, 0.0000001f, 2.0000001f, 0.0000002f, 1.0000001f, 0.0000001f, 1.0000001f, 0.0000001f, 2.0000001f, 0.0000002f)] + [ActiveIssue("https://github.com/dotnet/runtime/issues/80876", TestPlatforms.iOS | TestPlatforms.tvOS)] public void Matrix4x4IndexerSetTest(float m11, float m12, float m13, float m14, float m21, float m22, float m23, float m24, float m31, float m32, float m33, float m34, float m41, float m42, float m43, float m44) { var matrix = new Matrix4x4(0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f); diff --git a/src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs b/src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs index a30606af963bf8..c91a1ea1a50c0b 100644 --- a/src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs +++ b/src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs @@ -3072,6 +3072,7 @@ private static unsafe byte[] ObfuscateWithExtraData(byte[] unobfuscated, bool se } [Fact] + [ActiveIssue("https://github.com/dotnet/runtime/issues/80863", TestPlatforms.Android | TestPlatforms.iOS | TestPlatforms.tvOS)] public void GetAssemblyName() { AssertExtensions.Throws("assemblyFile", () => MetadataReader.GetAssemblyName(null)); From e9b847d5f2b741af0fc701af59a65b9bcebe6abe Mon Sep 17 00:00:00 2001 From: Steve Pfister Date: Mon, 23 Jan 2023 22:37:34 -0500 Subject: [PATCH 2/2] Stop skipping GetAssemblyName test --- .../tests/Metadata/MetadataReaderTests.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs b/src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs index 71fd3d900f1f8f..3b946e5a807795 100644 --- a/src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs +++ b/src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs @@ -3072,7 +3072,6 @@ private static unsafe byte[] ObfuscateWithExtraData(byte[] unobfuscated, bool se } [Fact] - [ActiveIssue("https://github.com/dotnet/runtime/issues/80863", TestPlatforms.Android | TestPlatforms.iOS | TestPlatforms.tvOS)] public void GetAssemblyName() { AssertExtensions.Throws("assemblyFile", () => MetadataReader.GetAssemblyName(null));