From 81dbaa84c6f9039111395440d5f0801b8efd01b0 Mon Sep 17 00:00:00 2001 From: Ivan Diaz Date: Tue, 9 Jan 2024 14:39:00 -0800 Subject: [PATCH 1/9] Add "ActiveIssue" annotation placeholders to the failing tests, and reenable their respective executables, so that the other tests in said run can be executed. --- .../tests/SGenTests.cs | 1 + .../System.Console/tests/WindowAndCursorProps.cs | 1 + .../tests/FileSystemWatcher.File.Move.cs | 1 + .../tests/XmlSerializer/XmlSerializerTests.cs | 1 + .../System/AppDomainTests.cs | 1 + .../System.Threading.Thread/tests/ThreadTests.cs | 1 + src/libraries/tests.proj | 10 ---------- 7 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs b/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs index b9d896e6537fd5..263f2370a198ad 100644 --- a/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs +++ b/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs @@ -12,6 +12,7 @@ namespace Microsoft.XmlSerializer.Generator.Tests public static class SgenTests { [Fact] + [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void SgenCommandTest() { /* diff --git a/src/libraries/System.Console/tests/WindowAndCursorProps.cs b/src/libraries/System.Console/tests/WindowAndCursorProps.cs index 7ea07511594c46..64ce877c915b19 100644 --- a/src/libraries/System.Console/tests/WindowAndCursorProps.cs +++ b/src/libraries/System.Console/tests/WindowAndCursorProps.cs @@ -119,6 +119,7 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException() [Fact] [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix + [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void LargestWindowHeight_UnixGet_ReturnsExpected() { Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight)); diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs index a5515c48373314..fb840512d24eb2 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs @@ -185,6 +185,7 @@ private void FileMove_DifferentWatchedDirectory(WatcherChangeTypes eventType) } } + [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] private void FileMove_FromWatchedToUnwatched(WatcherChangeTypes eventType) { string dir_watched = CreateTestDirectory(TestDirectory, "dir_watched"); diff --git a/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs b/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs index 51a961a0befc21..14c263c60da93e 100644 --- a/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs +++ b/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs @@ -2101,6 +2101,7 @@ public static void Xml_TypeWithSpecialCharacterInStringMember() [SkipOnPlatform(TestPlatforms.Browser, "AssemblyDependencyResolver not supported in wasm")] #endif [ActiveIssue("34072", TestRuntimes.Mono)] + [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void Xml_TypeInCollectibleALC() { ExecuteAndUnload("SerializableAssembly.dll", "SerializationTypes.SimpleType", out var weakRef); diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs index 2e9b02c77e6128..a4b948f9d4f0b5 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs @@ -46,6 +46,7 @@ public void RelativeSearchPath_Is_Null() [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.HasHostExecutable))] [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Android | TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "The dotnet sdk will not be available on these platforms")] + [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public void TargetFrameworkTest() { const int ExpectedExitCode = 0; diff --git a/src/libraries/System.Threading.Thread/tests/ThreadTests.cs b/src/libraries/System.Threading.Thread/tests/ThreadTests.cs index 8d0f73598ecc29..697e389d66bbeb 100644 --- a/src/libraries/System.Threading.Thread/tests/ThreadTests.cs +++ b/src/libraries/System.Threading.Thread/tests/ThreadTests.cs @@ -168,6 +168,7 @@ public static IEnumerable ApartmentStateTest_MemberData() [InlineData("DefaultApartmentStateMain.exe", "GetApartmentStateTest")] [InlineData("DefaultApartmentStateMain.exe", "SetApartmentStateTest")] [ActiveIssue("https://github.com/dotnet/runtime/issues/34543", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] + [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void ApartmentState_AttributePresent(string appName, string testName) { var psi = new ProcessStartInfo(); diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index ce3beb31ecc92e..c9d13b0780de12 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -618,20 +618,10 @@ Tracking Issue for this work item: https://github.com/dotnet/runtime/issues/95928 --> - - - - - - - - - - From 41e254e75b5482c87fb42afa8717493cd13aae8e Mon Sep 17 00:00:00 2001 From: Ivan Diaz Date: Tue, 9 Jan 2024 14:53:56 -0800 Subject: [PATCH 2/9] Added "ActiveIssue" annotation to failing Threading test. --- src/libraries/System.Threading.Thread/tests/ThreadTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Threading.Thread/tests/ThreadTests.cs b/src/libraries/System.Threading.Thread/tests/ThreadTests.cs index 697e389d66bbeb..faad4bebd6af19 100644 --- a/src/libraries/System.Threading.Thread/tests/ThreadTests.cs +++ b/src/libraries/System.Threading.Thread/tests/ThreadTests.cs @@ -168,7 +168,7 @@ public static IEnumerable ApartmentStateTest_MemberData() [InlineData("DefaultApartmentStateMain.exe", "GetApartmentStateTest")] [InlineData("DefaultApartmentStateMain.exe", "SetApartmentStateTest")] [ActiveIssue("https://github.com/dotnet/runtime/issues/34543", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)] - [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/86722", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void ApartmentState_AttributePresent(string appName, string testName) { var psi = new ProcessStartInfo(); From 0e729464a01e6d1198c3a07d0441d44d98e49af0 Mon Sep 17 00:00:00 2001 From: Ivan Diaz Date: Tue, 9 Jan 2024 15:30:05 -0800 Subject: [PATCH 3/9] Added the ActiveIssue annotation to AppDomain.cs --- .../System.Runtime.Extensions.Tests/System/AppDomainTests.cs | 2 +- src/libraries/tests.proj | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs index a4b948f9d4f0b5..f473d1dec82762 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs @@ -46,7 +46,7 @@ public void RelativeSearchPath_Is_Null() [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.HasHostExecutable))] [SkipOnPlatform(TestPlatforms.Browser | TestPlatforms.Android | TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst, "The dotnet sdk will not be available on these platforms")] - [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/96727", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public void TargetFrameworkTest() { const int ExpectedExitCode = 0; diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index c9d13b0780de12..9bc2659d3e0c36 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -622,6 +622,7 @@ + From 7c8d940539c5e7bc7db9cf66a8db0c0b69f31c63 Mon Sep 17 00:00:00 2001 From: Ivan Diaz Date: Tue, 9 Jan 2024 15:50:28 -0800 Subject: [PATCH 4/9] Added the ActiveIssue template in FileSystemWatcher.File.Move.cs --- .../tests/FileSystemWatcher.File.Move.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs index fb840512d24eb2..e03ebc8ee92a8c 100644 --- a/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs +++ b/src/libraries/System.IO.FileSystem.Watcher/tests/FileSystemWatcher.File.Move.cs @@ -185,7 +185,7 @@ private void FileMove_DifferentWatchedDirectory(WatcherChangeTypes eventType) } } - [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/96728", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] private void FileMove_FromWatchedToUnwatched(WatcherChangeTypes eventType) { string dir_watched = CreateTestDirectory(TestDirectory, "dir_watched"); From 86f1764642f650d7611073e527d82a0d79da7a5e Mon Sep 17 00:00:00 2001 From: Ivan Diaz Date: Tue, 9 Jan 2024 15:58:45 -0800 Subject: [PATCH 5/9] Commented out an ActiveIssue annotation because I need to check on something in CI. --- src/libraries/System.Console/tests/WindowAndCursorProps.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Console/tests/WindowAndCursorProps.cs b/src/libraries/System.Console/tests/WindowAndCursorProps.cs index 64ce877c915b19..487a417cf94c36 100644 --- a/src/libraries/System.Console/tests/WindowAndCursorProps.cs +++ b/src/libraries/System.Console/tests/WindowAndCursorProps.cs @@ -119,7 +119,7 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException() [Fact] [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix - [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] + // [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void LargestWindowHeight_UnixGet_ReturnsExpected() { Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight)); From 74f3077a9d202bc222c0b0ca225d14ac55442c96 Mon Sep 17 00:00:00 2001 From: Ivan Diaz Date: Tue, 9 Jan 2024 16:04:21 -0800 Subject: [PATCH 6/9] Reenabled another failing test because I need to see it in CI. --- .../Microsoft.XmlSerializer.Generator/tests/SGenTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs b/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs index 263f2370a198ad..d394d5167c8648 100644 --- a/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs +++ b/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs @@ -12,7 +12,7 @@ namespace Microsoft.XmlSerializer.Generator.Tests public static class SgenTests { [Fact] - [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] + // [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void SgenCommandTest() { /* From 99275ddaf8f6937559f1c10672f2ab2f0f0e7d09 Mon Sep 17 00:00:00 2001 From: Ivan Diaz Date: Tue, 9 Jan 2024 16:11:01 -0800 Subject: [PATCH 7/9] Yet another test being weird... --- .../tests/XmlSerializer/XmlSerializerTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs b/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs index 14c263c60da93e..d89f482f3534a7 100644 --- a/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs +++ b/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs @@ -2101,7 +2101,7 @@ public static void Xml_TypeWithSpecialCharacterInStringMember() [SkipOnPlatform(TestPlatforms.Browser, "AssemblyDependencyResolver not supported in wasm")] #endif [ActiveIssue("34072", TestRuntimes.Mono)] - [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] + // [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void Xml_TypeInCollectibleALC() { ExecuteAndUnload("SerializableAssembly.dll", "SerializationTypes.SimpleType", out var weakRef); From 4d8e6dbf7ba705f1c9fe80ce7eabf14ec3cc8462 Mon Sep 17 00:00:00 2001 From: Ivan Diaz Date: Wed, 10 Jan 2024 11:00:19 -0800 Subject: [PATCH 8/9] Disabled some Serialization tests after confirming in CI that they indeed not work. --- .../Microsoft.XmlSerializer.Generator/tests/SGenTests.cs | 2 +- .../tests/XmlSerializer/XmlSerializerTests.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs b/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs index d394d5167c8648..15f9dfd3999b70 100644 --- a/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs +++ b/src/libraries/Microsoft.XmlSerializer.Generator/tests/SGenTests.cs @@ -12,7 +12,7 @@ namespace Microsoft.XmlSerializer.Generator.Tests public static class SgenTests { [Fact] - // [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/96796", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void SgenCommandTest() { /* diff --git a/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs b/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs index d89f482f3534a7..649f53108380cf 100644 --- a/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs +++ b/src/libraries/System.Private.Xml/tests/XmlSerializer/XmlSerializerTests.cs @@ -2101,7 +2101,7 @@ public static void Xml_TypeWithSpecialCharacterInStringMember() [SkipOnPlatform(TestPlatforms.Browser, "AssemblyDependencyResolver not supported in wasm")] #endif [ActiveIssue("34072", TestRuntimes.Mono)] - // [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] + [ActiveIssue("https://github.com/dotnet/runtime/issues/96799", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void Xml_TypeInCollectibleALC() { ExecuteAndUnload("SerializableAssembly.dll", "SerializationTypes.SimpleType", out var weakRef); From f49deba752f90f0901701f46874c1fa1cea88748 Mon Sep 17 00:00:00 2001 From: Ivan Diaz Date: Thu, 11 Jan 2024 09:26:25 -0800 Subject: [PATCH 9/9] Removed unneeded? commented out ActiveIssue annotation. --- src/libraries/System.Console/tests/WindowAndCursorProps.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/libraries/System.Console/tests/WindowAndCursorProps.cs b/src/libraries/System.Console/tests/WindowAndCursorProps.cs index b3d0f93b822418..c54fa87f0e3615 100644 --- a/src/libraries/System.Console/tests/WindowAndCursorProps.cs +++ b/src/libraries/System.Console/tests/WindowAndCursorProps.cs @@ -119,7 +119,6 @@ public static void WindowHeight_SetUnix_ThrowsPlatformNotSupportedException() [Fact] [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.MacCatalyst & ~TestPlatforms.tvOS)] // Expected behavior specific to Unix - // [ActiveIssue("Issue", typeof(PlatformDetection), nameof(PlatformDetection.IsReadyToRunCompiled))] public static void LargestWindowHeight_UnixGet_ReturnsExpected() { Helpers.RunInNonRedirectedOutput((data) => Assert.Equal(Console.WindowHeight, Console.LargestWindowHeight));