From 37f87113a94720d05a52c3836cafde495d160906 Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Sat, 20 Jan 2024 08:24:30 +0000 Subject: [PATCH 1/2] Fix failing test for non-IcuCompatiblePlatform. --- .../CompareInfo/CompareInfoTests.HashCode.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.HashCode.cs b/src/libraries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.HashCode.cs index a2247b39f636ec..6caa36f0cd2607 100644 --- a/src/libraries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.HashCode.cs +++ b/src/libraries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.HashCode.cs @@ -121,7 +121,7 @@ public static IEnumerable CheckHashingOfSkippedChars_TestData() yield return new object[] { '\u2029', thaiCmpInfo }; // ParagraphSeparator: PARAGRAPH SEPARATOR } - [Theory] + [ConditionalTheory(PlatformDetection.IsIcuGlobalization)] [MemberData(nameof(CheckHashingOfSkippedChars_TestData))] public void CheckHashingOfSkippedChars(char character, CompareInfo cmpInfo) { From 1a0d2ba2f29b9dafe5586408450c91274ca2d116 Mon Sep 17 00:00:00 2001 From: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com> Date: Sat, 20 Jan 2024 13:16:35 +0000 Subject: [PATCH 2/2] Fix --- .../CompareInfo/CompareInfoTests.HashCode.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.HashCode.cs b/src/libraries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.HashCode.cs index 6caa36f0cd2607..6fe89b75e6199a 100644 --- a/src/libraries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.HashCode.cs +++ b/src/libraries/System.Runtime/tests/System.Globalization.Tests/CompareInfo/CompareInfoTests.HashCode.cs @@ -121,7 +121,7 @@ public static IEnumerable CheckHashingOfSkippedChars_TestData() yield return new object[] { '\u2029', thaiCmpInfo }; // ParagraphSeparator: PARAGRAPH SEPARATOR } - [ConditionalTheory(PlatformDetection.IsIcuGlobalization)] + [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsIcuGlobalization))] [MemberData(nameof(CheckHashingOfSkippedChars_TestData))] public void CheckHashingOfSkippedChars(char character, CompareInfo cmpInfo) {