From 269396cee692bd3887cd8431906d0694b8224e42 Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Wed, 1 May 2019 12:03:35 +0000
Subject: [PATCH 01/12] Update dependencies from
https://github.com/dotnet/arcade build 20190430.6
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19230.6
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19230.6
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19230.6
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19230.6
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19230.6
---
eng/Version.Details.xml | 20 ++++++++++----------
eng/Versions.props | 8 ++++----
global.json | 2 +-
3 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index e1a8fa352..b0c63eff8 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- a7a250e9c13147134543c35fef2fb81f19592edf
+ ac8d88df02d246d3147338fcfb03b1b93dc84b53
-
+
https://github.com/dotnet/arcade
- a7a250e9c13147134543c35fef2fb81f19592edf
+ ac8d88df02d246d3147338fcfb03b1b93dc84b53
-
+
https://github.com/dotnet/arcade
- a7a250e9c13147134543c35fef2fb81f19592edf
+ ac8d88df02d246d3147338fcfb03b1b93dc84b53
-
+
https://github.com/dotnet/arcade
- a7a250e9c13147134543c35fef2fb81f19592edf
+ ac8d88df02d246d3147338fcfb03b1b93dc84b53
-
+
https://github.com/dotnet/arcade
- a7a250e9c13147134543c35fef2fb81f19592edf
+ ac8d88df02d246d3147338fcfb03b1b93dc84b53
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index 5dc97dea0..88bd7ecc5 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19229.8
- 1.0.0-beta.19229.8
- 1.0.0-beta.19229.8
- 1.0.0-beta.19229.8
+ 1.0.0-beta.19230.6
+ 1.0.0-beta.19230.6
+ 1.0.0-beta.19230.6
+ 1.0.0-beta.19230.6
2.0.3
diff --git a/global.json b/global.json
index a9dfc6e75..73a1636df 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.1.503"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19229.8"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19230.6"
}
}
From 080d51244e5fe7da211cd19e041a39c51dae74bd Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Thu, 2 May 2019 12:03:57 +0000
Subject: [PATCH 02/12] Update dependencies from
https://github.com/dotnet/arcade build 20190501.6
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19251.6
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19251.6
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19251.6
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19251.6
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19251.6
---
eng/Version.Details.xml | 20 ++++++++++----------
eng/Versions.props | 8 ++++----
eng/common/build.ps1 | 4 ++++
eng/common/build.sh | 4 ++++
eng/common/init-tools-native.ps1 | 6 +++++-
eng/common/init-tools-native.sh | 12 ++++--------
eng/common/tools.ps1 | 10 ++++++++++
eng/common/tools.sh | 12 ++++++++++++
global.json | 4 ++--
9 files changed, 55 insertions(+), 25 deletions(-)
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index b0c63eff8..8171ff3e8 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- ac8d88df02d246d3147338fcfb03b1b93dc84b53
+ ea9b2530a1559dd6426730aba52fca1924db2b65
-
+
https://github.com/dotnet/arcade
- ac8d88df02d246d3147338fcfb03b1b93dc84b53
+ ea9b2530a1559dd6426730aba52fca1924db2b65
-
+
https://github.com/dotnet/arcade
- ac8d88df02d246d3147338fcfb03b1b93dc84b53
+ ea9b2530a1559dd6426730aba52fca1924db2b65
-
+
https://github.com/dotnet/arcade
- ac8d88df02d246d3147338fcfb03b1b93dc84b53
+ ea9b2530a1559dd6426730aba52fca1924db2b65
-
+
https://github.com/dotnet/arcade
- ac8d88df02d246d3147338fcfb03b1b93dc84b53
+ ea9b2530a1559dd6426730aba52fca1924db2b65
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index 88bd7ecc5..fbcb508f4 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19230.6
- 1.0.0-beta.19230.6
- 1.0.0-beta.19230.6
- 1.0.0-beta.19230.6
+ 1.0.0-beta.19251.6
+ 1.0.0-beta.19251.6
+ 1.0.0-beta.19251.6
+ 1.0.0-beta.19251.6
2.0.3
diff --git a/eng/common/build.ps1 b/eng/common/build.ps1
index d0147db4b..ed9f754ea 100644
--- a/eng/common/build.ps1
+++ b/eng/common/build.ps1
@@ -122,6 +122,10 @@ try {
. $configureToolsetScript
}
+ if ($restore) {
+ InitializeNativeTools
+ }
+
Build
}
catch {
diff --git a/eng/common/build.sh b/eng/common/build.sh
index 40b1e8ec7..e14210632 100755
--- a/eng/common/build.sh
+++ b/eng/common/build.sh
@@ -218,4 +218,8 @@ if [[ -n "${useInstalledDotNetCli:-}" ]]; then
use_installed_dotnet_cli="$useInstalledDotNetCli"
fi
+if [[ "$restore" == true ]]; then
+ InitializeNativeTools
+fi
+
Build
diff --git a/eng/common/init-tools-native.ps1 b/eng/common/init-tools-native.ps1
index 495a563a7..a4306bd37 100644
--- a/eng/common/init-tools-native.ps1
+++ b/eng/common/init-tools-native.ps1
@@ -41,9 +41,13 @@ Param (
[switch] $Force = $False,
[int] $DownloadRetries = 5,
[int] $RetryWaitTimeInSeconds = 30,
- [string] $GlobalJsonFile = "$PSScriptRoot\..\..\global.json"
+ [string] $GlobalJsonFile
)
+if (!$GlobalJsonFile) {
+ $GlobalJsonFile = Join-Path (Get-Item $PSScriptRoot).Parent.Parent.FullName "global.json"
+}
+
Set-StrictMode -version 2.0
$ErrorActionPreference="Stop"
diff --git a/eng/common/init-tools-native.sh b/eng/common/init-tools-native.sh
index 54b70f678..fc72d1394 100644
--- a/eng/common/init-tools-native.sh
+++ b/eng/common/init-tools-native.sh
@@ -9,7 +9,7 @@ clean=false
force=false
download_retries=5
retry_wait_time_seconds=30
-global_json_file="${scriptroot}/../../global.json"
+global_json_file="$(dirname "$(dirname "${scriptroot}")")/global.json"
declare -A native_assets
. $scriptroot/native/common-library.sh
@@ -71,6 +71,7 @@ function ReadGlobalJsonNativeTools {
local native_tools_list=$(echo $native_tools_section | awk -F"[{}]" '{print $2}')
native_tools_list=${native_tools_list//[\" ]/}
native_tools_list=${native_tools_list//,/$'\n'}
+ native_tools_list="$(echo -e "${native_tools_list}" | tr -d '[:space:]')"
local old_IFS=$IFS
while read -r line; do
@@ -116,8 +117,6 @@ else
installer_command+=" --clean"
fi
- echo "Installing $tool version $tool_version"
- echo "Executing '$installer_command'"
$installer_command
if [[ $? != 0 ]]; then
@@ -127,19 +126,16 @@ else
done
fi
-if [[ ! -z $clean ]]; then
+if [[ $clean = true ]]; then
exit 0
fi
if [[ -d $install_bin ]]; then
echo "Native tools are available from $install_bin"
- if [[ !-z BUILD_BUILDNUMBER ]]; then
- echo "##vso[task.prependpath]$install_bin"
- fi
+ echo "##vso[task.prependpath]$install_bin"
else
echo "Native tools install directory does not exist, installation failed" >&2
exit 1
fi
exit 0
-
diff --git a/eng/common/tools.ps1 b/eng/common/tools.ps1
index 5c4a129c8..09794dff8 100644
--- a/eng/common/tools.ps1
+++ b/eng/common/tools.ps1
@@ -391,6 +391,16 @@ function GetSdkTaskProject([string]$taskName) {
return Join-Path (Split-Path (InitializeToolset) -Parent) "SdkTasks\$taskName.proj"
}
+function InitializeNativeTools() {
+ if (Get-Member -InputObject $GlobalJson -Name "native-tools") {
+ $nativeArgs=""
+ if ($ci) {
+ $nativeArgs = "-InstallDirectory $ToolsDir"
+ }
+ Invoke-Expression "& `"$PSScriptRoot/init-tools-native.ps1`" $nativeArgs"
+ }
+}
+
function InitializeToolset() {
if (Test-Path variable:global:_ToolsetBuildProj) {
return $global:_ToolsetBuildProj
diff --git a/eng/common/tools.sh b/eng/common/tools.sh
index ecdece1f8..59f47c5fa 100644
--- a/eng/common/tools.sh
+++ b/eng/common/tools.sh
@@ -212,6 +212,17 @@ function GetNuGetPackageCachePath {
_GetNuGetPackageCachePath=$NUGET_PACKAGES
}
+function InitializeNativeTools() {
+ if grep -Fq "native-tools" $global_json_file
+ then
+ local nativeArgs=""
+ if [[ "$ci" == true ]]; then
+ nativeArgs="-InstallDirectory $tools_dir"
+ fi
+ "$_script_dir/init-tools-native.sh" $nativeArgs
+ fi
+}
+
function InitializeToolset {
if [[ -n "${_InitializeToolset:-}" ]]; then
return
@@ -307,6 +318,7 @@ eng_root=`cd -P "$_script_dir/.." && pwd`
repo_root=`cd -P "$_script_dir/../.." && pwd`
artifacts_dir="$repo_root/artifacts"
toolset_dir="$artifacts_dir/toolset"
+tools_dir="$repo_root/.tools"
log_dir="$artifacts_dir/log/$configuration"
temp_dir="$artifacts_dir/tmp/$configuration"
diff --git a/global.json b/global.json
index 73a1636df..3f2505865 100644
--- a/global.json
+++ b/global.json
@@ -1,8 +1,8 @@
{
"tools": {
- "dotnet": "2.1.503"
+ "dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19230.6"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19251.6"
}
}
From 6ec767eea19c4478fb66f3b938617ab0e2ecffd1 Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Fri, 3 May 2019 12:03:45 +0000
Subject: [PATCH 03/12] Update dependencies from
https://github.com/dotnet/arcade build 20190502.2
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19252.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19252.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19252.2
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19252.2
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19252.2
---
eng/Version.Details.xml | 20 ++++++++++----------
eng/Versions.props | 8 ++++----
global.json | 2 +-
3 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index 8171ff3e8..dd8bf4261 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- ea9b2530a1559dd6426730aba52fca1924db2b65
+ ed63a7faf2d119829dd971be91bb46b6ebaa1dd2
-
+
https://github.com/dotnet/arcade
- ea9b2530a1559dd6426730aba52fca1924db2b65
+ ed63a7faf2d119829dd971be91bb46b6ebaa1dd2
-
+
https://github.com/dotnet/arcade
- ea9b2530a1559dd6426730aba52fca1924db2b65
+ ed63a7faf2d119829dd971be91bb46b6ebaa1dd2
-
+
https://github.com/dotnet/arcade
- ea9b2530a1559dd6426730aba52fca1924db2b65
+ ed63a7faf2d119829dd971be91bb46b6ebaa1dd2
-
+
https://github.com/dotnet/arcade
- ea9b2530a1559dd6426730aba52fca1924db2b65
+ ed63a7faf2d119829dd971be91bb46b6ebaa1dd2
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index fbcb508f4..6231e57f2 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19251.6
- 1.0.0-beta.19251.6
- 1.0.0-beta.19251.6
- 1.0.0-beta.19251.6
+ 1.0.0-beta.19252.2
+ 1.0.0-beta.19252.2
+ 1.0.0-beta.19252.2
+ 1.0.0-beta.19252.2
2.0.3
diff --git a/global.json b/global.json
index 3f2505865..b850cfeb4 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19251.6"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19252.2"
}
}
From 496d6299f8c0a7fe8fcde35e56f589dc17528dbf Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Sat, 4 May 2019 12:03:45 +0000
Subject: [PATCH 04/12] Update dependencies from
https://github.com/dotnet/arcade build 20190503.8
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19253.8
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19253.8
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19253.8
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19253.8
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19253.8
---
eng/Version.Details.xml | 20 ++++++++++----------
eng/Versions.props | 8 ++++----
eng/common/build.ps1 | 2 +-
eng/common/build.sh | 2 +-
global.json | 2 +-
5 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index dd8bf4261..9ea173c2d 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- ed63a7faf2d119829dd971be91bb46b6ebaa1dd2
+ 4cacf7aa7b2cd8bdd042e721e6ad73d809dd5678
-
+
https://github.com/dotnet/arcade
- ed63a7faf2d119829dd971be91bb46b6ebaa1dd2
+ 4cacf7aa7b2cd8bdd042e721e6ad73d809dd5678
-
+
https://github.com/dotnet/arcade
- ed63a7faf2d119829dd971be91bb46b6ebaa1dd2
+ 4cacf7aa7b2cd8bdd042e721e6ad73d809dd5678
-
+
https://github.com/dotnet/arcade
- ed63a7faf2d119829dd971be91bb46b6ebaa1dd2
+ 4cacf7aa7b2cd8bdd042e721e6ad73d809dd5678
-
+
https://github.com/dotnet/arcade
- ed63a7faf2d119829dd971be91bb46b6ebaa1dd2
+ 4cacf7aa7b2cd8bdd042e721e6ad73d809dd5678
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index 6231e57f2..c41dc17f2 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19252.2
- 1.0.0-beta.19252.2
- 1.0.0-beta.19252.2
- 1.0.0-beta.19252.2
+ 1.0.0-beta.19253.8
+ 1.0.0-beta.19253.8
+ 1.0.0-beta.19253.8
+ 1.0.0-beta.19253.8
2.0.3
diff --git a/eng/common/build.ps1 b/eng/common/build.ps1
index ed9f754ea..d7e3799eb 100644
--- a/eng/common/build.ps1
+++ b/eng/common/build.ps1
@@ -122,7 +122,7 @@ try {
. $configureToolsetScript
}
- if ($restore) {
+ if (($restore) -and ($null -eq $env:DisableNativeToolsetInstalls)) {
InitializeNativeTools
}
diff --git a/eng/common/build.sh b/eng/common/build.sh
index e14210632..d038959ab 100755
--- a/eng/common/build.sh
+++ b/eng/common/build.sh
@@ -218,7 +218,7 @@ if [[ -n "${useInstalledDotNetCli:-}" ]]; then
use_installed_dotnet_cli="$useInstalledDotNetCli"
fi
-if [[ "$restore" == true ]]; then
+if [[ "$restore" == true && -z ${DisableNativeToolsetInstalls:-} ]]; then
InitializeNativeTools
fi
diff --git a/global.json b/global.json
index b850cfeb4..492dd9e8f 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19252.2"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19253.8"
}
}
From 3595a356b856dc822f062d2f85243bc60118fb9f Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Sun, 5 May 2019 12:03:47 +0000
Subject: [PATCH 05/12] Update dependencies from
https://github.com/dotnet/arcade build 20190504.1
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19254.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19254.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19254.1
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19254.1
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19254.1
---
eng/Version.Details.xml | 20 ++++++++++----------
eng/Versions.props | 8 ++++----
global.json | 2 +-
3 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index 9ea173c2d..724b5a8d1 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- 4cacf7aa7b2cd8bdd042e721e6ad73d809dd5678
+ 1b8589bbf53b9a5e819460798eff59830f39a3be
-
+
https://github.com/dotnet/arcade
- 4cacf7aa7b2cd8bdd042e721e6ad73d809dd5678
+ 1b8589bbf53b9a5e819460798eff59830f39a3be
-
+
https://github.com/dotnet/arcade
- 4cacf7aa7b2cd8bdd042e721e6ad73d809dd5678
+ 1b8589bbf53b9a5e819460798eff59830f39a3be
-
+
https://github.com/dotnet/arcade
- 4cacf7aa7b2cd8bdd042e721e6ad73d809dd5678
+ 1b8589bbf53b9a5e819460798eff59830f39a3be
-
+
https://github.com/dotnet/arcade
- 4cacf7aa7b2cd8bdd042e721e6ad73d809dd5678
+ 1b8589bbf53b9a5e819460798eff59830f39a3be
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index c41dc17f2..9a295983b 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19253.8
- 1.0.0-beta.19253.8
- 1.0.0-beta.19253.8
- 1.0.0-beta.19253.8
+ 1.0.0-beta.19254.1
+ 1.0.0-beta.19254.1
+ 1.0.0-beta.19254.1
+ 1.0.0-beta.19254.1
2.0.3
diff --git a/global.json b/global.json
index 492dd9e8f..228f51dc9 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19253.8"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19254.1"
}
}
From 6ced663f939c18a0a0cdeaf9548caeb498e78089 Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Mon, 6 May 2019 12:04:21 +0000
Subject: [PATCH 06/12] Update dependencies from
https://github.com/dotnet/arcade build 20190505.2
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19255.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19255.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19255.2
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19255.2
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19255.2
---
eng/Version.Details.xml | 20 ++++++++++----------
eng/Versions.props | 8 ++++----
global.json | 2 +-
3 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index 724b5a8d1..3c97f7bc4 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- 1b8589bbf53b9a5e819460798eff59830f39a3be
+ 6a34948f7bdbc3ceb2fb16441b49f7748a462646
-
+
https://github.com/dotnet/arcade
- 1b8589bbf53b9a5e819460798eff59830f39a3be
+ 6a34948f7bdbc3ceb2fb16441b49f7748a462646
-
+
https://github.com/dotnet/arcade
- 1b8589bbf53b9a5e819460798eff59830f39a3be
+ 6a34948f7bdbc3ceb2fb16441b49f7748a462646
-
+
https://github.com/dotnet/arcade
- 1b8589bbf53b9a5e819460798eff59830f39a3be
+ 6a34948f7bdbc3ceb2fb16441b49f7748a462646
-
+
https://github.com/dotnet/arcade
- 1b8589bbf53b9a5e819460798eff59830f39a3be
+ 6a34948f7bdbc3ceb2fb16441b49f7748a462646
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index 9a295983b..30efb84e0 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19254.1
- 1.0.0-beta.19254.1
- 1.0.0-beta.19254.1
- 1.0.0-beta.19254.1
+ 1.0.0-beta.19255.2
+ 1.0.0-beta.19255.2
+ 1.0.0-beta.19255.2
+ 1.0.0-beta.19255.2
2.0.3
diff --git a/global.json b/global.json
index 228f51dc9..cdba2f50c 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19254.1"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19255.2"
}
}
From c91651c7ea6d6f816b2203ee6a8667af5f90db36 Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Mon, 6 May 2019 23:23:09 +0000
Subject: [PATCH 07/12] Update dependencies from
https://github.com/dotnet/arcade build 20190506.1
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19256.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19256.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19256.1
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19256.1
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19256.1
---
eng/Version.Details.xml | 20 +++++++-------
eng/Versions.props | 8 +++---
eng/common/dotnet-install.cmd | 2 ++
eng/common/dotnet-install.ps1 | 22 ++++++++++++++++
eng/common/dotnet-install.sh | 49 +++++++++++++++++++++++++++++++++++
eng/common/tools.ps1 | 27 ++++++++++++++-----
eng/common/tools.sh | 39 +++++++++++++++++++++++-----
global.json | 2 +-
8 files changed, 141 insertions(+), 28 deletions(-)
create mode 100644 eng/common/dotnet-install.cmd
create mode 100644 eng/common/dotnet-install.ps1
create mode 100644 eng/common/dotnet-install.sh
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index 3c97f7bc4..a4e7a1c9b 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- 6a34948f7bdbc3ceb2fb16441b49f7748a462646
+ 917ed3ac79350e4072c724deb48404ee7d76ebef
-
+
https://github.com/dotnet/arcade
- 6a34948f7bdbc3ceb2fb16441b49f7748a462646
+ 917ed3ac79350e4072c724deb48404ee7d76ebef
-
+
https://github.com/dotnet/arcade
- 6a34948f7bdbc3ceb2fb16441b49f7748a462646
+ 917ed3ac79350e4072c724deb48404ee7d76ebef
-
+
https://github.com/dotnet/arcade
- 6a34948f7bdbc3ceb2fb16441b49f7748a462646
+ 917ed3ac79350e4072c724deb48404ee7d76ebef
-
+
https://github.com/dotnet/arcade
- 6a34948f7bdbc3ceb2fb16441b49f7748a462646
+ 917ed3ac79350e4072c724deb48404ee7d76ebef
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index 30efb84e0..6856bf8e8 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19255.2
- 1.0.0-beta.19255.2
- 1.0.0-beta.19255.2
- 1.0.0-beta.19255.2
+ 1.0.0-beta.19256.1
+ 1.0.0-beta.19256.1
+ 1.0.0-beta.19256.1
+ 1.0.0-beta.19256.1
2.0.3
diff --git a/eng/common/dotnet-install.cmd b/eng/common/dotnet-install.cmd
new file mode 100644
index 000000000..b1c2642e7
--- /dev/null
+++ b/eng/common/dotnet-install.cmd
@@ -0,0 +1,2 @@
+@echo off
+powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0dotnet-install.ps1""" %*"
\ No newline at end of file
diff --git a/eng/common/dotnet-install.ps1 b/eng/common/dotnet-install.ps1
new file mode 100644
index 000000000..5987943fd
--- /dev/null
+++ b/eng/common/dotnet-install.ps1
@@ -0,0 +1,22 @@
+[CmdletBinding(PositionalBinding=$false)]
+Param(
+ [string] $verbosity = "minimal",
+ [string] $architecture = "",
+ [string] $version = "Latest",
+ [string] $runtime = "dotnet"
+)
+
+. $PSScriptRoot\tools.ps1
+
+try {
+ $dotnetRoot = Join-Path $RepoRoot ".dotnet"
+ InstallDotNet $dotnetRoot $version $architecture $runtime $true
+}
+catch {
+ Write-Host $_
+ Write-Host $_.Exception
+ Write-Host $_.ScriptStackTrace
+ ExitWithExitCode 1
+}
+
+ExitWithExitCode 0
\ No newline at end of file
diff --git a/eng/common/dotnet-install.sh b/eng/common/dotnet-install.sh
new file mode 100644
index 000000000..c3072c958
--- /dev/null
+++ b/eng/common/dotnet-install.sh
@@ -0,0 +1,49 @@
+#!/usr/bin/env bash
+
+source="${BASH_SOURCE[0]}"
+# resolve $source until the file is no longer a symlink
+while [[ -h "$source" ]]; do
+ scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
+ source="$(readlink "$source")"
+ # if $source was a relative symlink, we need to resolve it relative to the path where the
+ # symlink file was located
+ [[ $source != /* ]] && source="$scriptroot/$source"
+done
+scriptroot="$( cd -P "$( dirname "$source" )" && pwd )"
+
+version='Latest'
+architecture=''
+runtime='dotnet'
+while [[ $# > 0 ]]; do
+ opt="$(echo "$1" | awk '{print tolower($0)}')"
+ case "$opt" in
+ -version|-v)
+ shift
+ version="$1"
+ ;;
+ -architecture|-a)
+ shift
+ architecture="$1"
+ ;;
+ -runtime|-r)
+ shift
+ runtime="$1"
+ ;;
+ *)
+ echo "Invalid argument: $1"
+ usage
+ exit 1
+ ;;
+ esac
+ shift
+done
+
+. "$scriptroot/tools.sh"
+dotnetRoot="$repo_root/.dotnet"
+InstallDotNet $dotnetRoot $version "$architecture" $runtime true || {
+ local exit_code=$?
+ echo "dotnet-install.sh failed (exit code '$exit_code')." >&2
+ ExitWithExitCode $exit_code
+}
+
+ExitWithExitCode 0
diff --git a/eng/common/tools.ps1 b/eng/common/tools.ps1
index 09794dff8..d86eef1e3 100644
--- a/eng/common/tools.ps1
+++ b/eng/common/tools.ps1
@@ -108,7 +108,7 @@ function InitializeDotNetCli([bool]$install) {
}
# Find the first path on %PATH% that contains the dotnet.exe
- if ($useInstalledDotNetCli -and ($env:DOTNET_INSTALL_DIR -eq $null)) {
+ if ($useInstalledDotNetCli -and (-not $globalJsonHasRuntimes) -and ($env:DOTNET_INSTALL_DIR -eq $null)) {
$dotnetCmd = Get-Command "dotnet.exe" -ErrorAction SilentlyContinue
if ($dotnetCmd -ne $null) {
$env:DOTNET_INSTALL_DIR = Split-Path $dotnetCmd.Path -Parent
@@ -119,7 +119,7 @@ function InitializeDotNetCli([bool]$install) {
# Use dotnet installation specified in DOTNET_INSTALL_DIR if it contains the required SDK version,
# otherwise install the dotnet CLI and SDK to repo local .dotnet directory to avoid potential permission issues.
- if (($env:DOTNET_INSTALL_DIR -ne $null) -and (Test-Path(Join-Path $env:DOTNET_INSTALL_DIR "sdk\$dotnetSdkVersion"))) {
+ if ((-not $globalJsonHasRuntimes) -and ($env:DOTNET_INSTALL_DIR -ne $null) -and (Test-Path(Join-Path $env:DOTNET_INSTALL_DIR "sdk\$dotnetSdkVersion"))) {
$dotnetRoot = $env:DOTNET_INSTALL_DIR
} else {
$dotnetRoot = Join-Path $RepoRoot ".dotnet"
@@ -152,7 +152,7 @@ function InitializeDotNetCli([bool]$install) {
}
function GetDotNetInstallScript([string] $dotnetRoot) {
- $installScript = "$dotnetRoot\dotnet-install.ps1"
+ $installScript = Join-Path $dotnetRoot "dotnet-install.ps1"
if (!(Test-Path $installScript)) {
Create-Directory $dotnetRoot
Invoke-WebRequest "https://dot.net/v1/dotnet-install.ps1" -OutFile $installScript
@@ -162,9 +162,21 @@ function GetDotNetInstallScript([string] $dotnetRoot) {
}
function InstallDotNetSdk([string] $dotnetRoot, [string] $version, [string] $architecture = "") {
+ InstallDotNet $dotnetRoot $version $architecture
+}
+
+function InstallDotNet([string] $dotnetRoot, [string] $version, [string] $architecture = "", [string] $runtime = "", [bool] $skipNonVersionedFiles = $false) { $installScript = GetDotNetInstallScript $dotnetRoot
$installScript = GetDotNetInstallScript $dotnetRoot
- $archArg = if ($architecture) { $architecture } else { "" }
- & $installScript -Version $version -InstallDir $dotnetRoot -Architecture $archArg
+ $installParameters = @{
+ Version = $version
+ InstallDir = $dotnetRoot
+ }
+
+ if ($architecture) { $installParameters.Architecture = $architecture }
+ if ($runtime) { $installParameters.Runtime = $runtime }
+ if ($skipNonVersionedFiles) { $installParameters.SkipNonVersionedFiles = $skipNonVersionedFiles }
+
+ & $installScript @installParameters
if ($lastExitCode -ne 0) {
Write-Host "Failed to install dotnet cli (exit code '$lastExitCode')." -ForegroundColor Red
ExitWithExitCode $lastExitCode
@@ -429,6 +441,7 @@ function InitializeToolset() {
$bl = if ($binaryLog) { "/bl:" + (Join-Path $LogDir "ToolsetRestore.binlog") } else { "" }
'' | Set-Content $proj
+
MSBuild $proj $bl /t:__WriteToolsetLocation /clp:ErrorsOnly`;NoSummary /p:__ToolsetLocationOutputFile=$toolsetLocationFile
$path = Get-Content $toolsetLocationFile -TotalCount 1
@@ -522,6 +535,8 @@ $ToolsDir = Join-Path $RepoRoot ".tools"
$LogDir = Join-Path (Join-Path $ArtifactsDir "log") $configuration
$TempDir = Join-Path (Join-Path $ArtifactsDir "tmp") $configuration
$GlobalJson = Get-Content -Raw -Path (Join-Path $RepoRoot "global.json") | ConvertFrom-Json
+# true if global.json contains a "runtimes" section
+$globalJsonHasRuntimes = if ($GlobalJson.tools.PSObject.Properties.Name -Match 'runtimes') { $true } else { $false }
Create-Directory $ToolsetDir
Create-Directory $TempDir
@@ -534,4 +549,4 @@ if ($ci) {
$env:TEMP = $TempDir
$env:TMP = $TempDir
-}
+}
\ No newline at end of file
diff --git a/eng/common/tools.sh b/eng/common/tools.sh
index 59f47c5fa..9dc565e29 100644
--- a/eng/common/tools.sh
+++ b/eng/common/tools.sh
@@ -101,7 +101,7 @@ function InitializeDotNetCli {
fi
# Find the first path on $PATH that contains the dotnet.exe
- if [[ "$use_installed_dotnet_cli" == true && -z "${DOTNET_INSTALL_DIR:-}" ]]; then
+ if [[ "$use_installed_dotnet_cli" == true && $global_json_has_runtimes == false && -z "${DOTNET_INSTALL_DIR:-}" ]]; then
local dotnet_path=`command -v dotnet`
if [[ -n "$dotnet_path" ]]; then
ResolvePath "$dotnet_path"
@@ -115,10 +115,11 @@ function InitializeDotNetCli {
# Use dotnet installation specified in DOTNET_INSTALL_DIR if it contains the required SDK version,
# otherwise install the dotnet CLI and SDK to repo local .dotnet directory to avoid potential permission issues.
- if [[ -n "${DOTNET_INSTALL_DIR:-}" && -d "$DOTNET_INSTALL_DIR/sdk/$dotnet_sdk_version" ]]; then
+ if [[ $global_json_has_runtimes == false && -n "${DOTNET_INSTALL_DIR:-}" && -d "$DOTNET_INSTALL_DIR/sdk/$dotnet_sdk_version" ]]; then
dotnet_root="$DOTNET_INSTALL_DIR"
else
dotnet_root="$repo_root/.dotnet"
+
export DOTNET_INSTALL_DIR="$dotnet_root"
if [[ ! -d "$DOTNET_INSTALL_DIR/sdk/$dotnet_sdk_version" ]]; then
@@ -149,16 +150,34 @@ function InitializeDotNetCli {
function InstallDotNetSdk {
local root=$1
local version=$2
+ local architecture=""
+ if [[ $# == 3 ]]; then
+ architecture=$3
+ fi
+ InstallDotNet "$root" "$version" $architecture
+}
+function InstallDotNet {
+ local root=$1
+ local version=$2
+
GetDotNetInstallScript "$root"
local install_script=$_GetDotNetInstallScript
- local arch_arg=""
- if [[ $# == 3 ]]; then
- arch_arg="--architecture $3"
+ local archArg=''
+ if [[ "$#" -ge "3" ]]; then
+ archArg="--architecture $3"
+ fi
+ local runtimeArg=''
+ if [[ "$#" -ge "4" ]]; then
+ runtimeArg="--runtime $4"
fi
- bash "$install_script" --version $version --install-dir "$root" $arch_arg || {
+ local skipNonVersionedFilesArg=""
+ if [[ "$#" -ge "5" ]]; then
+ skipNonVersionedFilesArg="--skip-non-versioned-files"
+ fi
+ bash "$install_script" --version $version --install-dir "$root" $archArg $runtimeArg $skipNonVersionedFilesArg || {
local exit_code=$?
echo "Failed to install dotnet SDK (exit code '$exit_code')." >&2
ExitWithExitCode $exit_code
@@ -323,6 +342,12 @@ log_dir="$artifacts_dir/log/$configuration"
temp_dir="$artifacts_dir/tmp/$configuration"
global_json_file="$repo_root/global.json"
+# determine if global.json contains a "runtimes" entry
+global_json_has_runtimes=false
+dotnetlocal_key=`grep -m 1 "runtimes" "$global_json_file"` || true
+if [[ -n "$dotnetlocal_key" ]]; then
+ global_json_has_runtimes=true
+fi
# HOME may not be defined in some scenarios, but it is required by NuGet
if [[ -z $HOME ]]; then
@@ -337,4 +362,4 @@ mkdir -p "$log_dir"
if [[ $ci == true ]]; then
export TEMP="$temp_dir"
export TMP="$temp_dir"
-fi
+fi
\ No newline at end of file
diff --git a/global.json b/global.json
index cdba2f50c..207163b39 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19255.2"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19256.1"
}
}
From 413d4d95e24478b910b2792376f84ede075b4622 Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Mon, 6 May 2019 23:36:59 +0000
Subject: [PATCH 08/12] Update dependencies from
https://github.com/dotnet/arcade build 20190506.4
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19256.4
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19256.4
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19256.4
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19256.4
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19256.4
---
eng/Version.Details.xml | 20 ++++++++++----------
eng/Versions.props | 8 ++++----
eng/common/build.sh | 18 ++----------------
eng/common/templates/job/job.yml | 3 +++
global.json | 2 +-
5 files changed, 20 insertions(+), 31 deletions(-)
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index a4e7a1c9b..e586aadca 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- 917ed3ac79350e4072c724deb48404ee7d76ebef
+ fe003f91e82195c5657c79ffa8d2831c9f07c9dc
-
+
https://github.com/dotnet/arcade
- 917ed3ac79350e4072c724deb48404ee7d76ebef
+ fe003f91e82195c5657c79ffa8d2831c9f07c9dc
-
+
https://github.com/dotnet/arcade
- 917ed3ac79350e4072c724deb48404ee7d76ebef
+ fe003f91e82195c5657c79ffa8d2831c9f07c9dc
-
+
https://github.com/dotnet/arcade
- 917ed3ac79350e4072c724deb48404ee7d76ebef
+ fe003f91e82195c5657c79ffa8d2831c9f07c9dc
-
+
https://github.com/dotnet/arcade
- 917ed3ac79350e4072c724deb48404ee7d76ebef
+ fe003f91e82195c5657c79ffa8d2831c9f07c9dc
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index 6856bf8e8..f6a86702f 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19256.1
- 1.0.0-beta.19256.1
- 1.0.0-beta.19256.1
- 1.0.0-beta.19256.1
+ 1.0.0-beta.19256.4
+ 1.0.0-beta.19256.4
+ 1.0.0-beta.19256.4
+ 1.0.0-beta.19256.4
2.0.3
diff --git a/eng/common/build.sh b/eng/common/build.sh
index d038959ab..ce846d888 100755
--- a/eng/common/build.sh
+++ b/eng/common/build.sh
@@ -35,7 +35,7 @@ usage()
echo " --nodeReuse Sets nodereuse msbuild parameter ('true' or 'false')"
echo " --warnAsError Sets warnaserror msbuild parameter ('true' or 'false')"
echo ""
- echo "Command line arguments starting with '/p:' are passed through to MSBuild."
+ echo "Command line arguments not listed above are passed thru to msbuild."
echo "Arguments can also be passed in with a single hyphen."
}
@@ -137,22 +137,8 @@ while [[ $# > 0 ]]; do
node_reuse=$2
shift
;;
- -p:*|/p:*)
- properties="$properties $1"
- ;;
- -m:*|/m:*)
- properties="$properties $1"
- ;;
- -bl:*|/bl:*)
- properties="$properties $1"
- ;;
- -dl:*|/dl:*)
- properties="$properties $1"
- ;;
*)
- echo "Invalid argument: $1"
- usage
- exit 1
+ properties="$properties $1"
;;
esac
diff --git a/eng/common/templates/job/job.yml b/eng/common/templates/job/job.yml
index 7839b70bb..1814e0ab6 100644
--- a/eng/common/templates/job/job.yml
+++ b/eng/common/templates/job/job.yml
@@ -90,6 +90,9 @@ jobs:
timeoutInMinutes: ${{ parameters.timeoutInMinutes }}
variables:
+ - ${{ if eq(parameters.enableTelemetry, 'true') }}:
+ - name: DOTNET_CLI_TELEMETRY_PROFILE
+ value: '$(Build.Repository.Uri)'
- ${{ each variable in parameters.variables }}:
# handle name-value variable syntax
# example:
diff --git a/global.json b/global.json
index 207163b39..813520fd1 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19256.1"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19256.4"
}
}
From 0df1f690f7a376da08c018af4ad4926205887459 Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Tue, 7 May 2019 12:05:35 +0000
Subject: [PATCH 09/12] Update dependencies from
https://github.com/dotnet/arcade build 20190506.12
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19256.12
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19256.12
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19256.12
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19256.12
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19256.12
---
eng/Version.Details.xml | 20 ++++++++++----------
eng/Versions.props | 8 ++++----
global.json | 2 +-
3 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index e586aadca..dd1eef404 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- fe003f91e82195c5657c79ffa8d2831c9f07c9dc
+ c31fac9f6899094226cb5cd77c85b8f60ecafa3d
-
+
https://github.com/dotnet/arcade
- fe003f91e82195c5657c79ffa8d2831c9f07c9dc
+ c31fac9f6899094226cb5cd77c85b8f60ecafa3d
-
+
https://github.com/dotnet/arcade
- fe003f91e82195c5657c79ffa8d2831c9f07c9dc
+ c31fac9f6899094226cb5cd77c85b8f60ecafa3d
-
+
https://github.com/dotnet/arcade
- fe003f91e82195c5657c79ffa8d2831c9f07c9dc
+ c31fac9f6899094226cb5cd77c85b8f60ecafa3d
-
+
https://github.com/dotnet/arcade
- fe003f91e82195c5657c79ffa8d2831c9f07c9dc
+ c31fac9f6899094226cb5cd77c85b8f60ecafa3d
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index f6a86702f..5bebf05b6 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19256.4
- 1.0.0-beta.19256.4
- 1.0.0-beta.19256.4
- 1.0.0-beta.19256.4
+ 1.0.0-beta.19256.12
+ 1.0.0-beta.19256.12
+ 1.0.0-beta.19256.12
+ 1.0.0-beta.19256.12
2.0.3
diff --git a/global.json b/global.json
index 813520fd1..52966f0cf 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19256.4"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19256.12"
}
}
From 004a0bcbcbf9fee11c1833b0421d1b58d24c5be3 Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Wed, 8 May 2019 12:03:52 +0000
Subject: [PATCH 10/12] Update dependencies from
https://github.com/dotnet/arcade build 20190507.7
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19257.7
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19257.7
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19257.7
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19257.7
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19257.7
---
eng/Version.Details.xml | 20 ++++----
eng/Versions.props | 8 ++--
eng/common/cross/arm/sources.list.vivid | 11 -----
eng/common/cross/arm/sources.list.wily | 11 -----
eng/common/cross/arm64/sources.list.vivid | 11 -----
eng/common/cross/arm64/sources.list.wily | 11 -----
eng/common/cross/build-rootfs.sh | 58 ++++++++++++++---------
eng/common/cross/x86/sources.list.vivid | 11 -----
eng/common/cross/x86/sources.list.wily | 11 -----
global.json | 2 +-
10 files changed, 51 insertions(+), 103 deletions(-)
delete mode 100644 eng/common/cross/arm/sources.list.vivid
delete mode 100644 eng/common/cross/arm/sources.list.wily
delete mode 100644 eng/common/cross/arm64/sources.list.vivid
delete mode 100644 eng/common/cross/arm64/sources.list.wily
delete mode 100644 eng/common/cross/x86/sources.list.vivid
delete mode 100644 eng/common/cross/x86/sources.list.wily
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index dd1eef404..21289258a 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- c31fac9f6899094226cb5cd77c85b8f60ecafa3d
+ bda52d7619f9420de46f2c39ffc972864bbcab63
-
+
https://github.com/dotnet/arcade
- c31fac9f6899094226cb5cd77c85b8f60ecafa3d
+ bda52d7619f9420de46f2c39ffc972864bbcab63
-
+
https://github.com/dotnet/arcade
- c31fac9f6899094226cb5cd77c85b8f60ecafa3d
+ bda52d7619f9420de46f2c39ffc972864bbcab63
-
+
https://github.com/dotnet/arcade
- c31fac9f6899094226cb5cd77c85b8f60ecafa3d
+ bda52d7619f9420de46f2c39ffc972864bbcab63
-
+
https://github.com/dotnet/arcade
- c31fac9f6899094226cb5cd77c85b8f60ecafa3d
+ bda52d7619f9420de46f2c39ffc972864bbcab63
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index 5bebf05b6..462d3b5da 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19256.12
- 1.0.0-beta.19256.12
- 1.0.0-beta.19256.12
- 1.0.0-beta.19256.12
+ 1.0.0-beta.19257.7
+ 1.0.0-beta.19257.7
+ 1.0.0-beta.19257.7
+ 1.0.0-beta.19257.7
2.0.3
diff --git a/eng/common/cross/arm/sources.list.vivid b/eng/common/cross/arm/sources.list.vivid
deleted file mode 100644
index 0b1215e47..000000000
--- a/eng/common/cross/arm/sources.list.vivid
+++ /dev/null
@@ -1,11 +0,0 @@
-deb http://ports.ubuntu.com/ubuntu-ports/ vivid main restricted universe
-deb-src http://ports.ubuntu.com/ubuntu-ports/ vivid main restricted universe
-
-deb http://ports.ubuntu.com/ubuntu-ports/ vivid-updates main restricted universe
-deb-src http://ports.ubuntu.com/ubuntu-ports/ vivid-updates main restricted universe
-
-deb http://ports.ubuntu.com/ubuntu-ports/ vivid-backports main restricted
-deb-src http://ports.ubuntu.com/ubuntu-ports/ vivid-backports main restricted
-
-deb http://ports.ubuntu.com/ubuntu-ports/ vivid-security main restricted universe multiverse
-deb-src http://ports.ubuntu.com/ubuntu-ports/ vivid-security main restricted universe multiverse
\ No newline at end of file
diff --git a/eng/common/cross/arm/sources.list.wily b/eng/common/cross/arm/sources.list.wily
deleted file mode 100644
index e23d1e02a..000000000
--- a/eng/common/cross/arm/sources.list.wily
+++ /dev/null
@@ -1,11 +0,0 @@
-deb http://ports.ubuntu.com/ubuntu-ports/ wily main restricted universe
-deb-src http://ports.ubuntu.com/ubuntu-ports/ wily main restricted universe
-
-deb http://ports.ubuntu.com/ubuntu-ports/ wily-updates main restricted universe
-deb-src http://ports.ubuntu.com/ubuntu-ports/ wily-updates main restricted universe
-
-deb http://ports.ubuntu.com/ubuntu-ports/ wily-backports main restricted
-deb-src http://ports.ubuntu.com/ubuntu-ports/ wily-backports main restricted
-
-deb http://ports.ubuntu.com/ubuntu-ports/ wily-security main restricted universe multiverse
-deb-src http://ports.ubuntu.com/ubuntu-ports/ wily-security main restricted universe multiverse
\ No newline at end of file
diff --git a/eng/common/cross/arm64/sources.list.vivid b/eng/common/cross/arm64/sources.list.vivid
deleted file mode 100644
index 0b1215e47..000000000
--- a/eng/common/cross/arm64/sources.list.vivid
+++ /dev/null
@@ -1,11 +0,0 @@
-deb http://ports.ubuntu.com/ubuntu-ports/ vivid main restricted universe
-deb-src http://ports.ubuntu.com/ubuntu-ports/ vivid main restricted universe
-
-deb http://ports.ubuntu.com/ubuntu-ports/ vivid-updates main restricted universe
-deb-src http://ports.ubuntu.com/ubuntu-ports/ vivid-updates main restricted universe
-
-deb http://ports.ubuntu.com/ubuntu-ports/ vivid-backports main restricted
-deb-src http://ports.ubuntu.com/ubuntu-ports/ vivid-backports main restricted
-
-deb http://ports.ubuntu.com/ubuntu-ports/ vivid-security main restricted universe multiverse
-deb-src http://ports.ubuntu.com/ubuntu-ports/ vivid-security main restricted universe multiverse
\ No newline at end of file
diff --git a/eng/common/cross/arm64/sources.list.wily b/eng/common/cross/arm64/sources.list.wily
deleted file mode 100644
index e23d1e02a..000000000
--- a/eng/common/cross/arm64/sources.list.wily
+++ /dev/null
@@ -1,11 +0,0 @@
-deb http://ports.ubuntu.com/ubuntu-ports/ wily main restricted universe
-deb-src http://ports.ubuntu.com/ubuntu-ports/ wily main restricted universe
-
-deb http://ports.ubuntu.com/ubuntu-ports/ wily-updates main restricted universe
-deb-src http://ports.ubuntu.com/ubuntu-ports/ wily-updates main restricted universe
-
-deb http://ports.ubuntu.com/ubuntu-ports/ wily-backports main restricted
-deb-src http://ports.ubuntu.com/ubuntu-ports/ wily-backports main restricted
-
-deb http://ports.ubuntu.com/ubuntu-ports/ wily-security main restricted universe multiverse
-deb-src http://ports.ubuntu.com/ubuntu-ports/ wily-security main restricted universe multiverse
\ No newline at end of file
diff --git a/eng/common/cross/build-rootfs.sh b/eng/common/cross/build-rootfs.sh
index 805948ca8..83ec39195 100644
--- a/eng/common/cross/build-rootfs.sh
+++ b/eng/common/cross/build-rootfs.sh
@@ -2,21 +2,21 @@
usage()
{
- echo "Usage: $0 [BuildArch] [LinuxCodeName] [lldbx.y] [--skipunmount]"
+ echo "Usage: $0 [BuildArch] [LinuxCodeName] [lldbx.y] [--skipunmount] --rootfs ]"
echo "BuildArch can be: arm(default), armel, arm64, x86"
- echo "LinuxCodeName - optional, Code name for Linux, can be: trusty(default), vivid, wily, xenial, zesty, bionic, alpine. If BuildArch is armel, LinuxCodeName is jessie(default) or tizen."
- echo "lldbx.y - optional, LLDB version, can be: lldb3.6(default), lldb3.8, lldb3.9, lldb4.0, no-lldb. Ignored for alpine"
+ echo "LinuxCodeName - optional, Code name for Linux, can be: trusty, xenial(default), zesty, bionic, alpine. If BuildArch is armel, LinuxCodeName is jessie(default) or tizen."
+ echo "lldbx.y - optional, LLDB version, can be: lldb3.9(default), lldb4.0, lldb5.0, lldb6.0 no-lldb. Ignored for alpine"
echo "--skipunmount - optional, will skip the unmount of rootfs folder."
exit 1
}
-__LinuxCodeName=trusty
+__LinuxCodeName=xenial
__CrossDir=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
__InitialDir=$PWD
__BuildArch=arm
__UbuntuArch=armhf
__UbuntuRepo="http://ports.ubuntu.com/"
-__LLDB_Package="lldb-3.6-dev"
+__LLDB_Package="liblldb-3.9-dev"
__SkipUnmount=0
# base development support
@@ -53,8 +53,12 @@ __AlpinePackages+=" openssl-dev"
__AlpinePackages+=" zlib-dev"
__UnprocessedBuildArgs=
-for i in "$@" ; do
- lowerI="$(echo $i | awk '{print tolower($0)}')"
+while :; do
+ if [ $# -le 0 ]; then
+ break
+ fi
+
+ lowerI="$(echo $1 | awk '{print tolower($0)}')"
case $lowerI in
-?|-h|--help)
usage
@@ -95,38 +99,40 @@ for i in "$@" ; do
lldb4.0)
__LLDB_Package="liblldb-4.0-dev"
;;
+ lldb5.0)
+ __LLDB_Package="liblldb-5.0-dev"
+ ;;
+ lldb6.0)
+ __LLDB_Package="liblldb-6.0-dev"
+ ;;
no-lldb)
unset __LLDB_Package
;;
- vivid)
- if [ "$__LinuxCodeName" != "jessie" ]; then
- __LinuxCodeName=vivid
- fi
- ;;
- wily)
+ trusty) # Ubuntu 14.04
if [ "$__LinuxCodeName" != "jessie" ]; then
- __LinuxCodeName=wily
+ __LinuxCodeName=trusty
fi
;;
- xenial)
+ xenial) # Ubunry 16.04
if [ "$__LinuxCodeName" != "jessie" ]; then
__LinuxCodeName=xenial
fi
;;
- zesty)
+ zesty) # Ununtu 17.04
if [ "$__LinuxCodeName" != "jessie" ]; then
__LinuxCodeName=zesty
fi
;;
- bionic)
+ bionic) # Ubuntu 18.04
if [ "$__LinuxCodeName" != "jessie" ]; then
__LinuxCodeName=bionic
fi
;;
- jessie)
+ jessie) # Debian 8
__LinuxCodeName=jessie
__UbuntuRepo="http://ftp.debian.org/debian/"
;;
+ # TBD Stretch -> Debian 9, Buster -> Debian 10
tizen)
if [ "$__BuildArch" != "armel" ]; then
echo "Tizen is available only for armel."
@@ -144,10 +150,16 @@ for i in "$@" ; do
--skipunmount)
__SkipUnmount=1
;;
+ --rootfsdir|-rootfsdir)
+ shift
+ __RootfsDir=$1
+ ;;
*)
- __UnprocessedBuildArgs="$__UnprocessedBuildArgs $i"
+ __UnprocessedBuildArgs="$__UnprocessedBuildArgs $1"
;;
esac
+
+ shift
done
if [ "$__BuildArch" == "armel" ]; then
@@ -155,12 +167,14 @@ if [ "$__BuildArch" == "armel" ]; then
fi
__UbuntuPackages+=" ${__LLDB_Package:-}"
-__RootfsDir="$__CrossDir/rootfs/$__BuildArch"
-
-if [[ -n "$ROOTFS_DIR" ]]; then
+if [ -z "$__RootfsDir" ] && [ ! -z "$ROOTFS_DIR" ]; then
__RootfsDir=$ROOTFS_DIR
fi
+if [ -z "$__RootfsDir" ]; then
+ __RootfsDir="$__CrossDir/rootfs/$__BuildArch"
+fi
+
if [ -d "$__RootfsDir" ]; then
if [ $__SkipUnmount == 0 ]; then
umount $__RootfsDir/*
diff --git a/eng/common/cross/x86/sources.list.vivid b/eng/common/cross/x86/sources.list.vivid
deleted file mode 100644
index 26d37b20f..000000000
--- a/eng/common/cross/x86/sources.list.vivid
+++ /dev/null
@@ -1,11 +0,0 @@
-deb http://archive.ubuntu.com/ubuntu/ vivid main restricted universe
-deb-src http://archive.ubuntu.com/ubuntu/ vivid main restricted universe
-
-deb http://archive.ubuntu.com/ubuntu/ vivid-updates main restricted universe
-deb-src http://archive.ubuntu.com/ubuntu/ vivid-updates main restricted universe
-
-deb http://archive.ubuntu.com/ubuntu/ vivid-backports main restricted
-deb-src http://archive.ubuntu.com/ubuntu/ vivid-backports main restricted
-
-deb http://archive.ubuntu.com/ubuntu/ vivid-security main restricted universe multiverse
-deb-src http://archive.ubuntu.com/ubuntu/ vivid-security main restricted universe multiverse
diff --git a/eng/common/cross/x86/sources.list.wily b/eng/common/cross/x86/sources.list.wily
deleted file mode 100644
index c4b0b442a..000000000
--- a/eng/common/cross/x86/sources.list.wily
+++ /dev/null
@@ -1,11 +0,0 @@
-deb http://archive.ubuntu.com/ubuntu/ wily main restricted universe
-deb-src http://archive.ubuntu.com/ubuntu/ wily main restricted universe
-
-deb http://archive.ubuntu.com/ubuntu/ wily-updates main restricted universe
-deb-src http://archive.ubuntu.com/ubuntu/ wily-updates main restricted universe
-
-deb http://archive.ubuntu.com/ubuntu/ wily-backports main restricted
-deb-src http://archive.ubuntu.com/ubuntu/ wily-backports main restricted
-
-deb http://archive.ubuntu.com/ubuntu/ wily-security main restricted universe multiverse
-deb-src http://archive.ubuntu.com/ubuntu/ wily-security main restricted universe multiverse
diff --git a/global.json b/global.json
index 52966f0cf..bfc39435d 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19256.12"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19257.7"
}
}
From 80d846bdca9095c6378f31612fec8f5aa904a3b3 Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Thu, 9 May 2019 12:03:58 +0000
Subject: [PATCH 11/12] Update dependencies from
https://github.com/dotnet/arcade build 20190508.5
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19258.5
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19258.5
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19258.5
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19258.5
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19258.5
---
eng/Version.Details.xml | 20 ++++++++++----------
eng/Versions.props | 8 ++++----
eng/common/tools.ps1 | 27 +++++++++++++++++++++++++--
global.json | 2 +-
4 files changed, 40 insertions(+), 17 deletions(-)
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index 21289258a..9adb28d20 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- bda52d7619f9420de46f2c39ffc972864bbcab63
+ 9005cee9510d23535c09bd9b6be7c426e526c067
-
+
https://github.com/dotnet/arcade
- bda52d7619f9420de46f2c39ffc972864bbcab63
+ 9005cee9510d23535c09bd9b6be7c426e526c067
-
+
https://github.com/dotnet/arcade
- bda52d7619f9420de46f2c39ffc972864bbcab63
+ 9005cee9510d23535c09bd9b6be7c426e526c067
-
+
https://github.com/dotnet/arcade
- bda52d7619f9420de46f2c39ffc972864bbcab63
+ 9005cee9510d23535c09bd9b6be7c426e526c067
-
+
https://github.com/dotnet/arcade
- bda52d7619f9420de46f2c39ffc972864bbcab63
+ 9005cee9510d23535c09bd9b6be7c426e526c067
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index 462d3b5da..f2828a8d1 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19257.7
- 1.0.0-beta.19257.7
- 1.0.0-beta.19257.7
- 1.0.0-beta.19257.7
+ 1.0.0-beta.19258.5
+ 1.0.0-beta.19258.5
+ 1.0.0-beta.19258.5
+ 1.0.0-beta.19258.5
2.0.3
diff --git a/eng/common/tools.ps1 b/eng/common/tools.ps1
index d86eef1e3..b0e767e81 100644
--- a/eng/common/tools.ps1
+++ b/eng/common/tools.ps1
@@ -11,6 +11,12 @@
# Binary log must be enabled on CI.
[bool]$binaryLog = if (Test-Path variable:binaryLog) { $binaryLog } else { $ci }
+# Set to true to use the pipelines logger which will enable Azure logging output.
+# https://github.com/Microsoft/azure-pipelines-tasks/blob/master/docs/authoring/commands.md
+# This flag is meant as a temporary opt-opt for the feature while validate it across
+# our consumers. It will be deleted in the future.
+[bool]$pipelinesLog = if (Test-Path variable:pipelinesLog) { $pipelinesLog } else { $ci }
+
# Turns on machine preparation/clean up code that changes the machine state (e.g. kills build processes).
[bool]$prepareMachine = if (Test-Path variable:prepareMachine) { $prepareMachine } else { $false }
@@ -442,7 +448,7 @@ function InitializeToolset() {
'' | Set-Content $proj
- MSBuild $proj $bl /t:__WriteToolsetLocation /clp:ErrorsOnly`;NoSummary /p:__ToolsetLocationOutputFile=$toolsetLocationFile
+ MSBuild-Core $proj $bl /t:__WriteToolsetLocation /clp:ErrorsOnly`;NoSummary /p:__ToolsetLocationOutputFile=$toolsetLocationFile
$path = Get-Content $toolsetLocationFile -TotalCount 1
if (!(Test-Path $path)) {
@@ -472,6 +478,23 @@ function Stop-Processes() {
# Terminates the script if the build fails.
#
function MSBuild() {
+ if ($pipelinesLog -and $msbuildEngine) {
+ $toolsetBuildProject = InitializeToolset
+ $tf = if ($msbuildEngine -eq "dotnet") { "netcoreapp2.1" } else { "net472" }
+ $path = Split-Path -parent $toolsetBuildProject
+ $path = Join-Path $path "$tf\Microsoft.DotNet.Arcade.Sdk.dll"
+ $args += "/logger:$path"
+ }
+
+ MSBuild-Core @args
+}
+
+#
+# Executes msbuild (or 'dotnet msbuild') with arguments passed to the function.
+# The arguments are automatically quoted.
+# Terminates the script if the build fails.
+#
+function MSBuild-Core() {
if ($ci) {
if (!$binaryLog) {
throw "Binary log must be enabled in CI build."
@@ -549,4 +572,4 @@ if ($ci) {
$env:TEMP = $TempDir
$env:TMP = $TempDir
-}
\ No newline at end of file
+}
diff --git a/global.json b/global.json
index bfc39435d..173ff8a16 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19257.7"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19258.5"
}
}
From 40fe5887457203f3d146892520aeadab1f025c45 Mon Sep 17 00:00:00 2001
From: dotnet-maestro <@dotnet-maestro>
Date: Fri, 10 May 2019 12:03:54 +0000
Subject: [PATCH 12/12] Update dependencies from
https://github.com/dotnet/arcade build 20190509.9
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19259.9
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19259.9
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19259.9
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19259.9
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19259.9
---
eng/Version.Details.xml | 20 ++++++++++----------
eng/Versions.props | 8 ++++----
eng/common/tools.ps1 | 10 +++++-----
eng/common/tools.sh | 4 ++--
global.json | 2 +-
5 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml
index 9adb28d20..9d6e647c6 100644
--- a/eng/Version.Details.xml
+++ b/eng/Version.Details.xml
@@ -3,25 +3,25 @@
-
+
https://github.com/dotnet/arcade
- 9005cee9510d23535c09bd9b6be7c426e526c067
+ 155080ecb738e189db75f8f2461ebad75d955aa7
-
+
https://github.com/dotnet/arcade
- 9005cee9510d23535c09bd9b6be7c426e526c067
+ 155080ecb738e189db75f8f2461ebad75d955aa7
-
+
https://github.com/dotnet/arcade
- 9005cee9510d23535c09bd9b6be7c426e526c067
+ 155080ecb738e189db75f8f2461ebad75d955aa7
-
+
https://github.com/dotnet/arcade
- 9005cee9510d23535c09bd9b6be7c426e526c067
+ 155080ecb738e189db75f8f2461ebad75d955aa7
-
+
https://github.com/dotnet/arcade
- 9005cee9510d23535c09bd9b6be7c426e526c067
+ 155080ecb738e189db75f8f2461ebad75d955aa7
https://github.com/dotnet/standard
diff --git a/eng/Versions.props b/eng/Versions.props
index f2828a8d1..d50130be9 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -24,10 +24,10 @@
netstandard.library
- 1.0.0-beta.19258.5
- 1.0.0-beta.19258.5
- 1.0.0-beta.19258.5
- 1.0.0-beta.19258.5
+ 1.0.0-beta.19259.9
+ 1.0.0-beta.19259.9
+ 1.0.0-beta.19259.9
+ 1.0.0-beta.19259.9
2.0.3
diff --git a/eng/common/tools.ps1 b/eng/common/tools.ps1
index b0e767e81..9ca177b82 100644
--- a/eng/common/tools.ps1
+++ b/eng/common/tools.ps1
@@ -358,7 +358,7 @@ function InitializeBuildTool() {
ExitWithExitCode 1
}
- $buildTool = @{ Path = Join-Path $dotnetRoot "dotnet.exe"; Command = "msbuild" }
+ $buildTool = @{ Path = Join-Path $dotnetRoot "dotnet.exe"; Command = "msbuild"; Tool = "dotnet"; Framework = "netcoreapp2.1" }
} elseif ($msbuildEngine -eq "vs") {
try {
$msbuildPath = InitializeVisualStudioMSBuild -install:$restore
@@ -367,7 +367,7 @@ function InitializeBuildTool() {
ExitWithExitCode 1
}
- $buildTool = @{ Path = $msbuildPath; Command = "" }
+ $buildTool = @{ Path = $msbuildPath; Command = ""; Tool = "vs"; Framework = "net472" }
} else {
Write-Host "Unexpected value of -msbuildEngine: '$msbuildEngine'." -ForegroundColor Red
ExitWithExitCode 1
@@ -478,11 +478,11 @@ function Stop-Processes() {
# Terminates the script if the build fails.
#
function MSBuild() {
- if ($pipelinesLog -and $msbuildEngine) {
+ if ($pipelinesLog) {
+ $buildTool = InitializeBuildTool
$toolsetBuildProject = InitializeToolset
- $tf = if ($msbuildEngine -eq "dotnet") { "netcoreapp2.1" } else { "net472" }
$path = Split-Path -parent $toolsetBuildProject
- $path = Join-Path $path "$tf\Microsoft.DotNet.Arcade.Sdk.dll"
+ $path = Join-Path $path (Join-Path $buildTool.Framework "Microsoft.DotNet.Arcade.Sdk.dll")
$args += "/logger:$path"
}
diff --git a/eng/common/tools.sh b/eng/common/tools.sh
index 9dc565e29..df3eb8bce 100644
--- a/eng/common/tools.sh
+++ b/eng/common/tools.sh
@@ -165,11 +165,11 @@ function InstallDotNet {
local install_script=$_GetDotNetInstallScript
local archArg=''
- if [[ "$#" -ge "3" ]]; then
+ if [[ -n "${3:-}" ]]; then
archArg="--architecture $3"
fi
local runtimeArg=''
- if [[ "$#" -ge "4" ]]; then
+ if [[ -n "${4:-}" ]]; then
runtimeArg="--runtime $4"
fi
diff --git a/global.json b/global.json
index 173ff8a16..673523d98 100644
--- a/global.json
+++ b/global.json
@@ -3,6 +3,6 @@
"dotnet": "2.2.203"
},
"msbuild-sdks": {
- "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19258.5"
+ "Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19259.9"
}
}