From 69be9074f96e35f4e67faf9a6b4e64659f6d21fa Mon Sep 17 00:00:00 2001 From: ThomasGoulet73 <51839772+ThomasGoulet73@users.noreply.github.com> Date: Fri, 23 Jan 2026 22:19:18 -0500 Subject: [PATCH] Reintroduce IDWriteFactory.CreateTextAnalyzer HRESULT validation Contributes to dotnet/wpf#5305 --- .../MS/internal/Text/TextInterface/Factory.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Text/TextInterface/Factory.cs b/src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Text/TextInterface/Factory.cs index 9c1014f0f56..2c416bc3cfb 100644 --- a/src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Text/TextInterface/Factory.cs +++ b/src/Microsoft.DotNet.Wpf/src/PresentationCore/MS/internal/Text/TextInterface/Factory.cs @@ -325,7 +325,11 @@ internal TextAnalyzer CreateTextAnalyzer() { IDWriteTextAnalyzer* textAnalyzer = null; - _factory.Value->CreateTextAnalyzer(&textAnalyzer); + int hr = _factory.Value->CreateTextAnalyzer(&textAnalyzer); + + GC.KeepAlive(this); + + DWriteUtil.ConvertHresultToException(hr); return new TextAnalyzer((Native.IDWriteTextAnalyzer*)textAnalyzer); }