From a3b668d7f96fdfe1c4fcbf6e22b3f8805e9466ca Mon Sep 17 00:00:00 2001 From: Fergus Date: Thu, 27 Nov 2025 16:07:20 +0000 Subject: [PATCH] fix: status page was non-navigable, because of a bug with query parameters --- .../features/models/Models/Models.tsx | 22 ++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/dashboard/src/components/features/models/Models/Models.tsx b/dashboard/src/components/features/models/Models/Models.tsx index 25f69ed19..a5f9f68a3 100644 --- a/dashboard/src/components/features/models/Models/Models.tsx +++ b/dashboard/src/components/features/models/Models/Models.tsx @@ -48,11 +48,23 @@ const Models: React.FC = () => { // sync search query to URL params useEffect(() => { - const params = new URLSearchParams(); - if (searchQuery) params.set("search", searchQuery); - if (currentPage) params.set("page", String(currentPage)); - - setSearchParams(params, { replace: true }); + setSearchParams( + (prev) => { + const params = new URLSearchParams(prev); + if (searchQuery) { + params.set("search", searchQuery); + } else { + params.delete("search"); + } + if (currentPage > 1) { + params.set("page", String(currentPage)); + } else { + params.delete("page"); + } + return params; + }, + { replace: true }, + ); }, [searchQuery, currentPage, setSearchParams]); // reset pagination when search query changes