fix: memcached port has been already used crash #5097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
May 11, 2025
src/server/dfly_main.cc
Outdated
| acceptor->AddListener(mc_port, listener.get()); | ||
| listeners.push_back(listener.release()); | ||
|
|
||
| if (mc_port == static_cast<uint32_t>(port)) { |
Collaborator
There was a problem hiding this comment.
the original behavior of exiting the process is correct.
proceeding on startup when a serious error was discovered is not correct.
so if you want to avoid "crashing", you can just exit(1) nicely if acceptor->AddListener fails.
no need to compare ports as it's not important at the end.
Collaborator
There was a problem hiding this comment.
see how we do it with "main_listener".
in fact - every AddListener call in this file should be handled like that: check if there is an error, log it and exit.
romange
approved these changes
May 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5096
This PR fixes a crash when starting Dragonfly if the Memcached port is the same as the Redis port.