Skip to content

fix: timeout for test_seeder_key_target #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BorysTheDev merged 1 commit into from
May 29, 2025
Merged

fix: timeout for test_seeder_key_target #5198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/dragonfly/seeder_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ async def test_seeder_key_target(async_client: aioredis.Redis):
s = Seeder(units=len(Seeder.DEFAULT_TYPES) * 2, key_target=5000)

# Ensure tests are not reasonably slow
async with async_timeout.timeout(1 + 4):
async with async_timeout.timeout(10):
Copy link
Contributor

@adiholden adiholden May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why this test is slower now?

Copy link
Contributor Author

@BorysTheDev BorysTheDev May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem can be in instances, because locally it is fast

# Fill with 5k keys, 1% derivation = 50
await s.run(async_client, target_deviation=0.01)
assert abs(await async_client.dbsize() - 5000) <= 50
Expand Down
Loading