Skip to content

chore: Enable valkey-search tests in CI #6021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vyavdoshenko merged 15 commits into from
Nov 9, 2025
Merged

chore: Enable valkey-search tests in CI #6021

vyavdoshenko merged 15 commits into from
Nov 9, 2025

Conversation

@vyavdoshenko
Copy link
Contributor

@vyavdoshenko vyavdoshenko commented Nov 6, 2025

Integrates valkey-search integration tests into the CI pipeline

Changes:

  • Modified sync-valkey-search-tests.sh to accept tag/revision parameter
  • Added sync step in CI to use specific valkey-search revision
  • Implemented test skip mechanism in conftest.py
  • Added skip list for tests incompatible with Dragonfly

@vyavdoshenko vyavdoshenko self-assigned this Nov 6, 2025
romange
romange previously approved these changes Nov 6, 2025
View reviewed changes
@romange
Copy link
Collaborator

romange commented Nov 6, 2025

seems like it does not work for older versions of python.
I am fine if it run only on ubuntu 24 or later.

romange
romange reviewed Nov 6, 2025
View reviewed changes
.github/workflows/ci.yml Outdated

- name: Run regression tests
if: matrix.container == 'ubuntu-dev:20'
if: matrix.container == 'ubuntu-dev:20' || matrix.container == 'ubuntu-dev:24'
Copy link
Collaborator

@romange romange Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this?

Copy link
Contributor Author

@vyavdoshenko vyavdoshenko Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tests executed for ubuntu-dev:20, not for ubuntu-dev:24
Please take a look any PR checks, they don't have python tests executed.
For example:
https://github.com/dragonflydb/dragonfly/actions/runs/19133606754/job/54680146596?pr=6018

Copy link
Contributor Author

@vyavdoshenko vyavdoshenko Nov 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added regression step for ubuntu-dev:24

romange
romange previously approved these changes Nov 6, 2025
View reviewed changes
@vyavdoshenko vyavdoshenko requested a review from romange November 7, 2025 14:28
@vyavdoshenko
Copy link
Contributor Author

vyavdoshenko commented Nov 7, 2025

@romange
I gave up in trying pass tests on ubuntu-dev:24 because dragonfly python tests don't pass on this setup. I suggest to fix in separate PR/task. Now I decided to patch valkey-search tests adding from __future__ import annotations in the beginning of each python file. It helps. I guess it's acceptable.

@romange
Copy link
Collaborator

romange commented Nov 9, 2025

yes, sure I tried to suggest a simple solution but it was only a suggestion.

@vyavdoshenko vyavdoshenko merged commit 7a92bf3 into main Nov 9, 2025
10 checks passed
@vyavdoshenko vyavdoshenko deleted the bobik/valkey_search_tests_ci branch November 9, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romange romange romange approved these changes

@kostasrim kostasrim Awaiting requested review from kostasrim

@dranikpg dranikpg Awaiting requested review from dranikpg

Assignees

@vyavdoshenko vyavdoshenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vyavdoshenko @romange