Skip to content

Commit 5eca244

Browse files
authored
Merge pull request #767 from dxc-technology/jcheng-textareaDefaultValue
[Minor] Adding defaultValue to textarea
2 parents d8f8f29 + f8cad59 commit 5eca244

File tree

4 files changed

+20
-2
lines changed

4 files changed

+20
-2
lines changed

projects/dxc-ngx-cdk-site/src/app/components/examples/textarea/textarea-properties/textarea-properties.component.html

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,13 @@
1818
and the value will be managed internally.
1919
</td>
2020
</tr>
21+
<tr>
22+
<td>defaultValue: string</td>
23+
<td></td>
24+
<td>
25+
Default value given to the textarea when is uncontrolled and also maintains the uncontrolled behaviour.
26+
</td>
27+
</tr>
2128
<tr>
2229
<td>label: string</td>
2330
<td></td>

projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/textarea-preview/textarea-preview.component.html

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@
99
tabIndexValue="3"
1010
>
1111
</dxc-textarea>
12+
<dxc-textarea
13+
label="default value"
14+
[pattern]="pattern"
15+
defaultValue="Default"
16+
>
17+
</dxc-textarea>
1218
</tbuilder-component-mode>
1319
<tbuilder-component-mode text="Invalid">
1420
<dxc-textarea label="Test" error="error"> </dxc-textarea>

projects/dxc-ngx-cdk/src/lib/dxc-textarea/dxc-textarea.component.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -396,6 +396,7 @@ describe("DxcTextareaComponent", () => {
396396
await render(DxcTextareaComponent, {
397397
componentProperties: {
398398
label: "Example label",
399+
defaultValue: "test",
399400
onChange: {
400401
emit: onChange,
401402
} as any,
@@ -406,6 +407,7 @@ describe("DxcTextareaComponent", () => {
406407
const textarea = <HTMLInputElement>(
407408
screen.getByLabelText("Example label (Optional)")
408409
);
410+
expect(screen.getByDisplayValue("test"));
409411
textarea.focus();
410412
expect(textarea).toHaveFocus();
411413
fireEvent.click(textarea);

projects/dxc-ngx-cdk/src/lib/dxc-textarea/dxc-textarea.component.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ export class DxcTextareaComponent implements OnInit {
3838

3939
@Input()
4040
value: string;
41+
42+
@Input()
43+
defaultValue: string;
4144

4245
@Input()
4346
id: string;
@@ -110,7 +113,7 @@ export class DxcTextareaComponent implements OnInit {
110113
optional: false,
111114
disabled: false,
112115
helperText: "",
113-
value: "",
116+
value: undefined,
114117
name: "",
115118
label: "",
116119
margin: "",
@@ -172,7 +175,7 @@ export class DxcTextareaComponent implements OnInit {
172175

173176
ngOnInit(): void {
174177
if (this.value === undefined) {
175-
this.value = "";
178+
this.value = this.defaultValue ?? "";
176179
this.controlled = false;
177180
} else {
178181
this.controlled = true;

0 commit comments

Comments
 (0)