Skip to content

Commit f44109e

Browse files
authored
Merge pull request #756 from dxc-technology/fix-723
[Major] Renamed tabIndex prop to tabIndexValue
2 parents 506f4b3 + e927f30 commit f44109e

File tree

28 files changed

+133
-85
lines changed

28 files changed

+133
-85
lines changed

projects/dxc-ngx-cdk-site/src/app/components/examples/date-input/date-properties/date-properties.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@
6868
<td>
6969
If true, the date will be optional, showing <code>(Optional)</code>
7070
next to the label. Otherwise, the field will be considered required and an
71-
error will be passed as a parameter to the OnBlur and onChange events
72-
when it has not been filled.
71+
error will be passed as a parameter to the OnBlur and onChange events when
72+
it has not been filled.
7373
</td>
7474
</tr>
7575
<tr>
@@ -125,7 +125,7 @@
125125
<td>Size of the component ('medium' | 'large' | 'fillParent').</td>
126126
</tr>
127127
<tr>
128-
<td>tabIndex: number</td>
128+
<td>tabIndexValue: number</td>
129129
<td>
130130
<code>0</code>
131131
</td>

projects/dxc-ngx-cdk-site/src/app/components/examples/number-input/number-properties/number-properties.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150
</td>
151151
</tr>
152152
<tr>
153-
<td>tabIndex: number</td>
153+
<td>tabIndexValue: number</td>
154154
<td>
155155
<code>0</code>
156156
</td>

projects/dxc-ngx-cdk-site/src/app/components/examples/password-input/password-properties/password-properties.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@
134134
</td>
135135
</tr>
136136
<tr>
137-
<td>tabIndex: number</td>
137+
<td>tabIndexValue: number</td>
138138
<td>
139139
<code>0</code>
140140
</td>

projects/dxc-ngx-cdk-site/src/app/components/examples/radio-group/properties/radio-group-properties/radio-group-properties.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
</td>
122122
</tr>
123123
<tr>
124-
<td>tabIndex: number</td>
124+
<td>tabIndexValue: number</td>
125125
<td></td>
126126
<td>Value of the tabindex attribute.</td>
127127
</tr>

projects/dxc-ngx-cdk-site/src/app/components/examples/select/select-properties/select-properties.component.html

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,7 @@
3232
<td>options: Option[] | OptionGroup[]</td>
3333
<td></td>
3434
<td>
35-
List of options. The following interfaces should be
36-
imported. <br />
35+
List of options. The following interfaces should be imported. <br />
3736
Option:
3837
<ul>
3938
<li>
@@ -71,7 +70,10 @@
7170
<td>
7271
<code>false</code>
7372
</td>
74-
<td>If true, multiple options can be selected. If false, only a single option can be selected.</td>
73+
<td>
74+
If true, multiple options can be selected. If false, only a single option
75+
can be selected.
76+
</td>
7577
</tr>
7678
<tr>
7779
<td>disabled: boolean</td>
@@ -100,9 +102,10 @@
100102
<td>onChange: EventEmitter</td>
101103
<td></td>
102104
<td>
103-
This function will be called when the user select an option. An
104-
object including the new value (or values) and the error (if the value selected is not
105-
valid) will be passed to this function. An example of this object is:
105+
This function will be called when the user select an option. An object
106+
including the new value (or values) and the error (if the value selected
107+
is not valid) will be passed to this function. An example of this object
108+
is:
106109
{{ "{" }} <code>value: value, error: error</code>{{ "}" }}. If there is no
107110
error, error will be null.
108111
</td>
@@ -112,8 +115,8 @@
112115
<td></td>
113116
<td>
114117
This function will be called when the select loses the focus. An object
115-
including the value (or values) and the error (if the value selected is not
116-
valid) will be passed to this function. An example of this object is:
118+
including the value (or values) and the error (if the value selected is
119+
not valid) will be passed to this function. An example of this object is:
117120
{{ "{" }}
118121
<code>value: value, error: error</code>
119122
{{ "}" }}. If there is no error, error will be null.
@@ -139,7 +142,7 @@
139142
</td>
140143
</tr>
141144
<tr>
142-
<td>tabIndex: number</td>
145+
<td>tabIndexValue: number</td>
143146
<td>
144147
<code>0</code>
145148
</td>

projects/dxc-ngx-cdk-site/src/app/components/examples/text-input/text-input-properties/text-input-properties.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@
189189
</td>
190190
</tr>
191191
<tr>
192-
<td>tabIndex: number</td>
192+
<td>tabIndexValue: number</td>
193193
<td>
194194
<code>0</code>
195195
</td>

projects/dxc-ngx-cdk-site/src/app/components/examples/textarea/textarea-properties/textarea-properties.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@
173173
</td>
174174
</tr>
175175
<tr>
176-
<td>tabIndex: number</td>
176+
<td>tabIndexValue: number</td>
177177
<td>
178178
<code>0</code>
179179
</td>

projects/dxc-ngx-cdk-site/src/app/components/examples/toggleGroup/properties/toggleGroup-table-properties/toggleGroup-table-properties.component.html

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
1-
<dxc-heading [level]="4" weight="normal" text="Properties" [margin]="{bottom:'small'}"></dxc-heading>
1+
<dxc-heading
2+
[level]="4"
3+
weight="normal"
4+
text="Properties"
5+
[margin]="{ bottom: 'small' }"
6+
></dxc-heading>
27
<dxc-table>
38
<tr>
49
<th>Name</th>
@@ -13,35 +18,31 @@
1318
<tr>
1419
<td>helperText: string</td>
1520
<td></td>
16-
<td>
17-
Assistive text to be placed bellow the input.
18-
</td>
21+
<td>Assistive text to be placed bellow the input.</td>
1922
</tr>
2023
<tr>
2124
<td>value: any | any[]</td>
2225
<td></td>
2326
<td>
24-
Value(s) of the toggle(s) that are toggled. If undefined, the
25-
component will be uncontrolled and the value will be managed internally by
26-
the component.
27+
Value(s) of the toggle(s) that are toggled. If undefined, the component
28+
will be uncontrolled and the value will be managed internally by the
29+
component.
2730
</td>
2831
</tr>
2932
<tr>
3033
<td>multiple: boolean</td>
3134
<td>
3235
<code>false</code>
3336
</td>
34-
<td>
35-
If false only one toggle can be toggled.
36-
</td>
37+
<td>If false only one toggle can be toggled.</td>
3738
</tr>
3839
<tr>
3940
<td>disabled: boolean</td>
4041
<td><code>false</code></td>
4142
<td>If true, the component will be disabled.</td>
4243
</tr>
4344
<tr>
44-
<td>tabIndex: number</td>
45+
<td>tabIndexValue: number</td>
4546
<td></td>
4647
<td>
4748
Value of the tabindex which its propagated to their children components.
@@ -51,8 +52,8 @@
5152
<td>onChange: EventEmitter</td>
5253
<td></td>
5354
<td>
54-
This function will be called when the user changes the state of any toggle.
55-
The new value or values will be passed as a parameter.
55+
This function will be called when the user changes the state of any
56+
toggle. The new value or values will be passed as a parameter.
5657
</td>
5758
</tr>
5859
<tr>

projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/select-preview/select-preview.component.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
[optional]="true"
1313
placeholder="Another placeholder"
1414
size="large"
15-
tabIndex="3"
1615
>
1716
</dxc-select>
1817
<dxc-select

projects/dxc-ngx-cdk-site/src/app/pages/theme-builder/previews/text-input-preview/text-input-preview.component.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
[error]="errorMessage"
1717
[minLength]="minLength"
1818
[maxLength]="maxlength"
19+
tabIndexValue="1"
1920
>
2021
<dxc-text-input-action>
2122
<svg

0 commit comments

Comments
 (0)