-
Notifications
You must be signed in to change notification settings - Fork 188
Add Wayland to build matrix on GitHub actions #2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Wayland to build matrix on GitHub actions #2768
Conversation
1bddc88 to
45ee541
Compare
|
On most recent Ubuntu/Fedora/etc. distros users get Wayland session by default thus I would say that even on Gtk3 Wayland has become the most common setup. |
|
I am open to whatever collection of backends/gtk versions. For now this PR tests as before plus GTK4 on wayland. We could enable all 6 - I don't want to overwhelm the number of builds that run if it isn't valuable enough. |
45ee541 to
00d3b0c
Compare
|
@akurtakov I split out the question of which combinations to exclude to a future commit - this PR tests all of the valid combinations. Comment 0 and commit message updated. |
fa6418f to
0e5ce32
Compare
0e5ce32 to
1bf73d6
Compare
1bf73d6 to
fae431b
Compare
|
The JVM crashes are a corner case that I will workaround because IMHO they are bugs in GTK not in SWT: #2853 |
807d6c3 to
0b53193
Compare
2a35daa to
9adabe0
Compare
Add a compositor type build matrix entry for wayland, xwayland and x11. There are a total of 6 combinations possible of GTK/compositor: - GTK3 x11 (uses Xvfb) - GTK3 Xwayland (uses xwayland under weston headless) - GTK3 wayland (uses weston headless) - GTK4 x11 (uses Xvfb) - GTK4 Xwayland (uses xwayland under weston headless) - GTK4 wayland (uses weston headless) When using Xwayland, the GDK_BACKEND can be either x11 or wayland. For the other two cases the two need to match. This commit enables 5 new configuration options to build, with "GTK3 x11 (uses Xvfb)" being the pre-existing one. It is expected a future commit will start limiting how many of these run for all PRs. Part of eclipse-platform#2714
9adabe0 to
94b21d3
Compare
|
I have given up - for now at least - getting tests reliable on gtk3+wayland. As it turns out GTK3 itself is only tested on x11. GTK4 is tested on x11, wayland, and broadway. I have therefore excluded the gtk3/wayland combination and I open this up for review now. |
Add a compositor type build matrix entry for wayland, xwayland and x11.
There are a total of 6 combinations possible of GTK/compositor:
When using Xwayland, the GDK_BACKEND can be either x11 or wayland. For the other two cases the two need to match.
This commit enables 5 new configuration options to build, with "GTK3 x11 (uses Xvfb)" being the pre-existing one. It is expected a future commit will start limiting how many of these run for all PRs.
Part of #2714
In draft until dependent PR #2767 is merged.