Skip to content

Conversation

@jonahgraham
Copy link
Contributor

@jonahgraham jonahgraham commented Nov 11, 2025

Add a compositor type build matrix entry for wayland, xwayland and x11.

There are a total of 6 combinations possible of GTK/compositor:

  • GTK3 x11 (uses Xvfb)
  • GTK3 Xwayland (uses xwayland under weston headless)
  • GTK3 wayland (uses weston headless)
  • GTK4 x11 (uses Xvfb)
  • GTK4 Xwayland (uses xwayland under weston headless)
  • GTK4 wayland (uses weston headless)

When using Xwayland, the GDK_BACKEND can be either x11 or wayland. For the other two cases the two need to match.

This commit enables 5 new configuration options to build, with "GTK3 x11 (uses Xvfb)" being the pre-existing one. It is expected a future commit will start limiting how many of these run for all PRs.

Part of #2714

In draft until dependent PR #2767 is merged.

@akurtakov
Copy link
Member

On most recent Ubuntu/Fedora/etc. distros users get Wayland session by default thus I would say that even on Gtk3 Wayland has become the most common setup.

@jonahgraham
Copy link
Contributor Author

I am open to whatever collection of backends/gtk versions. For now this PR tests as before plus GTK4 on wayland. We could enable all 6 - I don't want to overwhelm the number of builds that run if it isn't valuable enough.

@jonahgraham
Copy link
Contributor Author

@akurtakov I split out the question of which combinations to exclude to a future commit - this PR tests all of the valid combinations. Comment 0 and commit message updated.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Test Results

  176 files  +29    176 suites  +29   29m 3s ⏱️ + 6m 8s
4 670 tests ± 0  4 648 ✅ ± 0  22 💤 ±0  0 ❌ ±0 
  481 runs  +70    475 ✅ +69   6 💤 +1  0 ❌ ±0 

Results for commit 94b21d3. ± Comparison against base commit 075a512.

♻️ This comment has been updated with latest results.

@jonahgraham
Copy link
Contributor Author

The JVM crashes are a corner case that I will workaround because IMHO they are bugs in GTK not in SWT: #2853

@jonahgraham jonahgraham force-pushed the wayland-matrix-entry branch 3 times, most recently from 807d6c3 to 0b53193 Compare December 5, 2025 20:11
@jonahgraham jonahgraham force-pushed the wayland-matrix-entry branch 7 times, most recently from 2a35daa to 9adabe0 Compare December 6, 2025 01:17
Add a compositor type build matrix entry for wayland, xwayland and x11.

There are a total of 6 combinations possible of GTK/compositor:

- GTK3 x11 (uses Xvfb)
- GTK3 Xwayland (uses xwayland under weston headless)
- GTK3 wayland (uses weston headless)
- GTK4 x11 (uses Xvfb)
- GTK4 Xwayland (uses xwayland under weston headless)
- GTK4 wayland (uses weston headless)

When using Xwayland, the GDK_BACKEND can be either x11 or wayland.
For the other two cases the two need to match.

This commit enables 5 new configuration options to build, with
"GTK3 x11 (uses Xvfb)" being the pre-existing one. It is expected
a future commit will start limiting how many of these run for
all PRs.

Part of eclipse-platform#2714
@jonahgraham
Copy link
Contributor Author

I have given up - for now at least - getting tests reliable on gtk3+wayland. As it turns out GTK3 itself is only tested on x11. GTK4 is tested on x11, wayland, and broadway.

I have therefore excluded the gtk3/wayland combination and I open this up for review now.

@jonahgraham jonahgraham marked this pull request as ready for review December 6, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants