Skip to content

Commit 13a103b

Browse files
authored
Upload correct container image (#3)
The devcontainer/ci action uploaded the devcontainer used to develop the S-CORE devcontainer. But it should have uploaded the S-CORE devcontainer instead. According to https://github.com/devcontainers/ci/blob/main/docs/github-action.md#inputs `subFolder` should specify the correct path to the container.
1 parent c4ae763 commit 13a103b

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ jobs:
3838
# publish latest from main branch; tags are handled in release workflow
3939
imageTag: latest
4040
refFilterForPush: 'refs/heads/main'
41+
subFolder: src/s-core-devcontainer
4142
runCmd: |
4243
# Check
4344
pre-commit run --show-diff-on-failure --color=always --all-files || exit -1

.github/workflows/release.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ jobs:
3131
imageName: ghcr.io/eclipse-score/devcontainer
3232
cacheFrom: ghcr.io/eclipse-score/devcontainer
3333
imageTag: ${{ github.ref_name }}
34+
subFolder: src/s-core-devcontainer
3435
runCmd: |
3536
# Check
3637
pre-commit run --show-diff-on-failure --color=always --all-files || exit -1

0 commit comments

Comments
 (0)