From b45cc572243340ce243ca808e5397fd229fd4433 Mon Sep 17 00:00:00 2001 From: Ryan Pond Date: Thu, 22 Aug 2024 09:27:19 -0700 Subject: [PATCH 1/2] Change checkbox to handle lowercase --- .../IssueFormItems/Checkboxes/IssueFormCheckBoxesText.cs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/GitHubIssueFormsParser/src/GitHubIssuesParserCli/IssueFormBodies/IssueFormItems/Checkboxes/IssueFormCheckBoxesText.cs b/GitHubIssueFormsParser/src/GitHubIssuesParserCli/IssueFormBodies/IssueFormItems/Checkboxes/IssueFormCheckBoxesText.cs index 083750d..f888ebb 100644 --- a/GitHubIssueFormsParser/src/GitHubIssuesParserCli/IssueFormBodies/IssueFormItems/Checkboxes/IssueFormCheckBoxesText.cs +++ b/GitHubIssueFormsParser/src/GitHubIssuesParserCli/IssueFormBodies/IssueFormItems/Checkboxes/IssueFormCheckBoxesText.cs @@ -25,6 +25,13 @@ private static List CreateCheckboxOptions(string option .TrimIssueText(); isChecked = true; } + else if (optionText.StartsWith("- [x]", StringComparison.Ordinal)) + { + label = optionText + .TrimStart([.. "- [x]"]) + .TrimIssueText(); + isChecked = true; + } else if (optionText.StartsWith("- [ ]", StringComparison.Ordinal)) { label = optionText From d4c07889a35ce048b3a1feef6e6711ee2fd30d54 Mon Sep 17 00:00:00 2001 From: Eduardo Serrano Date: Fri, 30 Aug 2024 13:42:59 +0100 Subject: [PATCH 2/2] Update tests to check for lower case 'X' on checkboxes --- .../CliIntegration/CliIntegrationTests.cs | 2 ++ .../tests/GitHubIssuesParserCli.Tests/TestFiles/IssueBody.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/GitHubIssueFormsParser/tests/GitHubIssuesParserCli.Tests/CliIntegration/CliIntegrationTests.cs b/GitHubIssueFormsParser/tests/GitHubIssuesParserCli.Tests/CliIntegration/CliIntegrationTests.cs index 69786c7..a64a7bd 100644 --- a/GitHubIssueFormsParser/tests/GitHubIssuesParserCli.Tests/CliIntegration/CliIntegrationTests.cs +++ b/GitHubIssueFormsParser/tests/GitHubIssuesParserCli.Tests/CliIntegration/CliIntegrationTests.cs @@ -117,6 +117,8 @@ public async Task TemplateFilepathOptionValidation2() /// /// Tests the correct value for the options that can be used with the 'parse-issue-form' command. + /// This test uses an issue body where the checkboxes use both an Uppercase and Lowercase 'X' or aren't + /// checked. /// [Theory] [InlineData("-i", "-t")] diff --git a/GitHubIssueFormsParser/tests/GitHubIssuesParserCli.Tests/TestFiles/IssueBody.md b/GitHubIssueFormsParser/tests/GitHubIssuesParserCli.Tests/TestFiles/IssueBody.md index 6c7fca3..093549e 100644 --- a/GitHubIssueFormsParser/tests/GitHubIssuesParserCli.Tests/TestFiles/IssueBody.md +++ b/GitHubIssueFormsParser/tests/GitHubIssuesParserCli.Tests/TestFiles/IssueBody.md @@ -29,6 +29,6 @@ Another line: ### Which operating systems have you used? - [X] macOS -- [X] Windows +- [x] Windows - [ ] Linux - [ ] I don't know