Skip to content

Commit de0deb1

Browse files
authored
fix: removed the docker images which are having no references (#196)
Ticket: https://2u-internal.atlassian.net/browse/BOMS-196
1 parent 818af50 commit de0deb1

File tree

4 files changed

+2
-35
lines changed

4 files changed

+2
-35
lines changed

Makefile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
help requirements impl-dev.clone.https impl-dev.clone.ssh impl-dev.provision \
6161
impl-dev.pull impl-dev.pull.without-deps impl-dev.up impl-dev.up.attach \
6262
impl-dev.up.without-deps selfcheck upgrade \
63-
validate-lms-volume vnc-passwords
63+
validate-lms-volume
6464

6565
# Load up options (configurable through options.local.mk).
6666
include options.mk
@@ -552,10 +552,6 @@ validate-lms-volume: ## Validate that changes to the local workspace are reflect
552552
docker compose exec -T lms ls /edx/app/edxapp/edx-platform/testfile
553553
rm $(DEVSTACK_WORKSPACE)/edx-platform/testfile
554554

555-
vnc-passwords: ## Get the VNC passwords for the Chrome and Firefox Selenium containers.
556-
@docker compose logs chrome 2>&1 | grep "VNC password" | tail -1
557-
@docker compose logs firefox 2>&1 | grep "VNC password" | tail -1
558-
559555
hadoop-application-logs-%: ## View hadoop logs by application Id.
560556
docker compose exec nodemanager yarn logs -applicationId $*
561557

docker-compose.yml

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,6 @@ services:
1414
# Third-party services
1515
# ================================================
1616

17-
chrome:
18-
container_name: "edx.${COMPOSE_PROJECT_NAME:-devstack}.chrome"
19-
hostname: chrome.devstack.edx
20-
image: edxops/chrome:latest
21-
shm_size: 2g
22-
networks:
23-
default:
24-
aliases:
25-
- edx.devstack.chrome
26-
ports:
27-
- "15900:5900"
28-
volumes: # for file uploads
29-
- ../edx-platform/common/test/data:/edx/app/edxapp/edx-platform/common/test/data
30-
3117
coursegraph:
3218
container_name: "edx.${COMPOSE_PROJECT_NAME:-devstack}.coursegraph"
3319
hostname: coursegraph.devstack.edx
@@ -86,20 +72,6 @@ services:
8672
- "ES_JAVA_OPTS=-Xms512m -Xmx512m"
8773
- "plugins.security.disabled=true"
8874

89-
firefox:
90-
container_name: "edx.${COMPOSE_PROJECT_NAME:-devstack}.firefox"
91-
hostname: firefox.devstack.edx
92-
image: edxops/firefox:latest
93-
shm_size: 2g
94-
networks:
95-
default:
96-
aliases:
97-
- edx.devstack.firefox
98-
ports:
99-
- "25900:5900"
100-
volumes: # for file uploads
101-
- ../edx-platform/common/test/data:/edx/app/edxapp/edx-platform/common/test/data
102-
10375
# Events broker
10476
kafka:
10577
image: confluentinc/cp-server:6.2.1

docs/devstack_interface.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,4 +220,3 @@ If you want to ensure you are getting the latest listing, simply use ``make help
220220
selfcheck Check that the Makefile is free of Make syntax errors.
221221
upgrade Upgrade requirements with pip-tools.
222222
validate-lms-volume Validate that changes to the local workspace are reflected in the LMS container.
223-
vnc-passwords Get the VNC passwords for the Chrome and Firefox Selenium containers.

options.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,4 +90,4 @@ credentials+cms+discovery+ecommerce+insights+lms+registrar
9090
# All third-party services.
9191
# Separated by plus signs. Listed in alphabetical order for clarity.
9292
THIRD_PARTY_SERVICES ?= \
93-
chrome+coursegraph+elasticsearch710+firefox+memcached+mongo+mysql80+opensearch12+redis+namenode+datanode+resourcemanager+nodemanager+sparkmaster+sparkworker+vertica
93+
coursegraph+elasticsearch710+memcached+mongo+mysql80+opensearch12+redis+namenode+datanode+resourcemanager+nodemanager+sparkmaster+sparkworker+vertica

0 commit comments

Comments
 (0)