From 459bfea4f1e3900a8f15f8b3e69aa44431500157 Mon Sep 17 00:00:00 2001 From: Bruce Wilcoxon Date: Mon, 30 Dec 2024 13:33:53 -0600 Subject: [PATCH 1/2] build(plugin-vite): allow renderer name to contain dashes --- packages/plugin/vite/src/config/vite.base.config.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/plugin/vite/src/config/vite.base.config.ts b/packages/plugin/vite/src/config/vite.base.config.ts index 727f6614e7..f16bf24951 100644 --- a/packages/plugin/vite/src/config/vite.base.config.ts +++ b/packages/plugin/vite/src/config/vite.base.config.ts @@ -32,8 +32,11 @@ export function getBuildConfig(env: ConfigEnv<'build'>): UserConfig { export function getDefineKeys(names: string[]) { const define: { [name: string]: VitePluginRuntimeKeys } = {}; + // change name from kebab case to upper snake case to agree with vite:define plugin + // this allows the VitePluginRendererConfig entries to contain names with dashes + return names.reduce((acc, name) => { - const NAME = name.toUpperCase(); + const NAME = name.toUpperCase().replaceAll('-', '_'); const keys: VitePluginRuntimeKeys = { VITE_DEV_SERVER_URL: `${NAME}_VITE_DEV_SERVER_URL`, VITE_NAME: `${NAME}_VITE_NAME`, From 0ee2a7747b331a4109edace8139a8ed1942688fb Mon Sep 17 00:00:00 2001 From: Bruce Wilcoxon Date: Tue, 31 Dec 2024 10:09:25 -0600 Subject: [PATCH 2/2] PR Feedback: formtatting --- packages/plugin/vite/src/config/vite.base.config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/plugin/vite/src/config/vite.base.config.ts b/packages/plugin/vite/src/config/vite.base.config.ts index f16bf24951..10fb0d4c02 100644 --- a/packages/plugin/vite/src/config/vite.base.config.ts +++ b/packages/plugin/vite/src/config/vite.base.config.ts @@ -33,7 +33,7 @@ export function getDefineKeys(names: string[]) { const define: { [name: string]: VitePluginRuntimeKeys } = {}; // change name from kebab case to upper snake case to agree with vite:define plugin - // this allows the VitePluginRendererConfig entries to contain names with dashes + // this allows the VitePluginRendererConfig entries to contain names with dashes return names.reduce((acc, name) => { const NAME = name.toUpperCase().replaceAll('-', '_');