From 89878977571ff9ef9e339124fe31a07cab9e8355 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Mon, 10 Jun 2024 09:22:28 -0400 Subject: [PATCH 1/2] Drop node < 18, unblocks 'Floating Dependencies' on #414 --- README.md | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index a886a50..ff17366 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ If you add build metadata to the version, this addon will automatically append S - Ember.js v3.28 or above - Ember CLI v3.28 or above -- Node.js v14 or above +- Node.js v18 or above ## Installation diff --git a/package.json b/package.json index 489d7b5..9fe13f6 100644 --- a/package.json +++ b/package.json @@ -79,7 +79,7 @@ "ember-source": "^3.28.0 || >= 4.0.0" }, "engines": { - "node": "14.* || 16.* || >= 18" + "node": ">= 18" }, "publishConfig": { "registry": "https://registry.npmjs.org" From 2a522061a160100f4c5fb49e93132a890a429b20 Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Mon, 10 Jun 2024 09:23:47 -0400 Subject: [PATCH 2/2] Update CI node --- .github/workflows/ci.yml | 6 +++--- .github/workflows/publish.yml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 89887dd..55318e6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,7 +22,7 @@ jobs: - name: Install Node uses: actions/setup-node@v3 with: - node-version: 14 + node-version: 18 cache: yarn - name: Install Dependencies run: yarn install --frozen-lockfile @@ -40,7 +40,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 14 + node-version: 18 cache: yarn - name: Install Dependencies run: yarn install --no-lockfile @@ -73,7 +73,7 @@ jobs: - name: Install Node uses: actions/setup-node@v3 with: - node-version: 14 + node-version: 18 cache: yarn - name: Install Dependencies run: yarn install --frozen-lockfile diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 3d33328..97a0c6b 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -16,7 +16,7 @@ jobs: - name: Install node uses: actions/setup-node@v3 with: - node-version: 14.x + node-version: 18.x registry-url: 'https://registry.npmjs.org' - name: install dependencies