From bd9056efdd1672c91e608a789fc405ad2e684547 Mon Sep 17 00:00:00 2001 From: Maurice Mohlek Date: Wed, 20 Jan 2016 15:19:28 +0100 Subject: [PATCH 1/2] Update link-to.js Fixes error when model is undefined --- packages/ember-routing-views/lib/components/link-to.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ember-routing-views/lib/components/link-to.js b/packages/ember-routing-views/lib/components/link-to.js index 98333e7d7d8..bc42aa2b71d 100644 --- a/packages/ember-routing-views/lib/components/link-to.js +++ b/packages/ember-routing-views/lib/components/link-to.js @@ -716,7 +716,7 @@ let LinkComponent = EmberComponent.extend({ }), _modelsAreLoaded: computed('models', function computeLinkToComponentModelsAreLoaded() { - let models = get(this, 'models'); + let models = get(this, 'models') | []; for (let i = 0, l = models.length; i < l; i++) { if (models[i] == null) { return false; } } From 40d6debfd1f4bd4e13bc4c263205163ef95969cb Mon Sep 17 00:00:00 2001 From: Maurice Mohlek Date: Wed, 20 Jan 2016 18:04:46 +0100 Subject: [PATCH 2/2] Update link-to.js added missing | --- packages/ember-routing-views/lib/components/link-to.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ember-routing-views/lib/components/link-to.js b/packages/ember-routing-views/lib/components/link-to.js index bc42aa2b71d..5ee4955a4ad 100644 --- a/packages/ember-routing-views/lib/components/link-to.js +++ b/packages/ember-routing-views/lib/components/link-to.js @@ -716,7 +716,7 @@ let LinkComponent = EmberComponent.extend({ }), _modelsAreLoaded: computed('models', function computeLinkToComponentModelsAreLoaded() { - let models = get(this, 'models') | []; + let models = get(this, 'models') || []; for (let i = 0, l = models.length; i < l; i++) { if (models[i] == null) { return false; } }