From a1c3acf984062b60bc686d94e3c69945e030521d Mon Sep 17 00:00:00 2001 From: asakusuma Date: Thu, 14 Apr 2016 15:32:45 -0700 Subject: [PATCH] [Glimmer2] Ensure falsy values do not become class names --- packages/ember-glimmer/lib/components/curly-component.js | 8 ++++++-- .../tests/integration/components/curly-components-test.js | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/ember-glimmer/lib/components/curly-component.js b/packages/ember-glimmer/lib/components/curly-component.js index ea3cf4229ab..bc6d62b0e34 100644 --- a/packages/ember-glimmer/lib/components/curly-component.js +++ b/packages/ember-glimmer/lib/components/curly-component.js @@ -74,13 +74,17 @@ class CurlyComponentManager { if (classNames) { classNames.forEach(name => { - operations.addAttribute('class', new ValueReference(name)); + if (name) { + operations.addAttribute('class', new ValueReference(name)); + } }); } if (classNameBindings) { classNameBindings.forEach(binding => { - applyClassNameBinding(component, binding, operations); + if (binding) { + applyClassNameBinding(component, binding, operations); + } }); } diff --git a/packages/ember-glimmer/tests/integration/components/curly-components-test.js b/packages/ember-glimmer/tests/integration/components/curly-components-test.js index 3515cde2374..17b688ee87d 100644 --- a/packages/ember-glimmer/tests/integration/components/curly-components-test.js +++ b/packages/ember-glimmer/tests/integration/components/curly-components-test.js @@ -185,7 +185,7 @@ moduleFor('Components test: curly components', class extends RenderingTest { this.assertComponentElement(this.firstChild, { tagName: 'div', content: 'hello', attrs: { 'class': classes('foo ember-view') } }); } - ['@htmlbars should not apply falsy class name']() { + ['@test should not apply falsy class name']() { this.registerComponent('foo-bar', { template: 'hello' }); this.render('{{foo-bar class=somethingFalsy}}', {