From 963cbbd8f59c936bb83766296bb60d7fa955dddd Mon Sep 17 00:00:00 2001 From: ef4 Date: Fri, 13 Jun 2025 18:19:54 +0000 Subject: [PATCH 1/3] Advance RFC 1003 to Stage recommended --- text/1003-deprecation-import-ember-from-ember.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/text/1003-deprecation-import-ember-from-ember.md b/text/1003-deprecation-import-ember-from-ember.md index 82c27a321e..c7773543f4 100644 --- a/text/1003-deprecation-import-ember-from-ember.md +++ b/text/1003-deprecation-import-ember-from-ember.md @@ -1,5 +1,5 @@ --- -stage: released +stage: recommended start-date: 2024-01-22T00:00:00.000Z release-date: release-versions: From 222a0d4fac063b4888969888d79929790c36b51f Mon Sep 17 00:00:00 2001 From: "Ember.js RFCS CI" Date: Fri, 13 Jun 2025 18:19:58 +0000 Subject: [PATCH 2/3] Update RFC 1003 recommended PR URL --- text/1003-deprecation-import-ember-from-ember.md | 1 + 1 file changed, 1 insertion(+) diff --git a/text/1003-deprecation-import-ember-from-ember.md b/text/1003-deprecation-import-ember-from-ember.md index c7773543f4..4ae5f76231 100644 --- a/text/1003-deprecation-import-ember-from-ember.md +++ b/text/1003-deprecation-import-ember-from-ember.md @@ -15,6 +15,7 @@ prs: accepted: 'https://github.com/emberjs/rfcs/pull/1003' ready-for-release: 'https://github.com/emberjs/rfcs/pull/1015' released: 'https://github.com/emberjs/rfcs/pull/1084' + recommended: 'https://github.com/emberjs/rfcs/pull/1110' project-link: --- From f5dde8fec589defbe10f5a74b37e09cef1cf305c Mon Sep 17 00:00:00 2001 From: Edward Faulkner Date: Fri, 23 Jan 2026 14:20:31 -0500 Subject: [PATCH 3/3] Update with details based on actual implementation --- text/1003-deprecation-import-ember-from-ember.md | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/text/1003-deprecation-import-ember-from-ember.md b/text/1003-deprecation-import-ember-from-ember.md index 4ae5f76231..bcf9e5b5c3 100644 --- a/text/1003-deprecation-import-ember-from-ember.md +++ b/text/1003-deprecation-import-ember-from-ember.md @@ -354,6 +354,7 @@ Unless otherwise stated, there will not be usage-based decision on these, as the |🌐 | `Ember._on` | `import { on } from '@ember/modifier';` | |🌐 | `Ember._fn` | `import { fn } from '@ember/helper';` | |🌐 | `Ember.ENV` | `import MyEnv from '/config/environment';` (for apps) or `owner.resolveRegistration('config:environment')` for addons| +|🌐 | `Ember.libraries` | `import { libraries } from '@ember/-internals/metal';` | [RFC-615]: https://rfcs.emberjs.com/id/0615-autotracking-memoization @@ -365,17 +366,10 @@ These can happen in any order - Add deprecations to each `Ember.*` access - Add the [Testing utilities](#testing-utilities) to `@ember/test`, if needed. - Add an `@ember/version` package to `ember-source` -- Add re-exports of private APIs, `ComputedProperty`, and `_setClassicDecorator` - These will still be deprecated on `Ember.`, and will be deprecated themselves as we progress through deprecating Ember Classic. +- ~Add re-exports of private APIs, `ComputedProperty`, and `_setClassicDecorator`~ + ~These will still be deprecated on `Ember.`, and will be deprecated themselves as we progress through deprecating Ember Classic.~ + This was proposed back when ember-concurrency relied on it, but current versions no longer do. - Update ember-inspector to use imports for the internals and instrumentation APIs -- Add `@ember/inspector-support` to `ember-source` to manage things like `LIBRARIES`. - ```js - import { libraries } from '@ember/inspector-support'; - - libraries.add('ember-data', '5.3.1'); - // and/or - libraries.addAll(depInfoFromPlugin); - ``` - Add deprecation guide entries for each API ## How We Teach This