From 2069a00a763da8b7ee1af9fc66b994de4534fa14 Mon Sep 17 00:00:00 2001
From: hakubo <bukaj.kelo+github@gmail.com>
Date: Fri, 30 Nov 2018 21:44:49 +0100
Subject: [PATCH 1/7] Draft of component-boolean-arguments RFC

---
 text/0000-component-boolean-argumens.md | 56 +++++++++++++++++++++++++
 1 file changed, 56 insertions(+)
 create mode 100644 text/0000-component-boolean-argumens.md

diff --git a/text/0000-component-boolean-argumens.md b/text/0000-component-boolean-argumens.md
new file mode 100644
index 0000000000..a71fa7cbcc
--- /dev/null
+++ b/text/0000-component-boolean-argumens.md
@@ -0,0 +1,56 @@
+- Start Date: 11/30/2018
+- RFC PR: (leave this empty)
+- Ember Issue: (leave this empty)
+
+# Component boolean Arguments
+
+## Summary
+
+This RFC proposes to add a boolean argument to components, that aligns with boolean attribute of regular DOM elements.
+
+## Motivation
+
+Currently to pass a boolean property to a component a developer has to explicitly pass `true` as an argument.
+e.g.
+```hbs
+<Button @secondary={{true}} />
+```
+This does allow the value to be a variable e.g.
+
+```hbs
+<Dialog @visible={{this.visible}} />
+```
+
+If the value is not a variable `{{}}` can actually be ommited as a `true` string is truthy leading to somewhat easier to remember syntax of
+```hbs
+<MyHackyBoolArgument @bool=true />
+```
+
+For simple usecases  it is verbose to write and does not align with HTML attributes like `disabled` of which value can be ommited as desribed in [HTML Spec](https://www.w3.org/TR/html5/infrastructure.html#sec-boolean-attributes)
+
+## Detailed design
+
+This RFC proposes that if argument is passed without any value it should have value `true` set inside of a component.
+
+```hbs
+<Form @disabled />
+```
+inside the Form component `@disabled` would equal to `true`.
+
+
+## How we teach this
+
+This should be include in guides and also should be easier to teach as it is inline with HTML spec for attributes.
+
+## Drawbacks
+
+
+
+## Alternatives
+
+In React if a prop is passed with no value it is truthy inside of a component.
+In Vue if a prop is passed with no value it is falsy inside of a component.
+
+## Unresolved questions
+
+None at the moment.

From 63c33ffc68251beba9c76abdbaf4f4b604532d06 Mon Sep 17 00:00:00 2001
From: hakubo <bukaj.kelo+github@gmail.com>
Date: Fri, 30 Nov 2018 21:50:08 +0100
Subject: [PATCH 2/7] fix typo

---
 text/0000-component-boolean-argumens.md | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/text/0000-component-boolean-argumens.md b/text/0000-component-boolean-argumens.md
index a71fa7cbcc..c78d90ee1d 100644
--- a/text/0000-component-boolean-argumens.md
+++ b/text/0000-component-boolean-argumens.md
@@ -40,16 +40,16 @@ inside the Form component `@disabled` would equal to `true`.
 
 ## How we teach this
 
-This should be include in guides and also should be easier to teach as it is inline with HTML spec for attributes.
+This should be included in guides and also should be easier to teach as it is inline with HTML spec for attributes.
 
 ## Drawbacks
 
-
+Can't think of any at the moment.
 
 ## Alternatives
 
-In React if a prop is passed with no value it is truthy inside of a component.
-In Vue if a prop is passed with no value it is falsy inside of a component.
+- In React if a prop is passed with no value it is truthy inside of a component.
+- In Vue if a prop is passed with no value it is falsy inside of a component.
 
 ## Unresolved questions
 

From 5d2903e6189f7f19c6480a90ab3d70e82e2183e1 Mon Sep 17 00:00:00 2001
From: hakubo <bukaj.kelo+github@gmail.com>
Date: Fri, 30 Nov 2018 21:52:09 +0100
Subject: [PATCH 3/7] rename file as it contained a typo

---
 ...nt-boolean-argumens.md => 0000-component-boolean-arguments.md} | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename text/{0000-component-boolean-argumens.md => 0000-component-boolean-arguments.md} (100%)

diff --git a/text/0000-component-boolean-argumens.md b/text/0000-component-boolean-arguments.md
similarity index 100%
rename from text/0000-component-boolean-argumens.md
rename to text/0000-component-boolean-arguments.md

From d1df5e357026de0da7c4bda5fe764ceef2ff6b90 Mon Sep 17 00:00:00 2001
From: hakubo <bukaj.kelo+github@gmail.com>
Date: Tue, 4 Dec 2018 15:45:20 +0100
Subject: [PATCH 4/7] attributes should also work the same way

---
 text/0000-component-boolean-arguments.md | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/text/0000-component-boolean-arguments.md b/text/0000-component-boolean-arguments.md
index c78d90ee1d..4338defba9 100644
--- a/text/0000-component-boolean-arguments.md
+++ b/text/0000-component-boolean-arguments.md
@@ -37,6 +37,22 @@ This RFC proposes that if argument is passed without any value it should have va
 ```
 inside the Form component `@disabled` would equal to `true`.
 
+This RFC also proposes that it should be possible to pass attributes without an explicit value e.g.
+
+```hbs
+<Input disabled />
+```
+
+and inside a component `...attributes` should also contain `disabled` attribute. e.g.
+
+```hbs
+<input ...attributes>
+```
+should render as:
+```html
+<input disabled>
+```
+
 
 ## How we teach this
 

From 7a3074ec7be7408b48bcee1a64ba4452dd562e73 Mon Sep 17 00:00:00 2001
From: hakubo <bukaj.kelo+github@gmail.com>
Date: Mon, 10 Dec 2018 10:13:25 +0100
Subject: [PATCH 5/7] add note about that hacky solution is hacky, also
 attributes work as expected

---
 text/0000-component-boolean-arguments.md | 39 ++++++++++++++++++------
 1 file changed, 30 insertions(+), 9 deletions(-)

diff --git a/text/0000-component-boolean-arguments.md b/text/0000-component-boolean-arguments.md
index 4338defba9..01fa17c8d2 100644
--- a/text/0000-component-boolean-arguments.md
+++ b/text/0000-component-boolean-arguments.md
@@ -21,34 +21,55 @@ This does allow the value to be a variable e.g.
 <Dialog @visible={{this.visible}} />
 ```
 
+### Hacky "solution"
 If the value is not a variable `{{}}` can actually be ommited as a `true` string is truthy leading to somewhat easier to remember syntax of
 ```hbs
 <MyHackyBoolArgument @bool=true />
 ```
+Since this is hacky, one have to remember that
+```hbs
+<MyHackyBoolArgument @bool=false />
+```
+would not work as `@bool=false` would pass a `false` as string that is truthy in JavaScript.
 
 For simple usecases  it is verbose to write and does not align with HTML attributes like `disabled` of which value can be ommited as desribed in [HTML Spec](https://www.w3.org/TR/html5/infrastructure.html#sec-boolean-attributes)
 
 ## Detailed design
 
-This RFC proposes that if argument is passed without any value it should have value `true` set inside of a component.
+This RFC proposes that if an argument is passed without any value it should have a value `true` set inside of a component.
 
+e.g.
 ```hbs
-<Form @disabled />
+<Button @secondary />
 ```
-inside the Form component `@disabled` would equal to `true`.
-
-This RFC also proposes that it should be possible to pass attributes without an explicit value e.g.
-
+inside the Button component `@secondary` should equal to `true`.
+e.g.
 ```hbs
-<Input disabled />
+<button class={{if @secondary "is-secondary"}}>
+  Button
+</button>
 ```
 
-and inside a component `...attributes` should also contain `disabled` attribute. e.g.
+should render as
+```html
+<button class="is-secondary">
+  Button
+</button>
+```
 
+### Align with attributes
+This would align with how attributes behave currently.
+Given an Input component:
 ```hbs
 <input ...attributes>
 ```
-should render as:
+
+if it is invoked like this:
+```hbs
+<Input disabled />
+```
+
+it will render as
 ```html
 <input disabled>
 ```

From 49bf7cce0bec74243813350098979d28740d3007 Mon Sep 17 00:00:00 2001
From: Jakub Olek <bukaj.kelo+github@gmail.com>
Date: Mon, 17 Dec 2018 23:45:03 +0100
Subject: [PATCH 6/7] Update info about the alternatives

---
 text/0000-component-boolean-arguments.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/text/0000-component-boolean-arguments.md b/text/0000-component-boolean-arguments.md
index 01fa17c8d2..2ecdd5e98d 100644
--- a/text/0000-component-boolean-arguments.md
+++ b/text/0000-component-boolean-arguments.md
@@ -85,8 +85,9 @@ Can't think of any at the moment.
 
 ## Alternatives
 
-- In React if a prop is passed with no value it is truthy inside of a component.
-- In Vue if a prop is passed with no value it is falsy inside of a component.
+- In both React and Vue if a prop is passed with no value it is truthy inside of a component.
+-- https://vuejs.org/v2/guide/components-props.html#Passing-a-Boolean
+-- https://reactjs.org/docs/jsx-in-depth.html#props-default-to-true
 
 ## Unresolved questions
 

From 8d6d88a802771be0414054dcabbafe9594a67c09 Mon Sep 17 00:00:00 2001
From: Jakub Olek <bukaj.kelo+github@gmail.com>
Date: Mon, 17 Dec 2018 23:46:08 +0100
Subject: [PATCH 7/7] fix bullet points

---
 text/0000-component-boolean-arguments.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/text/0000-component-boolean-arguments.md b/text/0000-component-boolean-arguments.md
index 2ecdd5e98d..f968932626 100644
--- a/text/0000-component-boolean-arguments.md
+++ b/text/0000-component-boolean-arguments.md
@@ -86,8 +86,8 @@ Can't think of any at the moment.
 ## Alternatives
 
 - In both React and Vue if a prop is passed with no value it is truthy inside of a component.
--- https://vuejs.org/v2/guide/components-props.html#Passing-a-Boolean
--- https://reactjs.org/docs/jsx-in-depth.html#props-default-to-true
+  - https://vuejs.org/v2/guide/components-props.html#Passing-a-Boolean
+  - https://reactjs.org/docs/jsx-in-depth.html#props-default-to-true
 
 ## Unresolved questions