From ee2ae0d40e04e8d51c1d68f8e0cf0dfd9477fed8 Mon Sep 17 00:00:00 2001 From: Peter Wagenet Date: Thu, 15 Dec 2022 15:40:42 -0800 Subject: [PATCH 1/4] Deprecated @ember/error --- text/0000-deprecate-ember-error.md | 42 ++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 text/0000-deprecate-ember-error.md diff --git a/text/0000-deprecate-ember-error.md b/text/0000-deprecate-ember-error.md new file mode 100644 index 0000000000..a97aceffcd --- /dev/null +++ b/text/0000-deprecate-ember-error.md @@ -0,0 +1,42 @@ +--- +stage: accepted +start-date: 2022-12-15 +release-date: +release-versions: +teams: # delete teams that aren't relevant + - framework + - typescript +prs: + accepted: # update this to the PR that you propose your RFC in +project-link: +--- + +# Deprecate @ember/error + +## Summary + +The @ember/error package is just a re-export of the native Error and is therefore unnecessary. + +## Motivation + +Removal of unnecessary code keeps the codebase cleaner and simplifies developer burden. + +## Transition Path + +There is no use case for this anymore. A simple codemod can convert current uses to the native Error class. + +## How We Teach This + +Remove @ember/error from docs. + +## Drawbacks + +You'll have to run a codemod to resolve existing usage. However, this is trivial and will actually simplify user code. + +## Alternatives + +None. + +## Unresolved questions + +None. From fdee8ad67e59a3b73eae620eff8afd105df85e53 Mon Sep 17 00:00:00 2001 From: Peter Wagenet Date: Thu, 15 Dec 2022 15:41:44 -0800 Subject: [PATCH 2/4] Update with RFC number --- text/0000-deprecate-ember-error.md | 2 +- text/0889-deprecate-ember-error.md | 42 ++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+), 1 deletion(-) create mode 100644 text/0889-deprecate-ember-error.md diff --git a/text/0000-deprecate-ember-error.md b/text/0000-deprecate-ember-error.md index a97aceffcd..eb7c931908 100644 --- a/text/0000-deprecate-ember-error.md +++ b/text/0000-deprecate-ember-error.md @@ -7,7 +7,7 @@ teams: # delete teams that aren't relevant - framework - typescript prs: - accepted: # update this to the PR that you propose your RFC in + accepted: https://github.com/emberjs/rfcs/pull/889 project-link: --- diff --git a/text/0889-deprecate-ember-error.md b/text/0889-deprecate-ember-error.md new file mode 100644 index 0000000000..a97aceffcd --- /dev/null +++ b/text/0889-deprecate-ember-error.md @@ -0,0 +1,42 @@ +--- +stage: accepted +start-date: 2022-12-15 +release-date: +release-versions: +teams: # delete teams that aren't relevant + - framework + - typescript +prs: + accepted: # update this to the PR that you propose your RFC in +project-link: +--- + +# Deprecate @ember/error + +## Summary + +The @ember/error package is just a re-export of the native Error and is therefore unnecessary. + +## Motivation + +Removal of unnecessary code keeps the codebase cleaner and simplifies developer burden. + +## Transition Path + +There is no use case for this anymore. A simple codemod can convert current uses to the native Error class. + +## How We Teach This + +Remove @ember/error from docs. + +## Drawbacks + +You'll have to run a codemod to resolve existing usage. However, this is trivial and will actually simplify user code. + +## Alternatives + +None. + +## Unresolved questions + +None. From 0d78d72a9b3f9d5aef1fb7bc57abf125069ba287 Mon Sep 17 00:00:00 2001 From: Chris Krycho Date: Thu, 15 Dec 2022 16:43:59 -0700 Subject: [PATCH 3/4] Delete 0000-deprecate-ember-error.md --- text/0000-deprecate-ember-error.md | 42 ------------------------------ 1 file changed, 42 deletions(-) delete mode 100644 text/0000-deprecate-ember-error.md diff --git a/text/0000-deprecate-ember-error.md b/text/0000-deprecate-ember-error.md deleted file mode 100644 index eb7c931908..0000000000 --- a/text/0000-deprecate-ember-error.md +++ /dev/null @@ -1,42 +0,0 @@ ---- -stage: accepted -start-date: 2022-12-15 -release-date: -release-versions: -teams: # delete teams that aren't relevant - - framework - - typescript -prs: - accepted: https://github.com/emberjs/rfcs/pull/889 -project-link: ---- - -# Deprecate @ember/error - -## Summary - -The @ember/error package is just a re-export of the native Error and is therefore unnecessary. - -## Motivation - -Removal of unnecessary code keeps the codebase cleaner and simplifies developer burden. - -## Transition Path - -There is no use case for this anymore. A simple codemod can convert current uses to the native Error class. - -## How We Teach This - -Remove @ember/error from docs. - -## Drawbacks - -You'll have to run a codemod to resolve existing usage. However, this is trivial and will actually simplify user code. - -## Alternatives - -None. - -## Unresolved questions - -None. From 1d34b49819504930a6ec948ae9b866c44b46d8a2 Mon Sep 17 00:00:00 2001 From: Peter Wagenet Date: Thu, 15 Dec 2022 15:46:07 -0800 Subject: [PATCH 4/4] Add link --- text/0889-deprecate-ember-error.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/text/0889-deprecate-ember-error.md b/text/0889-deprecate-ember-error.md index a97aceffcd..eb7c931908 100644 --- a/text/0889-deprecate-ember-error.md +++ b/text/0889-deprecate-ember-error.md @@ -7,7 +7,7 @@ teams: # delete teams that aren't relevant - framework - typescript prs: - accepted: # update this to the PR that you propose your RFC in + accepted: https://github.com/emberjs/rfcs/pull/889 project-link: ---