From 3fad72f9d22e802cf6df809f3a5c182fd20f74be Mon Sep 17 00:00:00 2001 From: Kenneth Larsen Date: Thu, 30 Aug 2018 14:40:17 +0200 Subject: [PATCH 1/3] Added section on model.save RFC --- source/blog/2018-08-31-the-ember-times-issue-62.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/source/blog/2018-08-31-the-ember-times-issue-62.md b/source/blog/2018-08-31-the-ember-times-issue-62.md index b99793cb39..181632276c 100644 --- a/source/blog/2018-08-31-the-ember-times-issue-62.md +++ b/source/blog/2018-08-31-the-ember-times-issue-62.md @@ -41,8 +41,14 @@ Read more in the [rendered pull request on GitHub](https://github.com/emberjs/rf --- -## [SECTION TITLE](#section-url) +## [RFC: I Promise You It's Good](#section-url) +[A new proposal](https://github.com/fivetanley/rfcs/blob/deprecate-promise-object-save/text/0000-ember-data-return-promise-from-ds-model-save.md) by [Stanley Stuart](https://github.com/fivetanley) to return a promise from `DS.Model.save()` is ready for you to read and comment. + +The idea here is to make `DS.Model.save()` return an `RSVP.Promise` instead of a `PromiseObject`. This is to remove the dependency on promise proxies, improve async consistency and enable new functionality in Ember Data. + +The only drawback of this is if you are already relying on this behaviour you’ll probably have to refactor your code to either use patterns like `async/await` or `ember-concurrency`. +[Read the whole proposal](https://github.com/fivetanley/rfcs/blob/deprecate-promise-object-save/text/0000-ember-data-return-promise-from-ds-model-save.md) and share your thoughts. --- From 47a1cb8a5b91ef05235c94627ed64dc6a2fcde00 Mon Sep 17 00:00:00 2001 From: Kenneth Larsen Date: Fri, 31 Aug 2018 06:54:07 +0200 Subject: [PATCH 2/3] Added section URL --- source/blog/2018-08-31-the-ember-times-issue-62.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/blog/2018-08-31-the-ember-times-issue-62.md b/source/blog/2018-08-31-the-ember-times-issue-62.md index 181632276c..bbff1a3f27 100644 --- a/source/blog/2018-08-31-the-ember-times-issue-62.md +++ b/source/blog/2018-08-31-the-ember-times-issue-62.md @@ -41,7 +41,7 @@ Read more in the [rendered pull request on GitHub](https://github.com/emberjs/rf --- -## [RFC: I Promise You It's Good](#section-url) +## [RFC: I Promise You It's Good](https://github.com/fivetanley/rfcs/blob/deprecate-promise-object-save/text/0000-ember-data-return-promise-from-ds-model-save.md) [A new proposal](https://github.com/fivetanley/rfcs/blob/deprecate-promise-object-save/text/0000-ember-data-return-promise-from-ds-model-save.md) by [Stanley Stuart](https://github.com/fivetanley) to return a promise from `DS.Model.save()` is ready for you to read and comment. The idea here is to make `DS.Model.save()` return an `RSVP.Promise` instead of a `PromiseObject`. This is to remove the dependency on promise proxies, improve async consistency and enable new functionality in Ember Data. From deac84bf173b82390eabcc8d5e6fb6076efec0ce Mon Sep 17 00:00:00 2001 From: Kenneth Larsen Date: Fri, 31 Aug 2018 07:49:50 +0200 Subject: [PATCH 3/3] Added link to Ember Concurrency --- source/blog/2018-08-31-the-ember-times-issue-62.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/blog/2018-08-31-the-ember-times-issue-62.md b/source/blog/2018-08-31-the-ember-times-issue-62.md index 96b31123f1..f12f55b5e8 100644 --- a/source/blog/2018-08-31-the-ember-times-issue-62.md +++ b/source/blog/2018-08-31-the-ember-times-issue-62.md @@ -46,7 +46,7 @@ Read more in the [rendered pull request on GitHub](https://github.com/emberjs/rf The idea here is to make `DS.Model.save()` return an `RSVP.Promise` instead of a `PromiseObject`. This is to remove the dependency on promise proxies, improve async consistency and enable new functionality in Ember Data. -The only drawback of this is if you are already relying on this behaviour you’ll probably have to refactor your code to either use patterns like `async/await` or `ember-concurrency`. +The only drawback of this is if you are already relying on this behaviour you’ll probably have to refactor your code to either use patterns like `async/await` or [ember-concurrency](http://ember-concurrency.com/). [Read the whole proposal](https://github.com/fivetanley/rfcs/blob/deprecate-promise-object-save/text/0000-ember-data-return-promise-from-ds-model-save.md) and share your thoughts.