Mentors: Submit StoryQuest Upstream

[hydrolet]

This guide has moved to https://github.com/endlessm/threadbare/wiki/StoryQuest-submission

[wjt]

Sorry to the real GitHub users inadvertently tagged here – I have updated the example to use a fenced code block, and to use invalid GitHub usernames.

[manuq]

Something to add to the submission criteria: If a Story Quest defines a class, it must use the Story Quest name as prefix:

• 👍 class_name BrocolliAliensEnemy
• 👎 class_name Enemy

The reason is that there aren't namespaces in Godot. So if a Story Quest picks "Enemy" for their game entities class, then that class name is taken and no-other Story Quest (or even the game's Lore) can use that class name in their own entities.

[manuq]

I found myself unable to review a StoryQuest submission from the GitHub website, because of the amount of files changed. So I did it with CLI commands. I have started a new guide with those commands so I don't forget them: #957. Hopefully it can be useful to other reviewers too.

[manuq]

After the first submissions with wrong licensing, maybe we should clarify here:

Asset contributions are made under the Creative Commons Attribution-ShareAlike 4.0 International license permitting free reuse of the work provided that the original author is credited and that the work remains in the open.

Clarification I'd add: "If the assets come from a third-party make sure that it has a CC-BY-SA 4.0 or CC0 license. It is not enough if the assets are free to use but not allowed to be redistributed".

[wjt]

Other licenses are acceptable -- e.g. https://creativecommons.org/licenses/by/4.0/ -- but that one seems to be quite rare for some reason.

[wjt]

I've amended that section to refer to https://github.com/endlessm/threadbare/blob/main/docs/LICENSING.md and differentiate between original code & assets (MPL and CC-BY-SA-4.0) and third-party assets (must comply with that page).