Fix permission denied, mkdir '/home/runner' on a self-hosted runner#14
Conversation
Signed-off-by: Kazuki Suda <kazuki.suda@gmail.com>
| await io.mkdirP(binPath); | ||
| await exec.exec("chmod", ["+x", downloadPath]); | ||
| await io.mv(downloadPath, path.join(binPath, "kind")); | ||
| let toolPath: string = tc.find("kind", version); |
There was a problem hiding this comment.
Is this because the tool has already been downloaded on the runner?
Then I would much rather make the check outside of downloadKind - what do you think?
There was a problem hiding this comment.
Actually, in this case, it might even make sense to expose this as a config for the action?
There was a problem hiding this comment.
Then I would much rather make the check outside of downloadKind - what do you think?
It is better. I'll change it that way.
There was a problem hiding this comment.
Generally, downloaded tools in actions are cached and reused (e.g., actions/setup-go), so I feel that there is no need to expose it as a config. Is my understanding correct?
There was a problem hiding this comment.
Then I would much rather make the check outside of downloadKind - what do you think?
I did it at 2db0c02.
superbrothers
force-pushed
the
fix-permission-denied
branch
from
76e5e91 to
2db0c02
Compare
radu-matei
left a comment
radu-matei
left a comment
There was a problem hiding this comment.
This is excellent, thanks a lot!
2 participants
Fixes #13