From 5f0454d31e751499fe6473c1df9cc5953ea3318a Mon Sep 17 00:00:00 2001 From: Aaron Ayres Date: Mon, 16 Nov 2020 12:11:47 -0600 Subject: [PATCH 1/2] remove deprecated create_log_file_handler --- apptools/logger/api.py | 2 +- apptools/logger/logger.py | 28 ---------------------------- 2 files changed, 1 insertion(+), 29 deletions(-) diff --git a/apptools/logger/api.py b/apptools/logger/api.py index 603c6d971..be9797e16 100644 --- a/apptools/logger/api.py +++ b/apptools/logger/api.py @@ -1,4 +1,4 @@ -from .logger import add_log_queue_handler, create_log_file_handler +from .logger import add_log_queue_handler from .logger import FORMATTER, LEVEL, LogFileHandler from .log_point import log_point from .filtering_handler import FilteringHandler diff --git a/apptools/logger/logger.py b/apptools/logger/logger.py index 28c9b48dd..43d0a3b76 100644 --- a/apptools/logger/logger.py +++ b/apptools/logger/logger.py @@ -51,34 +51,6 @@ def __init__( self.setLevel(level) -@deprecated('use "LogFileHandler"') -def create_log_file_handler( - path, maxBytes=1000000, backupCount=3, level=None, formatter=None -): - """Creates a log file handler. - - This is just a convenience function to make it easy to create the same - kind of handlers across applications. - - It sets the handler's formatter to the default formatter, and its logging - level to the default logging level. - - """ - if level is None: - level = LEVEL - if formatter is None: - formatter = FORMATTER - - handler = RotatingFileHandler( - path, maxBytes=maxBytes, backupCount=backupCount - ) - - handler.setFormatter(formatter) - handler.setLevel(level) - - return handler - - def add_log_queue_handler(logger, level=None, formatter=None): """Adds a queueing log handler to a logger.""" if level is None: From e5ef995b56607f9cde5d2c06538aa876a57e1a51 Mon Sep 17 00:00:00 2001 From: Aaron Ayres Date: Mon, 16 Nov 2020 12:15:20 -0600 Subject: [PATCH 2/2] add news fragment --- docs/releases/upcoming/218.removal.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/releases/upcoming/218.removal.rst diff --git a/docs/releases/upcoming/218.removal.rst b/docs/releases/upcoming/218.removal.rst new file mode 100644 index 000000000..070bf361f --- /dev/null +++ b/docs/releases/upcoming/218.removal.rst @@ -0,0 +1 @@ +Remove deprecated create_log_file_handler function (#218) \ No newline at end of file